clang-tidy (#9)

- Fixed some clang-tidy warnings
- Fixed issue with omnitrace_launch_compiler + clang-tidy

source/lib/omnitrace/library.cpp

@@ -1022,7 +1022,7 @@ omnitrace_finalize_hidden(void)
         auto& _aitr = get_timemory_hash_aliases(i);
         if(_hzero && _hitr)
         {
-            for(auto itr : *_hitr)
+            for(const auto& itr : *_hitr)
                 _hzero->emplace(itr.first, itr.second);
         }
         if(_azero && _aitr)

source/lib/omnitrace/library/components/fwd.hpp

@@ -53,10 +53,8 @@ TIMEMORY_DECLARE_TYPE_TRAIT(name, typename Tp)
         static constexpr auto value = NAME;                                              \
     };                                                                                   \
     template <>                                                                          \
-    struct name<type_list<__VA_ARGS__>>                                                  \
-    {                                                                                    \
-        static constexpr auto value = NAME;                                              \
-    };                                                                                   \
+    struct name<type_list<__VA_ARGS__>> : name<__VA_ARGS__>                              \
+    {};                                                                                  \
     }                                                                                    \
     }
 

source/lib/omnitrace/library/thread_sampler.cpp

@@ -36,7 +36,6 @@ namespace thread_sampler
 {
 namespace
 {
-using tim::type_mutex;
 using auto_lock_t                                       = tim::auto_lock_t;
 using promise_t                                         = std::promise<void>;
 std::unique_ptr<promise_t>             polling_finished = {};