From 6b86bb1618a4132e5966a325f754b5fa17cd4c24 Mon Sep 17 00:00:00 2001 From: Sarbojit Sarkar Date: Tue, 25 Jan 2022 07:25:42 +0000 Subject: [PATCH] SWDEV-315595 - Fix for hipGraphAddMemcpyNodeToSymbol -ve tests Change-Id: If389f533567a236a598f16e4f2c477157beb2e56 [ROCm/clr commit: 15dd9fc1da908747af2590a2443e6bb9c86b0b8c] --- projects/clr/hipamd/src/hip_graph.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/projects/clr/hipamd/src/hip_graph.cpp b/projects/clr/hipamd/src/hip_graph.cpp index ba0f09bf1d..fa625a0902 100644 --- a/projects/clr/hipamd/src/hip_graph.cpp +++ b/projects/clr/hipamd/src/hip_graph.cpp @@ -1363,6 +1363,10 @@ hipError_t hipGraphAddMemcpyNodeToSymbol(hipGraphNode_t* pGraphNode, hipGraph_t hipMemcpyKind kind) { HIP_INIT_API(hipGraphAddMemcpyNodeToSymbol, pGraphNode, graph, pDependencies, numDependencies, symbol, src, count, offset, kind); + if (pGraphNode == nullptr || graph == nullptr || src == nullptr || + (pDependencies == nullptr && numDependencies > 0)) { + HIP_RETURN(hipErrorInvalidValue); + } size_t sym_size = 0; hipDeviceptr_t device_ptr = nullptr; hipError_t status = ihipMemcpySymbol_validate(symbol, count, offset, sym_size, device_ptr); @@ -1370,6 +1374,9 @@ hipError_t hipGraphAddMemcpyNodeToSymbol(hipGraphNode_t* pGraphNode, hipGraph_t HIP_RETURN(status); } *pGraphNode = new hipGraphMemcpyNodeToSymbol(symbol, src, count, offset, kind); + if (*pGraphNode == nullptr) { + HIP_RETURN(hipErrorInvalidValue); + } ihipGraphAddNode(*pGraphNode, graph, pDependencies, numDependencies); HIP_RETURN(hipSuccess); }