From 6db2644766b0628c7a2f9564d930be051bf7a6f5 Mon Sep 17 00:00:00 2001
From: corey-derochie-amd
 <161367113+corey-derochie-amd@users.noreply.github.com>
Date: Wed, 30 Oct 2024 16:48:54 -0600
Subject: [PATCH] Set minimum ROCm version for MSCCLPP to 6.2 (#1401)

* Added ROCm version check around setting `ENABLE_MSCCLPP` flag.
---
 CMakeLists.txt | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index e4b3603543..b57363b1bb 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -297,11 +297,13 @@ endif()
 
 ## Disable building MSCCL++ if the build environment is invalid
 ## Currently MSCCL++ is supported only on gfx942
-if (ENABLE_MSCCLPP)
-  if(NOT ("gfx942" IN_LIST GPU_TARGETS OR "gfx942:xnack-" IN_LIST GPU_TARGETS OR "gfx942:xnack+" IN_LIST GPU_TARGETS))
-    set(ENABLE_MSCCLPP OFF)
-    message(WARNING "Can only build MSCCL++ for gfx942; disabling MSCCL++ build")
-  endif()
+if (ENABLE_MSCCLPP AND NOT ("gfx942" IN_LIST GPU_TARGETS OR "gfx942:xnack-" IN_LIST GPU_TARGETS OR "gfx942:xnack+" IN_LIST GPU_TARGETS))
+  set(ENABLE_MSCCLPP OFF)
+  message(WARNING "Can only build MSCCL++ for gfx942; disabling MSCCL++ build")
+endif()
+if (ENABLE_MSCCLPP AND ROCM_VERSION VERSION_LESS "60200")
+  set(ENABLE_MSCCLPP OFF)
+  message(WARNING "MSCCL++ integration only supported on ROCm 6.2 or greater; disabling MSCCL++ build")
 endif()
 
 # Determine version from makefiles/version.mk and fill in templates
@@ -828,7 +830,6 @@ endif()
 
 if(ENABLE_MSCCLPP)
   include(cmake/MSCCLPP.cmake)
-  message(STATUS "Building MSCCL++ with NCCL API support")
 endif()
 
 ## Track linking time