From 6ebe7822ccbf52e9a2bf88ededd95b43882a956c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mirza=20Halil=C4=8Devi=C4=87?=
 <109971222+mirza-halilcevic@users.noreply.github.com>
Date: Wed, 2 Nov 2022 14:55:37 +0100
Subject: [PATCH] Implement tests for hipDeviceGetDefaultMemPool (#2875)

- Test that returned mem_pool is not a nullptr
- Tests with invalid parameters.
---
 tests/catch/unit/device/CMakeLists.txt        |  1 +
 .../unit/device/hipDeviceGetDefaultMemPool.cc | 57 +++++++++++++++++++
 2 files changed, 58 insertions(+)
 create mode 100644 tests/catch/unit/device/hipDeviceGetDefaultMemPool.cc

diff --git a/tests/catch/unit/device/CMakeLists.txt b/tests/catch/unit/device/CMakeLists.txt
index 4dc6c79021..87b37b1d32 100644
--- a/tests/catch/unit/device/CMakeLists.txt
+++ b/tests/catch/unit/device/CMakeLists.txt
@@ -17,6 +17,7 @@ set(TEST_SRC
     hipSetGetDevice.cc
     hipDeviceGetUuid.cc
     hipDeviceGetP2PAttribute.cc
+    hipDeviceGetDefaultMemPool.cc
     hipExtGetLinkTypeAndHopCount.cc
     hipDeviceSetLimit.cc
 )
diff --git a/tests/catch/unit/device/hipDeviceGetDefaultMemPool.cc b/tests/catch/unit/device/hipDeviceGetDefaultMemPool.cc
new file mode 100644
index 0000000000..822c2ab81c
--- /dev/null
+++ b/tests/catch/unit/device/hipDeviceGetDefaultMemPool.cc
@@ -0,0 +1,57 @@
+/*
+Copyright (c) 2022 Advanced Micro Devices, Inc. All rights reserved.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
+*/
+
+#include <hip_test_common.hh>
+#include <hip/hip_runtime_api.h>
+
+TEST_CASE("Unit_hipDeviceGetDefaultMemPool_Positive_Basic") {
+  const int device = GENERATE(range(0, HipTest::getDeviceCount()));
+
+  int mem_pool_support = 0;
+  HIP_CHECK(
+      hipDeviceGetAttribute(&mem_pool_support, hipDeviceAttributeMemoryPoolsSupported, device));
+  if (!mem_pool_support) {
+    HipTest::HIP_SKIP_TEST("Test only runs on devices with memory pool support");
+    return;
+  }
+
+  hipMemPool_t mem_pool;
+  HIP_CHECK(hipDeviceGetDefaultMemPool(&mem_pool, device));
+  REQUIRE(mem_pool != nullptr);
+}
+
+TEST_CASE("Unit_hipDeviceGetDefaultMemPool_Negative_Parameters") {
+  hipMemPool_t mem_pool;
+
+  SECTION("mem_pool == nullptr") {
+    HIP_CHECK_ERROR(hipDeviceGetDefaultMemPool(nullptr, 0), hipErrorInvalidValue);
+  }
+
+  SECTION("device < 0") {
+    HIP_CHECK_ERROR(hipDeviceGetDefaultMemPool(&mem_pool, -1), hipErrorInvalidDevice);
+  }
+
+  SECTION("device ordinance too large") {
+    HIP_CHECK_ERROR(hipDeviceGetDefaultMemPool(&mem_pool, HipTest::getDeviceCount()),
+                    hipErrorInvalidDevice);
+  }
+}
\ No newline at end of file