From 6f7965796fe8a5d18934be01849dfe1f8245c7bf Mon Sep 17 00:00:00 2001 From: Bertan Dogancay <111835151+BertanDogancay@users.noreply.github.com> Date: Wed, 4 Oct 2023 09:46:11 -0600 Subject: [PATCH] Revert "Remove 2H4P condition from P2P channels adjustment (#890)" (#904) This reverts commit 057e30e70556d454e2b57b5b2cfed9c850fb4803. [ROCm/rccl commit: a6ff4618c77eb880427094fa4b8f2e0e6941c69a] --- projects/rccl/src/graph/paths.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/rccl/src/graph/paths.cc b/projects/rccl/src/graph/paths.cc index 2e0f7f7937..5df512b108 100644 --- a/projects/rccl/src/graph/paths.cc +++ b/projects/rccl/src/graph/paths.cc @@ -812,7 +812,7 @@ ncclResult_t ncclTopoComputeP2pChannels(struct ncclComm* comm) { // Adjust P2P channels on Intel platform comm->p2pnChannelsPerPeer = 1; comm->p2pnChannels = 2; - } else if (comm->topo->nodes[GPU].count == comm->topo->nRanks && !(comm->topo->type & RCCL_TOPO_GDR_ALL) && !(comm->topo->type & RCCL_TOPO_XGMI_ALL)) { + } else if (comm->topo->nodes[GPU].count == comm->topo->nRanks && (comm->topo->type & RCCL_TOPO_4P2H_ROME) && !(comm->topo->type & RCCL_TOPO_GDR_ALL) && !(comm->topo->type & RCCL_TOPO_XGMI_ALL)) { // Adjust P2P channels on Rome comm->p2pnChannelsPerPeer = 2; comm->p2pnChannels = 2;