[rocprofiler-compute] improve config management system (#2359)

2026-01-14 13:20:27 -05:00
parent d7ff927690
commit 71b9ea6ba0
25 changed files with 1407 additions and 20261 deletions
@@ -24,25 +24,91 @@
 ##############################################################################

 import hashlib
+import json
 from pathlib import Path

 import pytest
-import yaml
+
+PROJECT_ROOT = Path(__file__).resolve().parents[1]
+HASH_DB = PROJECT_ROOT / "src/utils/.config_hashes.json"
+ANALYSIS_CONFIGS = PROJECT_ROOT / "src/rocprof_compute_soc/analysis_configs"


-@pytest.mark.skip(
-    reason=(
-        "TODO: Skip this test until we use "
-        "tools/config_management/.config.hashes.json for testing"
+def md5(path: Path) -> str:
+    return hashlib.md5(path.read_bytes()).hexdigest()
+
+
+def test_config_hashes_match_files() -> None:
+    assert HASH_DB.exists(), f"Missing hash DB: {HASH_DB}"
+    assert ANALYSIS_CONFIGS.exists(), (
+        f"Missing analysis configs dir: {ANALYSIS_CONFIGS}"
    )
-)
-def test_modification_time():
-    # Ensure hash map consistency
-    hash_path = Path("tools/autogen_hash.yaml")
-    with open(hash_path) as f:
-        hash_map = yaml.safe_load(f)
-    for file, hash in hash_map.items():
-        file_hash = hashlib.sha256(Path(file).read_bytes()).hexdigest()
-        assert file_hash == hash, (
-            f"Hash mismatch for {file}: expected {hash}, got {file_hash}"
-        )
+
+    with HASH_DB.open() as f:
+        data = json.load(f)
+
+    assert "archs" in data, "Hash DB missing 'archs' key"
+    assert isinstance(data["archs"], dict)
+
+    failures = []
+
+    for arch, arch_data in data["archs"].items():
+        arch_dir = ANALYSIS_CONFIGS / arch
+        if not arch_dir.exists():
+            failures.append(f"Arch directory missing: {arch_dir}")
+            continue
+
+        # -------------------------
+        # Panel YAMLs
+        # -------------------------
+        files = arch_data.get("files", {})
+        if not isinstance(files, dict):
+            failures.append(f"'files' for {arch} is not a dict")
+            continue
+
+        for rel_path, expected_hash in files.items():
+            panel_path = arch_dir / rel_path
+            if not panel_path.exists():
+                failures.append(f"Missing panel file: {panel_path}")
+                continue
+
+            actual_hash = md5(panel_path)
+            if actual_hash != expected_hash:
+                failures.append(
+                    f"[{arch}] Panel hash mismatch: {panel_path}\n"
+                    f"  expected: {expected_hash}\n"
+                    f"  actual:   {actual_hash}"
+                )
+
+        # -------------------------
+        # Delta YAML (if any)
+        # -------------------------
+        delta_hash = arch_data.get("delta_hash")
+
+        if delta_hash is not None:
+            delta_dir = arch_dir / "config_delta"
+            if not delta_dir.exists():
+                failures.append(f"[{arch}] Missing config_delta directory")
+                continue
+
+            # Exactly one *_diff.yaml should exist
+            delta_files = list(delta_dir.glob("*_diff.yaml"))
+            if len(delta_files) != 1:
+                failures.append(
+                    f"[{arch}] Expected exactly one delta file, found "
+                    f"{len(delta_files)} in {delta_dir}"
+                )
+                continue
+
+            delta_path = delta_files[0]
+            actual_delta_hash = md5(delta_path)
+
+            if actual_delta_hash != delta_hash:
+                failures.append(
+                    f"[{arch}] Delta hash mismatch: {delta_path}\n"
+                    f"  expected: {delta_hash}\n"
+                    f"  actual:   {actual_delta_hash}"
+                )
+
+    if failures:
+        pytest.fail("Hash consistency failures:\n\n" + "\n".join(failures))