From 72af81c5284ddbf2c2b07298c0667cc80ecaaee5 Mon Sep 17 00:00:00 2001 From: cfallows-amd Date: Fri, 16 May 2025 12:54:53 -0400 Subject: [PATCH] Check mode during soc init for roofline (#705) Check mode before creating roofline object- skip if only printing specs Signed-off-by: Carrie Fallows [ROCm/rocprofiler-compute commit: 43dbf38b2730b1d1d985780fd32ed511623d44d7] --- .../rocprofiler-compute/src/rocprof_compute_soc/soc_gfx90a.py | 4 +++- .../rocprofiler-compute/src/rocprof_compute_soc/soc_gfx940.py | 4 +++- .../rocprofiler-compute/src/rocprof_compute_soc/soc_gfx941.py | 4 +++- .../rocprofiler-compute/src/rocprof_compute_soc/soc_gfx942.py | 4 +++- .../rocprofiler-compute/src/rocprof_compute_soc/soc_gfx950.py | 4 +++- 5 files changed, 15 insertions(+), 5 deletions(-) diff --git a/projects/rocprofiler-compute/src/rocprof_compute_soc/soc_gfx90a.py b/projects/rocprofiler-compute/src/rocprof_compute_soc/soc_gfx90a.py index 311b65e18e..56e1dc39d6 100644 --- a/projects/rocprofiler-compute/src/rocprof_compute_soc/soc_gfx90a.py +++ b/projects/rocprofiler-compute/src/rocprof_compute_soc/soc_gfx90a.py @@ -64,7 +64,9 @@ class gfx90a_soc(OmniSoC_Base): "GDS": 4, } ) - self.roofline_obj = Roofline(args, self._mspec) + # Create roofline object if mode is provided; skip for --specs + if hasattr(self.get_args(), "mode") and self.get_args().mode: + self.roofline_obj = Roofline(args, self._mspec) # Set arch specific specs self._mspec._l2_banks = 32 diff --git a/projects/rocprofiler-compute/src/rocprof_compute_soc/soc_gfx940.py b/projects/rocprofiler-compute/src/rocprof_compute_soc/soc_gfx940.py index e28c6eb8f9..9a007cc8ab 100644 --- a/projects/rocprofiler-compute/src/rocprof_compute_soc/soc_gfx940.py +++ b/projects/rocprofiler-compute/src/rocprof_compute_soc/soc_gfx940.py @@ -64,7 +64,9 @@ class gfx940_soc(OmniSoC_Base): "GDS": 4, } ) - self.roofline_obj = Roofline(args, self._mspec) + # Create roofline object if mode is provided; skip for --specs + if hasattr(self.get_args(), "mode") and self.get_args().mode: + self.roofline_obj = Roofline(args, self._mspec) # Set arch specific specs self._mspec._l2_banks = 16 diff --git a/projects/rocprofiler-compute/src/rocprof_compute_soc/soc_gfx941.py b/projects/rocprofiler-compute/src/rocprof_compute_soc/soc_gfx941.py index ca52935b59..a360302e75 100644 --- a/projects/rocprofiler-compute/src/rocprof_compute_soc/soc_gfx941.py +++ b/projects/rocprofiler-compute/src/rocprof_compute_soc/soc_gfx941.py @@ -64,7 +64,9 @@ class gfx941_soc(OmniSoC_Base): "GDS": 4, } ) - self.roofline_obj = Roofline(args, self._mspec) + # Create roofline object if mode is provided; skip for --specs + if hasattr(self.get_args(), "mode") and self.get_args().mode: + self.roofline_obj = Roofline(args, self._mspec) # Set arch specific specs self._mspec._l2_banks = 16 diff --git a/projects/rocprofiler-compute/src/rocprof_compute_soc/soc_gfx942.py b/projects/rocprofiler-compute/src/rocprof_compute_soc/soc_gfx942.py index 19da8f6de4..0efb5d85bd 100644 --- a/projects/rocprofiler-compute/src/rocprof_compute_soc/soc_gfx942.py +++ b/projects/rocprofiler-compute/src/rocprof_compute_soc/soc_gfx942.py @@ -64,7 +64,9 @@ class gfx942_soc(OmniSoC_Base): "GDS": 4, } ) - self.roofline_obj = Roofline(args, self._mspec) + # Create roofline object if mode is provided; skip for --specs + if hasattr(self.get_args(), "mode") and self.get_args().mode: + self.roofline_obj = Roofline(args, self._mspec) # Set arch specific specs self._mspec._l2_banks = 16 diff --git a/projects/rocprofiler-compute/src/rocprof_compute_soc/soc_gfx950.py b/projects/rocprofiler-compute/src/rocprof_compute_soc/soc_gfx950.py index ba93e2aab0..63a1d5ce3e 100644 --- a/projects/rocprofiler-compute/src/rocprof_compute_soc/soc_gfx950.py +++ b/projects/rocprofiler-compute/src/rocprof_compute_soc/soc_gfx950.py @@ -63,7 +63,9 @@ class gfx950_soc(OmniSoC_Base): "TCC_channels": 16, } ) - self.roofline_obj = Roofline(args, self._mspec) + # Create roofline object if mode is provided; skip for --specs + if hasattr(self.get_args(), "mode") and self.get_args().mode: + self.roofline_obj = Roofline(args, self._mspec) # Set arch specific specs self._mspec._l2_banks = 16