Restructure code object source code (#826)

* public codeobj info

* Restructure code object source code file layout

* Update get_unloaded_code_objects + add iterate_loaded_code_objects

* Remove get_unloaded_code_objects from visible internal API

- iterate_loaded_code_objects + functor which filters on the hsa_executable_t effectively reproduces this behavior

* Whitespace removal

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

source/lib/rocprofiler-sdk/hsa/CMakeLists.txt

@@ -3,7 +3,6 @@ set(ROCPROFILER_LIB_HSA_SOURCES
     agent_cache.cpp
     aql_packet.cpp
     async_copy.cpp
-    code_object.cpp
     hsa_barrier.cpp
     hsa.cpp
     pc_sampling.hpp
@@ -16,7 +15,6 @@ set(ROCPROFILER_LIB_HSA_HEADERS
     agent_cache.hpp
     aql_packet.hpp
     async_copy.hpp
-    code_object.hpp
     defines.hpp
     hsa_barrier.hpp
     hsa.hpp

source/lib/rocprofiler-sdk/hsa/code_object.hpp

@@ -1,58 +0,0 @@
-// MIT License
-//
-// Copyright (c) 2023 Advanced Micro Devices, Inc. All rights reserved.
-//
-// Permission is hereby granted, free of charge, to any person obtaining a copy
-// of this software and associated documentation files (the "Software"), to deal
-// in the Software without restriction, including without limitation the rights
-// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-// copies of the Software, and to permit persons to whom the Software is
-// furnished to do so, subject to the following conditions:
-//
-// The above copyright notice and this permission notice shall be included in
-// all copies or substantial portions of the Software.
-//
-// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
-// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-// THE SOFTWARE.
-
-#pragma once
-
-#include <hsa/hsa_api_trace.h>
-
-#include <cstdint>
-#include <vector>
-
-namespace rocprofiler
-{
-namespace hsa
-{
-namespace code_object
-{
-const char*
-name_by_id(uint32_t id);
-
-uint32_t
-id_by_name(const char* name);
-
-std::vector<const char*>
-get_names();
-
-std::vector<uint32_t>
-get_ids();
-}  // namespace code_object
-
-void
-code_object_init(HsaApiTable* table);
-
-uint64_t
-get_kernel_id(uint64_t kernel_object);
-
-void
-code_object_shutdown();
-}  // namespace hsa
-}  // namespace rocprofiler

source/lib/rocprofiler-sdk/hsa/queue.cpp

@@ -24,8 +24,8 @@
 #include "lib/common/utility.hpp"
 #include "lib/rocprofiler-sdk/agent.hpp"
 #include "lib/rocprofiler-sdk/buffer.hpp"
+#include "lib/rocprofiler-sdk/code_object/code_object.hpp"
 #include "lib/rocprofiler-sdk/context/context.hpp"
-#include "lib/rocprofiler-sdk/hsa/code_object.hpp"
 #include "lib/rocprofiler-sdk/hsa/details/fmt.hpp"
 #include "lib/rocprofiler-sdk/hsa/hsa.hpp"
 #include "lib/rocprofiler-sdk/hsa/queue_controller.hpp"
@@ -270,7 +270,7 @@ WriteInterceptor(const void* packets,
         queue.async_started();
         // Copy kernel pkt, copy is to allow for signal to be modified
         rocprofiler_packet kernel_pkt = packets_arr[i];
-        uint64_t           kernel_id  = get_kernel_id(kernel_pkt.kernel_dispatch.kernel_object);
+        uint64_t kernel_id = code_object::get_kernel_id(kernel_pkt.kernel_dispatch.kernel_object);
         queue.create_signal(HSA_AMD_SIGNAL_AMD_GPU_ONLY,
                             &kernel_pkt.ext_amd_aql_pm4.completion_signal);