From 73efd3a14e6dfeae7eb226abf36f095fd81c8d18 Mon Sep 17 00:00:00 2001 From: David Yat Sin Date: Wed, 4 Oct 2023 14:11:12 +0000 Subject: [PATCH] libhsakmt: Fix incorrect flags for ext coherence Change-Id: I89c838b9fbdb85589691f29806ae15884b25592f --- src/fmm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/fmm.c b/src/fmm.c index 76ddc40f4f..7b5a5fbe3a 100644 --- a/src/fmm.c +++ b/src/fmm.c @@ -1047,7 +1047,7 @@ static HSAKMT_STATUS fmm_register_mem_svm_api(void *address, args->attrs[0].type = coarse_grain ? HSA_SVM_ATTR_CLR_FLAGS : HSA_SVM_ATTR_SET_FLAGS; args->attrs[0].value = HSA_SVM_FLAG_COHERENT; - args->attrs[1].type = ext_coherent ? HSA_SVM_ATTR_CLR_FLAGS : HSA_SVM_ATTR_SET_FLAGS; + args->attrs[1].type = ext_coherent ? HSA_SVM_ATTR_SET_FLAGS : HSA_SVM_ATTR_CLR_FLAGS ; args->attrs[1].value = HSA_SVM_FLAG_EXT_COHERENT; pr_debug("Registering to SVM %p size: %ld\n", (void*)aligned_addr, aligned_size); @@ -3447,7 +3447,7 @@ static HSAKMT_STATUS fmm_register_user_memory(void *addr, KFD_IOC_ALLOC_MEM_FLAGS_WRITABLE | KFD_IOC_ALLOC_MEM_FLAGS_EXECUTABLE | (coarse_grain ? 0 : KFD_IOC_ALLOC_MEM_FLAGS_COHERENT) | - (ext_coherent ? 0 : KFD_IOC_ALLOC_MEM_FLAGS_EXT_COHERENT), + (ext_coherent ? KFD_IOC_ALLOC_MEM_FLAGS_EXT_COHERENT : 0), &obj); if (!svm_addr) return HSAKMT_STATUS_ERROR;