From 74ebbe17e915e3ae49a1b900e802769a048da442 Mon Sep 17 00:00:00 2001 From: kjayapra-amd Date: Tue, 24 Sep 2024 14:13:00 -0400 Subject: [PATCH] SWDEV-486573 - Check the return type of commit memory. Change-Id: Id158cd7a0dff37b382b858cf7113aa4cf326300a --- rocclr/platform/memory.cpp | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/rocclr/platform/memory.cpp b/rocclr/platform/memory.cpp index 98dbdd0a6d..a887a2c95a 100644 --- a/rocclr/platform/memory.cpp +++ b/rocclr/platform/memory.cpp @@ -530,16 +530,22 @@ void Memory::commitSvmMemory() { ScopedLock lock(lockMemoryOps_); // if VRAM is visible for host, it is not necessary to mmap again if (!svmPtrCommited_ && !largeBarSystem_) { - amd::Os::commitMemory(svmHostAddress_, size_, amd::Os::MEM_PROT_RW); - svmPtrCommited_ = true; + if (amd::Os::commitMemory(svmHostAddress_, size_, amd::Os::MEM_PROT_RW)) { + svmPtrCommited_ = true; + } else { + LogPrintfError("Mem Map failed for the host address 0x%x", svmHostAddress_); + } } } void Memory::uncommitSvmMemory() { ScopedLock lock(lockMemoryOps_); if (svmPtrCommited_ && !(flags_ & CL_MEM_SVM_FINE_GRAIN_BUFFER)) { - amd::Os::uncommitMemory(svmHostAddress_, size_); - svmPtrCommited_ = false; + if (amd::Os::uncommitMemory(svmHostAddress_, size_)) { + svmPtrCommited_ = false; + } else { + LogPrintfError("Mem Unmap failed for the host address 0x%x", svmHostAddress_); + } } }