From 7560929bd7895cbd39a34b03b04eb616bc1c5250 Mon Sep 17 00:00:00 2001 From: Gilbert Lee Date: Fri, 11 Oct 2019 09:20:10 -0700 Subject: [PATCH] Reverting GenericOp bug workaround modifications to slice/chunk steps [ROCm/rccl commit: 37603ae6cb734e52ac94c95748f1a532d54b962b] --- projects/rccl/src/collectives/collectives.h | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/projects/rccl/src/collectives/collectives.h b/projects/rccl/src/collectives/collectives.h index 63fcfd2017..27de1f7540 100644 --- a/projects/rccl/src/collectives/collectives.h +++ b/projects/rccl/src/collectives/collectives.h @@ -57,18 +57,12 @@ DECL_ALL_COLLS // CHUNKSIZE must be a multiple of SLICESIZE -//#define ALLREDUCE_SLICESTEPS (NCCL_STEPS/4) -//#define ALLREDUCE_CHUNKSTEPS (NCCL_STEPS/2) -//#define ALLGATHER_SLICESTEPS (NCCL_STEPS/4) -//#define ALLGATHER_CHUNKSTEPS (NCCL_STEPS/2) -//#define REDUCESCATTER_SLICESTEPS (NCCL_STEPS/4) -//#define REDUCESCATTER_CHUNKSTEPS (NCCL_STEPS/2) -#define ALLREDUCE_SLICESTEPS 4 -#define ALLREDUCE_CHUNKSTEPS 4 -#define ALLGATHER_SLICESTEPS 4 -#define ALLGATHER_CHUNKSTEPS 4 -#define REDUCESCATTER_SLICESTEPS 4 -#define REDUCESCATTER_CHUNKSTEPS 4 +#define ALLREDUCE_SLICESTEPS (NCCL_STEPS/4) +#define ALLREDUCE_CHUNKSTEPS (NCCL_STEPS/2) +#define ALLGATHER_SLICESTEPS (NCCL_STEPS/4) +#define ALLGATHER_CHUNKSTEPS (NCCL_STEPS/2) +#define REDUCESCATTER_SLICESTEPS (NCCL_STEPS/4) +#define REDUCESCATTER_CHUNKSTEPS (NCCL_STEPS/2) #define BROADCAST_SLICESTEPS 1 #define BROADCAST_CHUNKSTEPS 1 #define REDUCE_SLICESTEPS 1