Add the RdcSmiDiagnostic module

Provides a RdcSmiDiagnostic module, which will call rocm_smi_lib.

It will support following diagnostics: Get GPU Topology, Check GPU
parameters and check processes running on the GPUs.

The grpc client and server side diagnostics function is added.

The diag module is added to the rdci.

Change-Id: I10a0cf3c20556a61373ab686f82cae75acaa40dd

rdc_libs/rdc/src/RdcEmbeddedHandler.cc

@@ -67,7 +67,7 @@ namespace amd {
 namespace rdc {
 
 // TODO(bill_liu): make it configurable
-const uint32_t METIC_UPDATE_FREQUENCY = 100;  // 100ms by default
+const uint32_t METIC_UPDATE_FREQUENCY = 1000;  // 1000 microseconds by default
 
 RdcEmbeddedHandler::RdcEmbeddedHandler(rdc_operation_mode_t mode):
     group_settings_(new RdcGroupSettingsImpl())
@@ -386,6 +386,9 @@ rdc_status_t RdcEmbeddedHandler::rdc_diagnostic_run(
     rdc_gpu_group_t group_id,
     rdc_diag_level_t level,
     rdc_diag_response_t* response) {
+    if (!response) {
+        return RDC_ST_BAD_PARAMETER;
+    }
 
     // Get GPU group information
     rdc_group_info_t rdc_group_info;
@@ -397,6 +400,24 @@ rdc_status_t RdcEmbeddedHandler::rdc_diagnostic_run(
     return diag->rdc_diagnostic_run(rdc_group_info, level, response);
 }
 
+rdc_status_t RdcEmbeddedHandler::rdc_test_case_run(
+    rdc_gpu_group_t group_id,
+    rdc_diag_test_cases_t test_case,
+    rdc_diag_test_result_t* result) {
+    if (!result) {
+        return RDC_ST_BAD_PARAMETER;
+    }
+    // Get GPU group information
+    rdc_group_info_t rdc_group_info;
+    rdc_status_t status = rdc_group_gpu_get_info(
+        group_id, &rdc_group_info);
+    if (status != RDC_ST_OK)  return status;
+
+    auto diag = rdc_module_mgr_->get_diagnostic_module();
+    return diag->rdc_test_case_run(test_case, rdc_group_info.entity_ids,
+                rdc_group_info.count, result);
+}
+
 // Control API
 rdc_status_t RdcEmbeddedHandler::rdc_field_update_all(
     uint32_t wait_for_update) {

rdc_libs/rdc/src/RdcMetricsUpdaterImpl.cc

@@ -39,6 +39,7 @@ RdcMetricsUpdaterImpl::RdcMetricsUpdaterImpl(
 // Make the listen time for notifications a relatively long time.
 // There's no point in starting/stopping it constantly.
 static const uint32_t kRdcFieldListenNotifTime_mS = 10000;
+static const uint32_t kRdcEventCheck_ms = 1000;
 
 void RdcMetricsUpdaterImpl::start() {
     if (started_) {
@@ -49,7 +50,7 @@ void RdcMetricsUpdaterImpl::start() {
       while (started_) {
         watch_table_->rdc_field_listen_notif(kRdcFieldListenNotifTime_mS);
         std::this_thread::sleep_for(
-                    std::chrono::microseconds(_check_frequency));
+                    std::chrono::milliseconds(kRdcEventCheck_ms));
       }
     });
     updater_ = std::async(std::launch::async, [this](){

rdc_libs/rdc/src/RdcSmiDiagnosticImpl.cc

@@ -0,0 +1,575 @@
+/*
+Copyright (c) 2021 - present Advanced Micro Devices, Inc. All rights reserved.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
+*/
+#include "rdc_lib/impl/RdcSmiDiagnosticImpl.h"
+#include <vector>
+#include <map>
+#include <string>
+#include "rdc_lib/rdc_common.h"
+#include "rdc_lib/RdcLogger.h"
+#include "rdc_lib/impl/RsmiUtils.h"
+
+namespace amd {
+namespace rdc {
+RdcSmiDiagnosticImpl::RdcSmiDiagnosticImpl() {
+}
+
+rdc_status_t RdcSmiDiagnosticImpl::check_rsmi_process_info(
+        uint32_t gpu_index[RDC_MAX_NUM_DEVICES],
+        uint32_t gpu_count,
+        rdc_diag_test_result_t* result) {
+    if (result == nullptr) {
+        return RDC_ST_BAD_PARAMETER;
+    }
+    *result = {};
+    result->test_case = RDC_DIAG_COMPUTE_PROCESS;
+    result->status = RDC_DIAG_RESULT_SKIP;
+    result->per_gpu_result_count = 0;
+    rsmi_status_t err = RSMI_STATUS_SUCCESS;
+    uint32_t num_items = 0;
+    err = rsmi_compute_process_info_get(
+        nullptr, &num_items);
+    if (err != RSMI_STATUS_SUCCESS) {
+        RDC_LOG(RDC_ERROR,
+            "Fail to get process information: " << err);
+        strncpy_with_null(result->info,
+            "Fail to retreive process information from rocm_smi_lib",
+            MAX_DIAG_MSG_LENGTH);
+        return Rsmi2RdcError(err);
+    }
+
+    // No process found
+    if (num_items == 0) {
+        result->status = RDC_DIAG_RESULT_PASS;
+        result->per_gpu_result_count = 0;
+        strncpy_with_null(result->info,
+            "Do not have any compute process running on any devices",
+            MAX_DIAG_MSG_LENGTH);
+        return RDC_ST_OK;
+    }
+
+    std::string info = std::to_string(num_items)
+                    + " compute process is using devices.";
+    // Find details of the process running on each GPU
+    std::vector<rsmi_process_info_t> procs(num_items);
+    err = rsmi_compute_process_info_get(
+        reinterpret_cast<rsmi_process_info_t*>(&procs[0]), &num_items);
+    if (err != RSMI_STATUS_SUCCESS) {
+        RDC_LOG(RDC_INFO,
+            "Fail to get process detail information: " << err);
+        strncpy_with_null(result->info, info.c_str(), MAX_DIAG_MSG_LENGTH);
+        return Rsmi2RdcError(err);
+    }
+
+    std::map<uint32_t, std::vector<uint32_t>> pids_per_gpu;
+    for (uint32_t i=0; i < num_items; i++) {
+        info += " Process: " + std::to_string(procs[i].process_id)
+         += ", pasid: "  + std::to_string(procs[i].pasid)
+         += ", vram_usage: "  + std::to_string(procs[i].vram_usage)
+         += ", sdma_usage: "  + std::to_string(procs[i].sdma_usage)
+         += ", cu_occupancy: "  + std::to_string(procs[i].cu_occupancy)
+         +=".";
+
+        // Get the num_devices the process is running
+        uint32_t num_devices = 0;
+        err = rsmi_compute_process_gpus_get(procs[i].process_id,
+            nullptr, &num_devices);
+        if (err != RSMI_STATUS_SUCCESS || num_devices == 0) {
+            RDC_LOG(RDC_INFO,
+            "Fail to get process GPUs detail information: " << err);
+            continue;
+        }
+
+        // Get the details of devices
+        std::vector<uint32_t> device_details(num_devices);
+        err = rsmi_compute_process_gpus_get(procs[i].process_id,
+            reinterpret_cast<uint32_t*>(&device_details[0]), &num_devices);
+            if (err != RSMI_STATUS_SUCCESS) {
+                RDC_LOG(RDC_INFO,
+                "Fail to get process GPUs detail information: " << err);
+                continue;
+        }
+
+        // Add process information in per GPU structure
+        for (uint32_t j=0; j < num_devices; j++) {
+            // return the value if exists
+            auto ite = pids_per_gpu.insert(std::pair<uint32_t,
+                    std::vector<uint32_t>>(device_details[j],
+                    std::vector<uint32_t>()));
+            ite.first->second.push_back(procs[i].process_id);
+        }
+    }  // end for (uint32_t i=0 ...)
+
+    if (pids_per_gpu.size() == 0) {
+        result->status = RDC_DIAG_RESULT_WARN;
+        info += " Cannot detect the processes running in which devices.";
+    } else {
+        result->status = RDC_DIAG_RESULT_PASS;  // pass by default
+    }
+
+    // Mark as fail
+    for (uint32_t i=0; i < gpu_count; i++) {
+        if (pids_per_gpu.find(gpu_index[i]) != pids_per_gpu.end()) {
+            result->status = RDC_DIAG_RESULT_FAIL;
+            break;
+        }
+    }
+
+    // Set per GPU information
+    strncpy_with_null(result->info, info.c_str(), MAX_DIAG_MSG_LENGTH);
+    for (auto ite=pids_per_gpu.begin(); ite != pids_per_gpu.end(); ++ite) {
+        auto& per_gpu = result->gpu_results[result->per_gpu_result_count];
+        per_gpu.gpu_index = ite->first;
+        per_gpu.gpu_result.code = 0;
+        std::string per_gpu_msg = "Running process:";
+        for (uint32_t k=0; k < ite->second.size(); k++) {
+            per_gpu_msg += " " + std::to_string(ite->second[k]);
+        }
+
+        strncpy_with_null(per_gpu.gpu_result.msg,
+                    per_gpu_msg.c_str(), MAX_DIAG_MSG_LENGTH);
+
+        result->per_gpu_result_count++;
+        if (result->per_gpu_result_count >= RDC_MAX_NUM_DEVICES) {
+            RDC_LOG(RDC_ERROR, "Found more GPUs than " << RDC_MAX_NUM_DEVICES);
+            break;
+        }
+    }
+
+    return RDC_ST_OK;
+}
+
+std::string RdcSmiDiagnosticImpl::get_temperature_string(
+            rsmi_temperature_type_t type) const {
+    switch (type) {
+        case RSMI_TEMP_TYPE_EDGE:
+            return "Edge";
+        case RSMI_TEMP_TYPE_JUNCTION:
+            return "Junction";
+        case RSMI_TEMP_TYPE_MEMORY:
+            return "Memory";
+        default:
+            return "Unknown";
+    }
+}
+
+std::string RdcSmiDiagnosticImpl::get_voltage_string(
+        rsmi_voltage_type_t type) const {
+    switch (type) {
+        case RSMI_VOLT_TYPE_VDDGFX:
+            return "Vddgfx voltage";
+        default:
+            return "Unknown";
+    }
+}
+
+// Show topology type
+rdc_status_t RdcSmiDiagnosticImpl::check_rsmi_topo_info(
+        uint32_t gpu_index[RDC_MAX_NUM_DEVICES],
+        uint32_t gpu_count,
+        rdc_diag_test_result_t* result) {
+    if (result == nullptr) {
+        return RDC_ST_BAD_PARAMETER;
+    }
+    *result = {};
+    result->test_case = RDC_DIAG_NODE_TOPOLOGY;
+
+    const std::map<RSMI_IO_LINK_TYPE, std::string> link_to_string = {
+        {RSMI_IOLINK_TYPE_UNDEFINED, "Undefined"},
+        {RSMI_IOLINK_TYPE_PCIEXPRESS, "PCI Express"},
+        {RSMI_IOLINK_TYPE_XGMI, "XGMI"},
+        {RSMI_IOLINK_TYPE_NUMIOLINKTYPES, "IO Link"}
+    };
+
+    result->status = RDC_DIAG_RESULT_SKIP;
+    result->per_gpu_result_count = 0;
+    rsmi_status_t err = RSMI_STATUS_SUCCESS;
+    std::string info = "";
+
+    for (uint32_t i=0; i < gpu_count; i++) {
+        for (uint32_t j=0; j < gpu_count; j++) {
+            if (gpu_index[i] == gpu_index[j]) continue;
+
+            uint64_t weight;
+            err = rsmi_topo_get_link_weight(
+                gpu_index[i], gpu_index[j], &weight);
+            if (err != RSMI_STATUS_SUCCESS) {
+                result->status = RDC_DIAG_RESULT_FAIL;
+                result->details.code = err;
+                std::string err_info = "rsmi_topo_get_link_weight(";
+                err_info += std::to_string(gpu_index[i]) + ",";
+                err_info += std::to_string(gpu_index[j]) + ", &weight)";
+                err_info += " fail";
+                strncpy_with_null(result->details.msg, err_info.c_str(),
+                                MAX_DIAG_MSG_LENGTH);
+                strncpy_with_null(result->info, err_info.c_str(),
+                                MAX_DIAG_MSG_LENGTH);
+                return RDC_ST_MSI_ERROR;
+            }
+
+            info += std::to_string(gpu_index[i]) + "=>";
+            info += std::to_string(gpu_index[j]) + " weight:";
+            info += std::to_string(weight) + " ";
+        }
+    }
+    if (info != "") {
+        strncpy_with_null(result->info, info.c_str(),
+            MAX_DIAG_MSG_LENGTH);
+    } else {
+        strncpy_with_null(result->info, "No link detected.",
+            MAX_DIAG_MSG_LENGTH);
+    }
+
+    result->status = RDC_DIAG_RESULT_PASS;
+    return RDC_ST_OK;
+}
+
+rdc_status_t RdcSmiDiagnosticImpl::check_rsmi_param_info(
+        uint32_t gpu_index[RDC_MAX_NUM_DEVICES],
+        uint32_t gpu_count,
+        rdc_diag_test_result_t* result) {
+    if (result == nullptr) {
+        return RDC_ST_BAD_PARAMETER;
+    }
+    *result = {};
+    result->test_case = RDC_DIAG_GPU_PARAMETERS;
+
+    result->status = RDC_DIAG_RESULT_PASS;
+    std::string info = "";
+
+    for (uint32_t i=0; i < gpu_count; i++) {
+        // temperature
+        for (rsmi_temperature_type_t sensor_type = RSMI_TEMP_TYPE_FIRST;
+            sensor_type != RSMI_TEMP_TYPE_LAST; ) {
+            auto status = check_temperature_level(
+                gpu_index[i], sensor_type, result->info,
+                result->gpu_results[i].gpu_result.msg);
+            // Set to higher error level
+            if (status > result->status) {
+                result->status = status;
+            }
+            sensor_type = static_cast<rsmi_temperature_type_t>(sensor_type+1);
+        }
+
+        // Voltage
+        for (rsmi_voltage_type_t sensor_type = RSMI_VOLT_TYPE_FIRST;
+            sensor_type != RSMI_VOLT_TYPE_LAST;) {
+            auto status = check_voltage_level(
+                gpu_index[i], sensor_type, result->info,
+                result->gpu_results[i].gpu_result.msg);
+            // Set to higher error level
+            if (status > result->status) {
+                result->status = status;
+            }
+            sensor_type = static_cast<rsmi_voltage_type_t>(sensor_type+1);
+        }
+        result->gpu_results->gpu_index = gpu_index[i];
+        result->per_gpu_result_count++;
+    }
+    return RDC_ST_OK;
+}
+
+rdc_diag_result_t RdcSmiDiagnosticImpl::check_temperature_level(
+        uint32_t gpu_index, rsmi_temperature_type_t type
+        , char msg[MAX_DIAG_MSG_LENGTH]
+        , char per_gpu_msg[MAX_DIAG_MSG_LENGTH]) {
+    rdc_diag_result_t result = RDC_DIAG_RESULT_PASS;
+    rsmi_temperature_metric_t met = RSMI_TEMP_CURRENT;
+    rsmi_status_t err = RSMI_STATUS_SUCCESS;
+    int64_t current_temp = 0;
+    std::string info = msg;
+    std::string per_gpu_info = per_gpu_msg;
+
+    err = rsmi_dev_temp_metric_get(gpu_index,
+                                    type, met, &current_temp);
+
+    if (err != RSMI_STATUS_SUCCESS) return result;
+
+    // Max temperature
+    met = RSMI_TEMP_MAX;
+    int64_t max_temp = 0;
+    err = rsmi_dev_temp_metric_get(gpu_index,
+                                    type, met, &max_temp);
+    if (err == RSMI_STATUS_SUCCESS) {
+        if (current_temp >= max_temp) {
+            result = RDC_DIAG_RESULT_WARN;
+            per_gpu_info += "Max ";
+            per_gpu_info += get_temperature_string(type);
+            per_gpu_info += " temperature ";
+            per_gpu_info += std::to_string(max_temp);
+            per_gpu_info += " greater than current temperature ";
+            per_gpu_info += std::to_string(current_temp) +". ";
+            info += get_temperature_string(type) + ": ";
+            info += "GPU " + std::to_string(gpu_index);
+            info += " max ";
+            info += get_temperature_string(type);
+            info += " temperature exceeds. ";
+        } else {
+            info += "GPU " + std::to_string(gpu_index);
+            info += " max ";
+            info += get_temperature_string(type);
+            info += " temperature in range. ";
+        }
+    }
+
+    met = RSMI_TEMP_MIN;
+    int64_t min_temp = 0;
+    err = rsmi_dev_temp_metric_get(gpu_index,
+                                    type, met, &min_temp);
+    if (err == RSMI_STATUS_SUCCESS) {
+        if (current_temp <= min_temp) {
+            result = RDC_DIAG_RESULT_WARN;
+            per_gpu_info += "Min ";
+            per_gpu_info += get_temperature_string(type);
+            per_gpu_info += " temperature ";
+            per_gpu_info += std::to_string(min_temp);
+            per_gpu_info += " less than current temperature ";
+            per_gpu_info += std::to_string(current_temp) +". ";
+            info += "GPU " + std::to_string(gpu_index);
+            info += " min ";
+            info += get_temperature_string(type);
+            info += " temperature exceeds. ";
+        }  else {
+            info += "GPU " + std::to_string(gpu_index);
+            info += " min ";
+            info += get_temperature_string(type);
+            info += " temperature in range. ";
+        }
+    }
+
+    met = RSMI_TEMP_CRITICAL;
+    int64_t critical_temp = 0;
+    err = rsmi_dev_temp_metric_get(gpu_index,
+                                    type, met, &critical_temp);
+    if (err != RSMI_STATUS_SUCCESS)  {
+        if (current_temp >= critical_temp) {
+            result = RDC_DIAG_RESULT_FAIL;
+            per_gpu_info += "Critical ";
+            per_gpu_info += get_temperature_string(type);
+            per_gpu_info += " temperature ";
+            per_gpu_info += std::to_string(critical_temp);
+            per_gpu_info += " greater than current temperature ";
+            per_gpu_info += std::to_string(current_temp) +". ";
+            info += "GPU " + std::to_string(gpu_index);
+            info += " Critical ";
+            info += get_temperature_string(type);
+            info += " temperature exceeds. ";
+        } else {
+            info += "GPU " + std::to_string(gpu_index);
+            info += " Critical ";
+            info += get_temperature_string(type);
+            info += " temperature in range. ";
+        }
+    }
+
+    met = RSMI_TEMP_EMERGENCY;
+    int64_t emergency_temp = 0;
+    err = rsmi_dev_temp_metric_get(gpu_index,
+                                    type, met, &emergency_temp);
+    if (err != RSMI_STATUS_SUCCESS)  {
+        if (current_temp >= critical_temp) {
+            result = RDC_DIAG_RESULT_FAIL;
+            per_gpu_info += "Emergency ";
+            per_gpu_info += get_temperature_string(type);
+            per_gpu_info += " temperature ";
+            per_gpu_info += std::to_string(emergency_temp);
+            per_gpu_info += " greater than current temperature ";
+            per_gpu_info += std::to_string(current_temp) +". ";
+            info += "GPU " + std::to_string(gpu_index);
+            info += " Emergency ";
+            info += get_temperature_string(type);
+            info += " temperature exceeds. ";
+        } else {
+            info += "GPU " + std::to_string(gpu_index);
+            info += " Emergency ";
+            info += get_temperature_string(type);
+            info += " temperature in range. ";
+        }
+    }
+
+    met = RSMI_TEMP_CRIT_MIN;
+    int64_t critical_min_temp = 0;
+    err = rsmi_dev_temp_metric_get(gpu_index,
+                                    type, met, &critical_min_temp);
+    if (err != RSMI_STATUS_SUCCESS)  {
+        if (current_temp <= critical_min_temp) {
+            result = RDC_DIAG_RESULT_FAIL;
+            per_gpu_info += "Critical Min ";
+            per_gpu_info += get_temperature_string(type);
+            per_gpu_info += " temperature ";
+            per_gpu_info += std::to_string(critical_min_temp);
+            per_gpu_info += " less than current temperature ";
+            per_gpu_info += std::to_string(current_temp) +". ";
+            info += "GPU " + std::to_string(gpu_index);
+            info += " Critical Min ";
+            info += get_temperature_string(type);
+            info += " temperature exceeds. ";
+        } else {
+            info += "GPU " + std::to_string(gpu_index);
+            info += " Critical Min ";
+            info += get_temperature_string(type);
+            info += " temperature in range. ";
+        }
+    }
+
+    strncpy_with_null(msg, info.c_str(),
+            MAX_DIAG_MSG_LENGTH);
+    strncpy_with_null(per_gpu_msg, per_gpu_info.c_str(),
+            MAX_DIAG_MSG_LENGTH);
+
+    return result;
+}
+
+
+rdc_diag_result_t RdcSmiDiagnosticImpl::check_voltage_level(
+        uint32_t gpu_index, rsmi_voltage_type_t type
+        , char msg[MAX_DIAG_MSG_LENGTH]
+        , char per_gpu_msg[MAX_DIAG_MSG_LENGTH]) {
+    rdc_diag_result_t result = RDC_DIAG_RESULT_PASS;
+    rsmi_voltage_metric_t met = RSMI_VOLT_CURRENT;
+    rsmi_status_t err = RSMI_STATUS_SUCCESS;
+    int64_t current_voltage = 0;
+    std::string info = msg;
+    std::string per_gpu_info = per_gpu_msg;
+
+    err = rsmi_dev_volt_metric_get(gpu_index,
+                                    type, met, &current_voltage);
+    if (err != RSMI_STATUS_SUCCESS) return result;
+
+    // Max voltage
+    met = RSMI_VOLT_MAX;
+    int64_t max_volt = 0;
+    err = rsmi_dev_volt_metric_get(gpu_index,
+                                    type, met, &max_volt);
+    if (err == RSMI_STATUS_SUCCESS) {
+        if (current_voltage >= max_volt) {
+            result = RDC_DIAG_RESULT_WARN;
+            per_gpu_info += "Max ";
+            per_gpu_info += get_voltage_string(type);
+            per_gpu_info += " voltage ";
+            per_gpu_info += std::to_string(max_volt);
+            per_gpu_info += " greater than current voltage ";
+            per_gpu_info += std::to_string(current_voltage) +". ";
+            info += get_voltage_string(type) + ": ";
+            info += "GPU " + std::to_string(gpu_index);
+            info += " max ";
+            info += get_voltage_string(type);
+            info += " voltage exceeds. ";
+        } else {
+            info += "GPU " + std::to_string(gpu_index);
+            info += " max ";
+            info += get_voltage_string(type);
+            info += " voltage in range. ";
+        }
+    }
+
+    // Min voltage
+    met = RSMI_VOLT_MIN;
+    int64_t min_volt = 0;
+    err = rsmi_dev_volt_metric_get(gpu_index,
+                                    type, met, &min_volt);
+    if (err == RSMI_STATUS_SUCCESS) {
+        if (current_voltage <= min_volt) {
+            result = RDC_DIAG_RESULT_WARN;
+            per_gpu_info += "Min ";
+            per_gpu_info += get_voltage_string(type);
+            per_gpu_info += " voltage ";
+            per_gpu_info += std::to_string(min_volt);
+            per_gpu_info += " less than current voltage ";
+            per_gpu_info += std::to_string(current_voltage) +". ";
+            info += get_voltage_string(type) + ": ";
+            info += "GPU " + std::to_string(gpu_index);
+            info += " min ";
+            info += get_voltage_string(type);
+            info += " voltage exceeds. ";
+        } else {
+            info += "GPU " + std::to_string(gpu_index);
+            info += " min ";
+            info += get_voltage_string(type);
+            info += " voltage in range. ";
+        }
+    }
+
+    // Max Critical voltage
+    met = RSMI_VOLT_MAX_CRIT;
+    int64_t critical_max_volt = 0;
+    err = rsmi_dev_volt_metric_get(gpu_index,
+                                    type, met, &critical_max_volt);
+    if (err == RSMI_STATUS_SUCCESS) {
+        if (current_voltage >= critical_max_volt) {
+            result = RDC_DIAG_RESULT_FAIL;
+            per_gpu_info += "Critical Max ";
+            per_gpu_info += get_voltage_string(type);
+            per_gpu_info += " voltage ";
+            per_gpu_info += std::to_string(critical_max_volt);
+            per_gpu_info += " greater than current voltage ";
+            per_gpu_info += std::to_string(current_voltage) +". ";
+            info += get_voltage_string(type) + ": ";
+            info += "GPU " + std::to_string(gpu_index);
+            info += " Critical  max ";
+            info += get_voltage_string(type);
+            info += " voltage exceeds. ";
+        } else {
+            info += "GPU " + std::to_string(gpu_index);
+            info += " Critical  max ";
+            info += get_voltage_string(type);
+            info += " voltage in range. ";
+        }
+    }
+
+    // Min Critical voltage
+    met = RSMI_VOLT_MIN_CRIT;
+    int64_t critical_min_volt = 0;
+    err = rsmi_dev_volt_metric_get(gpu_index,
+                                    type, met, &critical_min_volt);
+    if (err == RSMI_STATUS_SUCCESS) {
+        if (current_voltage <= critical_min_volt) {
+            result = RDC_DIAG_RESULT_FAIL;
+            per_gpu_info += "Critical Min ";
+            per_gpu_info += get_voltage_string(type);
+            per_gpu_info += " voltage ";
+            per_gpu_info += std::to_string(critical_min_volt);
+            per_gpu_info += " less than current voltage ";
+            per_gpu_info += std::to_string(current_voltage) +". ";
+            info += get_voltage_string(type) + ": ";
+            info += "GPU " + std::to_string(gpu_index);
+            info += " Critical min ";
+            info += get_voltage_string(type);
+            info += " voltage exceeds. ";
+        } else {
+            info += "GPU " + std::to_string(gpu_index);
+            info += " Critical min ";
+            info += get_voltage_string(type);
+            info += " voltage in range. ";
+        }
+    }
+
+    strncpy_with_null(msg, info.c_str(),
+            MAX_DIAG_MSG_LENGTH);
+    strncpy_with_null(per_gpu_msg, per_gpu_info.c_str(),
+            MAX_DIAG_MSG_LENGTH);
+
+    return result;
+}
+
+}  // namespace rdc
+}  // namespace amd
+

rdc_libs/rdc/src/RdcSmiLib.cc

@@ -31,8 +31,9 @@ THE SOFTWARE.
 namespace amd {
 namespace rdc {
 
-RdcSmiLib::RdcSmiLib(const RdcMetricFetcherPtr& mf): metric_fetcher_(mf),
-            bulk_fetch_enabled_(false) {  // Disable bulk fetch by default.
+RdcSmiLib::RdcSmiLib(const RdcMetricFetcherPtr& mf): metric_fetcher_(mf)
+        , bulk_fetch_enabled_(false)
+        , smi_diag_(std::make_shared<RdcSmiDiagnosticImpl>()) {
     char* bulk_env = getenv("RDC_BULK_FETCH_ENABLED");
     if (bulk_env != nullptr && strcasecmp(bulk_env, "true") == 0) {
         RDC_LOG(RDC_DEBUG, "Bulk fetch enabled.");
@@ -182,7 +183,14 @@ rdc_status_t RdcSmiLib::rdc_diag_test_cases_query(
         return RDC_ST_BAD_PARAMETER;
     }
 
-    return RDC_ST_NOT_SUPPORTED;
+    const std::vector<rdc_diag_test_cases_t> tests {
+        RDC_DIAG_COMPUTE_PROCESS,
+        RDC_DIAG_NODE_TOPOLOGY,
+        RDC_DIAG_GPU_PARAMETERS
+    };
+    std::copy(tests.begin(), tests.end(), test_cases);
+    *test_case_count = tests.size();
+    return RDC_ST_OK;
 }
 
 // Run a specific test case
@@ -194,7 +202,19 @@ rdc_status_t RdcSmiLib::rdc_test_case_run(
     if (result == nullptr) {
         return RDC_ST_BAD_PARAMETER;
     }
-    return RDC_ST_NOT_SUPPORTED;
+    switch (test_case) {
+        case RDC_DIAG_COMPUTE_PROCESS:
+            return smi_diag_->check_rsmi_process_info(
+                    gpu_index, gpu_count, result);
+        case RDC_DIAG_NODE_TOPOLOGY:
+            return smi_diag_->check_rsmi_topo_info(
+                gpu_index, gpu_count, result);
+        case RDC_DIAG_GPU_PARAMETERS:
+            return smi_diag_->check_rsmi_param_info(
+                gpu_index, gpu_count, result);
+        default:
+            return RDC_ST_NOT_SUPPORTED;
+    }
 }
 
 rdc_status_t RdcSmiLib::rdc_diagnostic_run(