Add pthread_detach()'s for threads we never pthread_join(). Helps

reduce diagnostic noise for ThreadSanitizer.

Fixes https://github.com/NVIDIA/nccl/issues/649


[ROCm/rccl commit: 44eb40da0e]
This commit is contained in:
John Bachan
2022-03-14 17:09:08 -07:00
parent f8886d8687
commit 7707479804
3 changed files with 3 additions and 0 deletions
+1
View File
@@ -165,6 +165,7 @@ ncclResult_t bootstrapCreateRoot(ncclUniqueId* id, bool idFromEnv) {
memcpy(id, &listenSock->addr, sizeof(union ncclSocketAddress));
pthread_t thread;
pthread_create(&thread, NULL, bootstrapRoot, (void*)listenSock);
pthread_detach(thread); // will not be pthread_join()'d
ncclSetThreadName(thread, "NCCL BootstrapR");
return ncclSuccess;
}