AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "msccl: build same number of kernels as in ROCm 5.7" (#1058)

Browse Source 
This reverts commit f960174d03be7e5174baa83b256526d388a38842.
This commit is contained in:
Wenkai Du
2024-01-24 08:43:50 -08:00
committed by GitHub
parent 18a57bac10
commit 7987015a19
5 changed files with 9 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmake/Generator.cmake
+3 -6
View File
@@ -297,11 +297,9 @@ endfunction()
## Function to generate MSCCL Kernels
###########################################################################################################
function(gen_msccl_kernels)
foreach(REDOP_CURRENT IN LISTS ALL_REDOPS)
set(MSCCL_REDOP Sum Prod Max Min)
foreach(REDOP_CURRENT IN LISTS MSCCL_REDOP)
foreach(DATA_TYPE ${ALL_TYPES})
if (REDOP_CURRENT STREQUAL "SumPostDiv" AND DATA_TYPE IN_LIST FLOATS_LIST)
continue() # Skip the iteration for FLOATS_LIST when REDOP_CURRENT is SumPostDiv
endif()
set(FILE_NAME "${HIPIFY_DIR}/src/collectives/device/msccl_kernel_${REDOP_CURRENT}_${DATA_TYPE}.cpp")
message(STATUS "Generating ${FILE_NAME}")
file(WRITE ${FILE_NAME}
@@ -309,8 +307,7 @@ function(gen_msccl_kernels)
#include \"primitives.h\"
#include \"collectives.h\"
#include \"devcomm.h\"
MSCCL_IMPL_KERNEL_ENTRY_FUNC_DEVREDOP_TYPE(${REDOP_CURRENT}, ${DATA_TYPE}, false);
MSCCL_IMPL_KERNEL_ENTRY_FUNC_DEVREDOP_TYPE(${REDOP_CURRENT}, ${DATA_TYPE}, true);")
MSCCL_IMPL_KERNEL_ENTRY_FUNC_DEVREDOP_TYPE(${REDOP_CURRENT}, ${DATA_TYPE}, false);")
list(APPEND HIP_SOURCES ${FILE_NAME})
endforeach()
endforeach()