[rocprofv3] SQLite3 database output (rocpd) support + rocprofiler-sdk-rocpd (#403)

* [rocprofv3] rocpd SQLite3 database output support

* Move counters xml and yaml to source/share/rocprofiler-sdk

- more representative of install hierarchy

* Add share/rocprofiler-sdk/rocpd SQL files

* Experimental rocprofiler-sdk SQL API

* rocprofv3 default output format is rocpd

* Fix rocpd event ids for counter collection w/o kernel dispatch

* Remove fktable entries from rocpd_tables.sql

* Fix rocpd schema path

* Fix install component for roctx python bindings

* rocprofiler-sdk-rocpd

- create include/rocprofiler-sdk-rocpd
- create rocprofiler-sdk-rocpd library, package, etc.
- default all "guid" fields to "{{guid}}" in tables
- remove "{{view_uuid}}" support (always unused)

* Migrate rocprofv3 to use rocprofiler-sdk-rocpd

* Fix missing foreign key reference

* Revert change

* Fix cmake comment

* Fix maybe-uninitialized compiler warning

* Fix maybe-uninitialized compiler warning

* Add logging to rocpd_sql_load_schema

* Improve string sanitization when inserting json strings

* Initialize rocpd logging on rocprofiler-sdk-rocpd library load

* Revert lib/output/generatePerfetto.cpp changes

* [temporary] Tweak rocprofv3-test-list-avail-trace-execute test log level

* Update get_install_path for lib/rocprofiler-sdk-rocpd/sql.cpp

- try to resolve issues on RHEL/SLES for dladdr

* Update lib/common/logging.cpp

- enable environ overrides

* dlsym for rocpd_sql_load_schema

* Make dl_info.dli_fname lexically normal

* Implement node_info alternatives if /etc/machine-id does not exist

* Misc include fixes

* SHA256 and UUIDv7 support

* Implement UUIDv7 in generateRocpd.cpp

* Support push/pop environment variables

* Minor tweak

* Fix glog segfaults when unsetting glog env

* Updated CHANGELOG

* Updates tests/pytest-packages

- rocpd_reader.py: RocpdReader

* Update tests / marker_views.sql

- add test_rocpd_data

* Update rocpd_tables.sql

- Use AUTOINCREMENT
- insert "uuid" and "guid" into rocpd_metadata

* Minor updates to generateRocpd.cpp

- don't quote GUID
- use sqlite3_open_v2
- use sqlite3_close_v2

* Update execute_raw_sql_statements_impl

- uses sqlite3_last_insert_rowid for autoincrement

* Update SQL deferred_transaction

- CI check for nullptr to connection

* Apply suggestions from code review

Co-authored-by: Welton, Benjamin <Benjamin.Welton@amd.com>

* Code review updates

- formatting
- replace if with switch
- remove loop for {{uuid}}

* Fix pmc_groups handling in rocprofv3

* Address code review feedback

- Include rocm_version in rocprofv3 version info
- Note `--version` option for `rocprofv3` in CHANGELOG.md
- remove commented out code

* Fix packaging dependencies

* Fix install package step of CI workflow

* Fix install package step of CI workflow

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
Co-authored-by: Welton, Benjamin <Benjamin.Welton@amd.com>
This commit is contained in:
Madsen, Jonathan
2025-05-30 00:13:19 -05:00
committed by GitHub
parent dbb2e52216
commit 7afedc63be
81 changed files with 7725 additions and 993 deletions
+2 -1
View File
@@ -28,7 +28,8 @@ if(NOT EXISTS ${CMAKE_CURRENT_BINARY_DIR}/trace_processor_shell.linux_clang_rele
WORLD_EXECUTE)
endif()
set(PYTEST_UTILS_PYTHON_SOURCES __init__.py dotdict.py perfetto_reader.py otf2_reader.py)
set(PYTEST_UTILS_PYTHON_SOURCES __init__.py dotdict.py perfetto_reader.py otf2_reader.py
rocpd_reader.py)
set(TESTS_PYTHON_SOURCES __init__.py rocprofv3.py)
foreach(_FILE ${PYTEST_UTILS_PYTHON_SOURCES})
@@ -0,0 +1,37 @@
# MIT License
#
# Copyright (c) 2023-2025 Advanced Micro Devices, Inc. All rights reserved.
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to deal
# in the Software without restriction, including without limitation the rights
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
# copies of the Software, and to permit persons to whom the Software is
# furnished to do so, subject to the following conditions:
#
# The above copyright notice and this permission notice shall be included in all
# copies or substantial portions of the Software.
#
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
# SOFTWARE.
from __future__ import absolute_import
import sqlite3
class RocpdReader:
"""Read in rocpd database output"""
def __init__(self, filename):
self.filename = filename if isinstance(filename, (list, tuple)) else [filename]
def read(self, **kwargs):
"""Read rocpd (sqlite3) database"""
return [sqlite3.connect(itr) for itr in self.filename]
+77
View File
@@ -146,3 +146,80 @@ def test_otf2_data(
assert len(_otf2_data) == len(
_json_data
), f"{otf2_category} ({len(_otf2_data)}):\n\t{_otf2_data}\n{json_category} ({len(_json_data)}):\n\t{_json_data}"
def test_rocpd_data(
rocpd_data,
json_data,
categories=(
"hip",
"hsa",
"marker",
"kernel",
"memory_copy",
"memory_allocation",
"rocdecode_api",
"rocjpeg_api",
),
):
mapping = {
"hip": (
"hip_api",
(
"HIP_COMPILER_API",
"HIP_COMPILER_API_EXT",
"HIP_RUNTIME_API",
"HIP_RUNTIME_API_EXT",
),
),
"hsa": (
"hsa_api",
(
"HSA_CORE_API",
"HSA_AMD_EXT_API",
"HSA_IMAGE_EXT_API",
"HSA_FINALIZE_EXT_API",
),
),
"marker": (
"marker_api",
("MARKER_CORE_API", "MARKER_CONTROL_API", "MARKER_NAME_API"),
),
"kernel": ("kernel_dispatch", ("KERNEL_DISPATCH")),
"memory_copy": ("memory_copy", ("MEMORY_COPY")),
"memory_allocation": ("memory_allocation", ("MEMORY_ALLOCATION")),
"rocdecode_api": ("rocdecode_api", ("ROCDECODE_API")),
"rocjpeg_api": ("rocjpeg_api", ("ROCJPEG_API")),
}
view_mapping = {
"hip_api": "regions",
"hsa_api": "regions",
"marker_api": "markers",
"rccl_api": "regions",
"rocdecode_api": "regions",
"rocjpeg_api": "regions",
"kernel_dispatch": "kernels",
"memory_copy": "memory_copies",
"memory_allocation": "memory_allocations",
}
# make sure they specified valid categories
for itr in categories:
assert itr in mapping.keys()
for js_category, rpd_category in [
itr for key, itr in mapping.items() if key in categories
]:
_js_data = json_data["rocprofiler-sdk-tool"]["buffer_records"][js_category]
_rpd_cats = (
rpd_category if isinstance(rpd_category, (list, tuple)) else [rpd_category]
)
_rpd_cond = " OR ".join([f"category = '{itr}'" for itr in _rpd_cats])
_rpd_query = f"SELECT * FROM {view_mapping[js_category]} WHERE {_rpd_cond}"
_rpd_data = rocpd_data.execute(_rpd_query).fetchall()
assert len(_rpd_data) == len(
_js_data
), f"query: {_rpd_query}\n{rpd_category} ({len(_rpd_data)}):\n\t{_rpd_data}\n{js_category} ({len(_js_data)}):\n\t{_js_data}"