AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Undefined behavior from signed bit shifts (#871)

Browse Source 
* libhsakmt: fix UB due to signed integer literal in 1 << 31

Bit shift operations on signed numbers should not shift into or beyond
the signed bit as this results in Undefined Behaviour.

Signed-off-by: Sunday Clement <Sunday.Clement@amd.com>

* libhsakmt: Fix UB due to signed integer literal in 1 << x

Bit Shifting an unsigned integer is undefined behavior.

BUG: SWDEV-532853

Signed-off-by: Sunday Clement <Sunday.Clement@amd.com>

* rocr: Fix UB in various places due signed integer in bit shift

Bit shifting signed integers into or beyond the sign bit is undefined.

Signed-off-by: Sunday Clement <Sunday.Clement@amd.com>

* rocr: Change signed integer literals to unsigned

Changing the signed integers in the macro expressions throughout the file
to avoid overflow.

Signed-off-by: Sunday Clement <Sunday.Clement@amd.com>

---------

Signed-off-by: Sunday Clement <Sunday.Clement@amd.com>
Co-authored-by: Flora Cui <flora.cui@amd.com>
This commit is contained in:
Sunday Clement
2025-09-18 09:09:30 -04:00
committed by GitHub
parent 5c1eebab84
commit 7c8e575f5d
5 changed files with 87 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/rocr-runtime/runtime/hsa-runtime/image/addrlib/src/core/addrelemlib.cpp
+4 -4
View File
@@ -116,7 +116,7 @@ ElemLib* ElemLib::Create(
*/
VOID ElemLib::Flt32sToInt32s(
ADDR_FLT_32 value, ///< [in] ADDR_FLT_32 value
UINT_32 bits, ///< [in] nubmer of bits in value
UINT_32 bits, ///< [in] number of bits in value
NumberType numberType, ///< [in] the type of number
UINT_32* pResult) ///< [out] Int32 value
{
@@ -134,7 +134,7 @@ VOID ElemLib::Flt32sToInt32s(
return; // these are zero-bit components, so don't set result
case ADDR_UINT_BITS: // unsigned integer bit field, clamped to range
uscale = (1<<bits) - 1;
uscale = (1U<<bits) - 1;
if (bits == 32) // special case unsigned 32-bit int
{
*pResult = value.i;
@@ -169,7 +169,7 @@ VOID ElemLib::Flt32sToInt32s(
{
if (value.f >= 1)
{
*pResult = (1<<bits) - 1;
*pResult = (1U<<bits) - 1;
}
else
{
@@ -216,7 +216,7 @@ VOID ElemLib::Flt32sToInt32s(
final = mask;
}
scaled.f = value.f * ((1<<bits) - 1);
scaled.f = value.f * ((1U<<bits) - 1);
shifted.f = (scaled.f * 256);
truncated = ((shifted.i&0x7FFFFF) + (INT_64)0x800000) << 8;
altShift = 126 + 24 + 8 - ((shifted.i>>23)&0xFF);