From 48c3ba36ec02c694529b3af00588c76e75e2f509 Mon Sep 17 00:00:00 2001
From: "Vaddireddy, Sushma" <Sushma.Vaddireddy@amd.com>
Date: Wed, 6 Aug 2025 14:27:24 -0700
Subject: [PATCH] Fix TCC_EA0_RDREQ_DRAM event ID and enable TCC_BUBBLE counter
 (#567)

* Event ID fix for TCC_EA0_RDREQ_DRAM

* Adding TCC_BUBBLE

* Adding TCC_BUBBLE Counter

---------

Co-authored-by: Sushma Vaddireddy <svaddire@amd.com>
---
 .../counters/tests/metrics_test.h                | 16 +++++++++++++---
 source/share/rocprofiler-sdk/counter_defs.yaml   |  6 +++++-
 2 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/source/lib/rocprofiler-sdk/counters/tests/metrics_test.h b/source/lib/rocprofiler-sdk/counters/tests/metrics_test.h
index 58626b60c5..ee533a6f2b 100644
--- a/source/lib/rocprofiler-sdk/counters/tests/metrics_test.h
+++ b/source/lib/rocprofiler-sdk/counters/tests/metrics_test.h
@@ -549,7 +549,7 @@ static const std::unordered_map<std::string, std::vector<std::vector<std::string
        "Total read requests with UC mtype from this TCP to all TCCs"},
       {"TCC_EA0_RDREQ_DRAM",
        "TCC",
-       "43",
+       "102",
        "<None>",
        "Number of TCC/EA read requests (either 32-byte or 64-byte) destined for DRAM (MC)."},
       {"TCC_EA0_WRREQ_IO_CREDIT_STALL",
@@ -1464,7 +1464,12 @@ static const std::unordered_map<std::string, std::vector<std::vector<std::string
        "TCC",
        "319",
        "<None>",
-       "Number of cycles client191 sent a request to this TCC."}}}};
+       "Number of cycles client191 sent a request to this TCC."},
+      {"TCC_BUBBLE",
+       "TCC",
+       "56",
+       "<None>",
+       "Number of 128-byte read requests sent to EA."}}}};
 
 static const std::unordered_map<std::string, std::vector<std::vector<std::string>>> derived_gfx908 =
     {{"gfx908",
@@ -2240,4 +2245,9 @@ static const std::unordered_map<std::string, std::vector<std::vector<std::string
         "",
         "reduce(TCC_NORMAL_WRITEBACK,sum)",
         "Number of writebacks due to requests that are not writeback requests. Sum over TCC "
-        "instances."}}}};
+        "instances."},
+       {"TCC_BUBBLE_sum",
+        "",
+        "",
+        "reduce(TCC_BUBBLE,sum)",
+        "Number of 128-byte read requests sent to EA. Sum over all TCC instances."}}}};
diff --git a/source/share/rocprofiler-sdk/counter_defs.yaml b/source/share/rocprofiler-sdk/counter_defs.yaml
index 4072c46437..fd19d8bcaf 100644
--- a/source/share/rocprofiler-sdk/counter_defs.yaml
+++ b/source/share/rocprofiler-sdk/counter_defs.yaml
@@ -6508,7 +6508,7 @@ rocprofiler-sdk:
     - architectures:
       - gfx908
       block: TCC
-      event: 43
+      event: 102
     - architectures:
       - gfx940
       - gfx941
@@ -7896,6 +7896,8 @@ rocprofiler-sdk:
     properties: []
     definitions:
     - architectures:
+      - gfx90a
+      - gfx908
       - gfx940
       - gfx941
       - gfx942
@@ -7910,6 +7912,8 @@ rocprofiler-sdk:
     properties: []
     definitions:
     - architectures:
+      - gfx90a
+      - gfx908
       - gfx940
       - gfx941
       - gfx942