From 7e622b907519ea40accf11e4058b8b3c2f05940f Mon Sep 17 00:00:00 2001 From: Icarus Sparry Date: Sun, 31 Oct 2021 14:39:37 -0700 Subject: [PATCH] Forcibly disable parallelism The manually written Makefiles in the test directory are not safe to use by more than one job. For example we see things like all: clean $(EXECUTABLE) which says that the 'all' target depends on the 'clean' and '$(EXECUTABLE)' targets. If make is invoked with -j2 then the clean and '${EXECUTABLE}' can be built in parallel, so the clean can delete things whilst they are being built! Change-Id: I9c56db4c629081b8d812dad45dfd4afde10e481f Signed-off-by: Icarus Sparry [ROCm/roctracer commit: 8ea268b3f4e01ba5494aaeee3c0c61dc63b0dea2] --- projects/roctracer/test/CMakeLists.txt | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/projects/roctracer/test/CMakeLists.txt b/projects/roctracer/test/CMakeLists.txt index fd8e48553f..55a7edeaba 100644 --- a/projects/roctracer/test/CMakeLists.txt +++ b/projects/roctracer/test/CMakeLists.txt @@ -54,15 +54,15 @@ set ( GEN_INC_DIR ${PROJECT_BINARY_DIR}/inc ) set ( INC_PATH "${INC_PATH} ${GEN_INC_DIR}" ) set ( TEST_ENV ROCM_PATH=${ROCM_ROOT_DIR} HSA_PATH=${ROCM_ROOT_DIR}/hsa INC_PATH=${INC_PATH} LIB_PATH=${LIB_PATH} HIPCC_VERBOSE=3 ) add_custom_target( mytest - COMMAND ${TEST_ENV} make -C "${TEST_DIR}/MatrixTranspose" + COMMAND ${TEST_ENV} make -C "${TEST_DIR}/MatrixTranspose" -j1 COMMAND sh -xc "cp ${TEST_DIR}/MatrixTranspose/MatrixTranspose ${PROJECT_BINARY_DIR}/test" - COMMAND ${TEST_ENV} make -C "${TEST_DIR}/MatrixTranspose_test" + COMMAND ${TEST_ENV} make -C "${TEST_DIR}/MatrixTranspose_test" -j1 COMMAND sh -xc "cp ${TEST_DIR}/MatrixTranspose_test/MatrixTranspose ${PROJECT_BINARY_DIR}/test/MatrixTranspose_test" - COMMAND HIP_API_ACTIVITY_ON=1 ${TEST_ENV} make -C "${TEST_DIR}/MatrixTranspose_test" + COMMAND HIP_API_ACTIVITY_ON=1 ${TEST_ENV} make -C "${TEST_DIR}/MatrixTranspose_test" -j1 COMMAND sh -xc "cp ${TEST_DIR}/MatrixTranspose_test/MatrixTranspose ${PROJECT_BINARY_DIR}/test/MatrixTranspose_hipaact_test" - COMMAND MGPU_TEST=1 ${TEST_ENV} make -C "${TEST_DIR}/MatrixTranspose_test" + COMMAND MGPU_TEST=1 ${TEST_ENV} make -C "${TEST_DIR}/MatrixTranspose_test" -j1 COMMAND sh -xc "cp ${TEST_DIR}/MatrixTranspose_test/MatrixTranspose ${PROJECT_BINARY_DIR}/test/MatrixTranspose_mgpu" - COMMAND C_TEST=1 ${TEST_ENV} make -C "${TEST_DIR}/MatrixTranspose_test" + COMMAND C_TEST=1 ${TEST_ENV} make -C "${TEST_DIR}/MatrixTranspose_test" -j1 COMMAND sh -xc "cp ${TEST_DIR}/MatrixTranspose_test/MatrixTranspose ${PROJECT_BINARY_DIR}/test/MatrixTranspose_ctest" # copy traces COMMAND sh -xc "cp ${TEST_DIR}/golden_traces/*_trace.txt ${PROJECT_BINARY_DIR}/test/"