From 7ff1426782e908ce28370edeb70a7e04f2a6710e Mon Sep 17 00:00:00 2001 From: Maneesh Gupta Date: Thu, 21 Nov 2024 00:55:24 -0500 Subject: [PATCH] Revert "SWDEV-475482 - hipTexObjectCreate align with cuda" This reverts commit 84fb57e7f97e0bfef891969c9adc4146d103c4df. Reason for revert: Even though this change is valid, this would break backward compatibility. Change-Id: I9c7cab83198c8d5c8485b11194099162e3e7a874 [ROCm/clr commit: ec6f83b544e34bd0cb21fce339e77813d0beec6a] --- projects/clr/hipamd/src/hip_memory.cpp | 2 +- projects/clr/rocclr/platform/memory.cpp | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/projects/clr/hipamd/src/hip_memory.cpp b/projects/clr/hipamd/src/hip_memory.cpp index 665c9aa998..58133d981c 100644 --- a/projects/clr/hipamd/src/hip_memory.cpp +++ b/projects/clr/hipamd/src/hip_memory.cpp @@ -1063,7 +1063,7 @@ amd::Image* ihipImageCreate(const cl_channel_order channelOrder, imageType, CL_MEM_READ_WRITE, imageFormat, - (imageWidth == 0) ? 1 : imageWidth, + imageWidth, (imageHeight == 0) ? 1 : imageHeight, (imageDepth == 0) ? 1 : imageDepth, imageRowPitch, diff --git a/projects/clr/rocclr/platform/memory.cpp b/projects/clr/rocclr/platform/memory.cpp index c376d0abf6..a887a2c95a 100644 --- a/projects/clr/rocclr/platform/memory.cpp +++ b/projects/clr/rocclr/platform/memory.cpp @@ -675,6 +675,10 @@ bool Image::validateDimensions(const std::vector& devices, cl_mem_ } // Fall through... case CL_MEM_OBJECT_IMAGE2D: + if ((width == 0) || (height == 0)) { + DevLogPrintfError("Invalid dimensions width: %u height: %u \n", width, height); + return false; + } for (const auto dev : devices) { if ((dev->info().image2DMaxHeight_ >= height) && (dev->info().image2DMaxWidth_ >= width)) { return true; @@ -710,6 +714,10 @@ bool Image::validateDimensions(const std::vector& devices, cl_mem_ } break; case CL_MEM_OBJECT_IMAGE1D_BUFFER: + if (width == 0) { + DevLogError("Invalid dimension \n"); + return false; + } for (const auto& dev : devices) { if (dev->info().imageMaxBufferSize_ >= width) { return true;