SWDEV-516846: Fix serialization services conflicts and ATT counter streaming (#230)

* Update TT API

* Rework serialization

* update att_core

* Fix tests

* Fix tool

* Formatting

* Fix perfcounter

* Formatting

* Rename agent TT

* Format

* Workaround for codeQL alert

* Tidy fix

* Fix compiler error

* Tidy

* Fix some tests

* Fixing some tests

* formatting

* Fixing ATT serialization

* Format

* Fix test commandline

* Fixing init order

* Format

* Tidy fixes

* Removing unused sample

* Fix tests and schema

* Added ATT + PMC test

* Fix mode

* Fix file mode

* Review comments

* Fix typo

* Review comments

* Review comments

* Fix missing id inc after review comment

* Review comments

* Suggested Fixes

* Testing changes

* Test fix

* Build fixes

* Minor build fix

---------

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>
Co-authored-by: Benjamin Welton <bewelton@amd.com>
Co-authored-by: Welton, Benjamin <Benjamin.Welton@amd.com>

source/include/rocprofiler-sdk/amd_detail/thread_trace_agent.h

@@ -57,11 +57,11 @@ ROCPROFILER_EXTERN_C_INIT
  * @retval ROCPROFILER_STATUS_ERROR_INVALID_ARGUMENT for invalid rocprofiler_att_parameter_t
  */
 rocprofiler_status_t
-rocprofiler_configure_agent_thread_trace_service(
+rocprofiler_configure_device_thread_trace_service(
     rocprofiler_context_id_t               context_id,
+    rocprofiler_agent_id_t                 agent_id,
     rocprofiler_att_parameter_t*           parameters,
     size_t                                 num_parameters,
-    rocprofiler_agent_id_t                 agent_id,
     rocprofiler_att_shader_data_callback_t shader_callback,
     rocprofiler_user_data_t                callback_userdata) ROCPROFILER_API;
 

source/include/rocprofiler-sdk/amd_detail/thread_trace_dispatch.h

@@ -66,8 +66,9 @@ typedef rocprofiler_att_control_flags_t (*rocprofiler_att_dispatch_callback_t)(
 /**
  * @brief Enables the advanced thread trace service for dispatch-based tracing.
  * The tool has an option to enable/disable thread trace on every dispatch callback.
- * This service enables kernel serialization.
- * @param [in] context_id context_id.
+ * This service serializes all traced kernels, and optionally all non-traced kernels.
+ * @param [in] context_id id of the context used for start/stop thread_trace.
+ * @param [in] agent_id rocprofiler_agent_id_t to configure thread trace.
  * @param [in] parameters List of ATT-specific parameters.
  * @param [in] num_parameters Number of parameters. Zero is allowed.
  * @param [in] dispatch_callback Control fn which decides when ATT starts/stop collecting.
@@ -84,6 +85,7 @@ typedef rocprofiler_att_control_flags_t (*rocprofiler_att_dispatch_callback_t)(
 rocprofiler_status_t
 rocprofiler_configure_dispatch_thread_trace_service(
     rocprofiler_context_id_t               context_id,
+    rocprofiler_agent_id_t                 agent_id,
     rocprofiler_att_parameter_t*           parameters,
     size_t                                 num_parameters,
     rocprofiler_att_dispatch_callback_t    dispatch_callback,