Address and thread sanitizer fixes (#250)

* Address and thread sanitizer fixes

- Fix compilation with clang
- Tweak perfetto copy to build tree
- Added suppression files to scripts
- fix LD_PRELOAD support in omnitrace-causal and omnitrace-sample
- use spin_mutex and spin_lock from timemory instead of atomic_mutex and atomic_lock
- state uses atomic
- fix some memory leaks
- tweak testing
  - mpi tests do not use preload
  - increase timeout when using sanitizers
  - add env LD_PRELOAD when using sanitizers

* Tweak perfetto build

* Update timemory submodule

* Update version to 1.8.1

* Update omnitrace-leak.supp

* Update timemory submodule

- fixed spin_mutex implementation

* Remove previously added addr_space->allowTraps(instr_traps)

- this appears to cause errors during binary rewrite

* causal testing updates

- relaxed causal validation on CI systems (to account for hyperthreading decreasing prediction)
- improved impact calculation
- other general improvements to validate-causal-json.py

* Improve fork handling for perfetto

- numerous updates changing perfetto:: to ::perfetto::
- added perfetto_fwd.hpp

* Updated fork example

- user API for validation that stopping/starting perfetto is valid

* Misc fixes to perfetto + fork support

- tweak regions in fork example
- handle disabling tmp files
- get rid of stop/start with perfetto before/after fork
- fixed sampling support during fork
- tweak env of fork test

* Fix find_package in build-tree

* Fix buildtree export

* Fix buildtree export

* Restructured ConfigInstall before adding examples

* Guard against creating tmp file in sampling when disabled

* Fix buildtree package

* formatting

* exit handlers on child processes

- quick exit to avoid perfetto cleanup

* Further tweaking of causal tests for reliability

- enable PROCESSOR_AFFINITY
- decrease to 5 iterations

* Further tweaking of causal tests for reliability

- disable PROCESSOR_AFFINITY for fast func e2e tests
- enabling affinity results in (valid) speedup predictions greater than zero

* Fixes to fork handling

- use pthread_atfork for redundancy if fork_gotcha fails

* cmake formatting

* Fix fork init settings + install components

- remove dl from PROJECT_BUILD_TARGETS

* Testing tweaks

- fix mpi-binary-rewrite-run regex when OMNITRACE_VERBOSE set > 1 in env
- increase causal e2e iterations to 8

* Fix "Test User API"

- test-find-package.sh included dl component

* Further tweaks to causal validation

- further considerations of variance
This commit is contained in:
Jonathan R. Madsen
2023-02-27 12:09:03 -06:00
committed by GitHub
parent 9a665b5684
commit 846301bcaf
48 changed files with 885 additions and 455 deletions
@@ -207,6 +207,8 @@ pthread_create_gotcha::wrapper::operator()() const
_info->index_data->as_string().c_str(),
_parent_info->index_data->as_string().c_str());
threading::set_thread_name(TIMEMORY_JOIN(" ", "Thread", _tid).c_str());
auto _manager = tim::manager::instance();
if(_manager) _manager->initialize();
if(!thread_bundle_data_t::instances().at(_tid))
{
thread_data<thread_bundle_t>::construct(
@@ -262,12 +264,15 @@ pthread_create_gotcha::wrapper::operator()() const
// execute the original function
_ret = m_routine(m_arg);
pop_thread_state();
if(get_state() < ::omnitrace::State::Finalized)
{
pop_thread_state();
// execute the destructor actions
_dtor();
// execute the destructor actions
_dtor();
set_thread_state(ThreadState::Completed);
set_thread_state(ThreadState::Completed);
}
return _ret;
}
@@ -281,7 +286,12 @@ pthread_create_gotcha::wrapper::wrap(void* _arg)
wrapper* _wrapper = static_cast<wrapper*>(_arg);
// execute the original function
return (*_wrapper)();
void* _ret = (*_wrapper)();
// eliminate memory leak
if(_ret != _arg) delete _wrapper;
return _ret;
}
void