From 848340186f7bd81e4f77d9fca9ed1bddf2e49aed Mon Sep 17 00:00:00 2001 From: Shweta Khatri Date: Tue, 17 Sep 2024 16:16:44 -0400 Subject: [PATCH] hsakmt: openclose.c: Fix Coverity reported warnings Add check before close to prevent closing invalid file descriptors Change-Id: Ie1d50e0d55159512a14a70c1e4be058218aae668 [ROCm/ROCR-Runtime commit: ff6e1b44bfcc088af4d97214a8a80632253e1f7e] --- projects/rocr-runtime/libhsakmt/src/openclose.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/projects/rocr-runtime/libhsakmt/src/openclose.c b/projects/rocr-runtime/libhsakmt/src/openclose.c index 177b341b4c..86dcc9b23a 100644 --- a/projects/rocr-runtime/libhsakmt/src/openclose.c +++ b/projects/rocr-runtime/libhsakmt/src/openclose.c @@ -227,7 +227,8 @@ HSAKMT_STATUS HSAKMTAPI hsaKmtOpenKFD(void) return result; topology_sysfs_failed: kfd_version_failed: - close(fd); + if (fd >= 0) + close(fd); open_failed: pthread_mutex_unlock(&hsakmt_mutex);