From f5d6bb8267ab5030c82a328b5fdec8ca3cbf03b8 Mon Sep 17 00:00:00 2001 From: Evgeny Mankov Date: Fri, 19 Jul 2019 20:23:17 +0300 Subject: [PATCH] [HIPIFY][#941][fix] Workaround for an assert on forbidden option "--" + Fixes the following assert in debug version: Assertion failed: (S.empty() || S[0] != '-') && "Option can't start with '-", file C:\GIT\LLVM\trunk-for-submits\llvm-project\llvm\lib\Support\CommandLine.cpp, line 440 + DashDash option left declared in order to be listed in help. --- hipify-clang/src/ArgParse.cpp | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hipify-clang/src/ArgParse.cpp b/hipify-clang/src/ArgParse.cpp index 60b0dd390b..8a5a5b6e6c 100644 --- a/hipify-clang/src/ArgParse.cpp +++ b/hipify-clang/src/ArgParse.cpp @@ -34,12 +34,12 @@ cl::opt OutputDir("o-dir", cl::value_desc("directory"), cl::cat(ToolTemplateCategory)); -cl::opt GeneratePerl("perl", +cl::opt GeneratePerl("perl", cl::desc("Generate hipify-perl"), cl::value_desc("perl"), cl::cat(ToolTemplateCategory)); -cl::opt GeneratePython("python", +cl::opt GeneratePython("python", cl::desc("Generate hipify-python"), cl::value_desc("python"), cl::cat(ToolTemplateCategory)); @@ -69,17 +69,17 @@ cl::opt CudaPath("cuda-path", cl::value_desc("directory"), cl::cat(ToolTemplateCategory)); -cl::opt SaveTemps("save-temps", +cl::opt SaveTemps("save-temps", cl::desc("Save temporary files"), cl::value_desc("save-temps"), cl::cat(ToolTemplateCategory)); -cl::opt Verbose("v", +cl::opt Verbose("v", cl::desc("Show commands to run and use verbose output"), cl::value_desc("v"), cl::cat(ToolTemplateCategory)); -cl::opt TranslateToRoc("roc", +cl::opt TranslateToRoc("roc", cl::desc("Translate to roc instead of hip where it is possible"), cl::value_desc("roc"), cl::cat(ToolTemplateCategory)); @@ -119,9 +119,9 @@ cl::opt Examine("examine", cl::value_desc("examine"), cl::cat(ToolTemplateCategory)); -cl::opt DashDash("-", +cl::opt DashDash(" ", cl::desc("Separator between hipify-clang and clang options;\ndon't specify if there are no clang options"), - cl::value_desc("--"), + cl::ValueDisallowed, cl::cat(ToolTemplateCategory)); cl::list IncludeDirs("I",