From 88cd2fd02ae6ec68557a4fde7d6bf047f523a53c Mon Sep 17 00:00:00 2001 From: foreman Date: Thu, 10 Nov 2016 17:04:27 -0500 Subject: [PATCH] P4 to Git Change 1339730 by lmoriche@lmoriche_opencl_dev on 2016/11/10 16:37:37 SWDEV-103793 - [ROCm CQE][OCLonLC][ISV] QCDGPU test fails - The runtime should not report cl_amd_fp64, cl_khr_fp64 should be used instead. Affected files ... ... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palsettings.cpp#10 edit ... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocsettings.cpp#9 edit [ROCm/clr commit: 30a604865856f551ad1b9e80fee9d9d847446b1d] --- projects/clr/rocclr/runtime/device/pal/palsettings.cpp | 10 +++++++--- .../clr/rocclr/runtime/device/rocm/rocsettings.cpp | 4 +++- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/projects/clr/rocclr/runtime/device/pal/palsettings.cpp b/projects/clr/rocclr/runtime/device/pal/palsettings.cpp index c76d835ded..44f47a418c 100644 --- a/projects/clr/rocclr/runtime/device/pal/palsettings.cpp +++ b/projects/clr/rocclr/runtime/device/pal/palsettings.cpp @@ -302,13 +302,15 @@ Settings::create( enableExtension(ClKhrByteAddressableStore); enableExtension(ClKhrGlSharing); enableExtension(ClKhrGlEvent); + enableExtension(ClKhr3DImageWrites); + enableExtension(ClKhrImage2dFromBuffer); enableExtension(ClAmdMediaOps); enableExtension(ClAmdMediaOps2); +#if !defined(WITH_LIGHTNING_COMPILER) enableExtension(ClAmdPopcnt); - enableExtension(ClKhr3DImageWrites); enableExtension(ClAmdVec3); enableExtension(ClAmdPrintf); - enableExtension(ClKhrImage2dFromBuffer); +#endif // !defined(WITH_LIGHTNING_COMPILER) // Enable some platform extensions enableExtension(ClAmdDeviceAttributeQuery); enableExtension(ClKhrSpir); @@ -332,13 +334,15 @@ Settings::create( enableExtension(ClKhrFp64); } +#if !defined(WITH_LIGHTNING_COMPILER) if (doublePrecision) { // Enable AMD double precision extension doublePrecision_ = true; enableExtension(ClAmdFp64); } +#endif // !defined(WITH_LIGHTNING_COMPILER) -//! @todo +//! @todo /* if (calAttr.totalSDIHeap > 0) { //Enable bus addressable memory extension diff --git a/projects/clr/rocclr/runtime/device/rocm/rocsettings.cpp b/projects/clr/rocclr/runtime/device/rocm/rocsettings.cpp index e6aa50a3b4..0d1bdebcd5 100644 --- a/projects/clr/rocclr/runtime/device/rocm/rocsettings.cpp +++ b/projects/clr/rocclr/runtime/device/rocm/rocsettings.cpp @@ -81,10 +81,12 @@ Settings::create(bool doublePrecision) if (doublePrecision_) { // Enable KHR double precision extension enableExtension(ClKhrFp64); +#if !defined(WITH_LIGHTNING_COMPILER) // Also enable AMD double precision extension? enableExtension(ClAmdFp64); +#endif // !defined(WITH_LIGHTNING_COMPILER) } - + enableExtension(ClKhrSubGroups); enableExtension(ClKhrDepthImages);