Add missing tests for hipHostMalloc (#2566)

catch/unit/memory/hipHostMallocTests.cc

@@ -1,5 +1,5 @@
 /*
-Copyright (c) 2021 Advanced Micro Devices, Inc. All rights reserved.
+Copyright (c) 2022 Advanced Micro Devices, Inc. All rights reserved.
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights
@@ -29,33 +29,40 @@ Testcase Scenarios :
 */
 
 #include <hip_test_common.hh>
+#include <hip_test_helper.hh>
 
 /**
  * Performs argument validation of hipHostMalloc api.
  */
 TEST_CASE("Unit_hipHostMalloc_ArgValidation") {
-  hipError_t ret;
+#if HT_NVIDIA
+  HipTest::HIP_SKIP_TEST("TODO: Need to debug");
+#endif
   constexpr size_t allocSize = 1000;
-  char *ptr;
+  char* ptr;
 
   SECTION("Pass ptr as nullptr") {
-    ret = hipHostMalloc(static_cast<void **>(nullptr), allocSize);
-    REQUIRE(ret != hipSuccess);
+    HIP_CHECK_ERROR(hipHostMalloc(static_cast<void**>(nullptr), allocSize), hipErrorInvalidValue);
   }
 
   SECTION("Size as max(size_t)") {
-    ret = hipHostMalloc(&ptr, std::numeric_limits<std::size_t>::max());
-    REQUIRE(ret != hipSuccess);
+    HIP_CHECK_ERROR(hipHostMalloc(&ptr, std::numeric_limits<std::size_t>::max()),
+                    hipErrorMemoryAllocation);
   }
 
   SECTION("Flags as max(uint)") {
-    ret = hipHostMalloc(&ptr, allocSize,
-                             std::numeric_limits<unsigned int>::max());
-    REQUIRE(ret != hipSuccess);
+    HIP_CHECK_ERROR(hipHostMalloc(&ptr, allocSize, std::numeric_limits<unsigned int>::max()),
+                    hipErrorInvalidValue);
   }
 
   SECTION("Pass size as zero and check ptr reset") {
     HIP_CHECK(hipHostMalloc(&ptr, 0));
     REQUIRE(ptr == nullptr);
   }
+
+  SECTION("Pass hipHostMallocCoherent and hipHostMallocNonCoherent simultaneously") {
+    HIP_CHECK_ERROR(
+        hipHostMalloc(&ptr, allocSize, hipHostMallocCoherent | hipHostMallocNonCoherent),
+        hipErrorInvalidValue);
+  }
 }