Make job id char array const in rdc api

Also make adjustments to packaging.

Change-Id: I73cc18ce67f833ff563cb1488b000b69b315979a

include/rdc/rdc.h

@@ -418,7 +418,7 @@ rdc_status_t rdc_disconnect(rdc_handle_t p_rdc_handle);
  *  @retval ::RDC_ST_OK is returned upon successful call.
  */
 rdc_status_t rdc_job_start_stats(rdc_handle_t p_rdc_handle,
-    rdc_gpu_group_t group_id, char job_id[64], uint64_t update_freq);
+    rdc_gpu_group_t group_id, const char job_id[64], uint64_t update_freq);
 
 /**
  *  @brief Get the stats of the job using the job id.
@@ -435,8 +435,8 @@ rdc_status_t rdc_job_start_stats(rdc_handle_t p_rdc_handle,
  *
  *  @retval ::RDC_ST_OK is returned upon successful call.
  */
-rdc_status_t rdc_job_get_stats(rdc_handle_t p_rdc_handle, char  job_id[64],
-                rdc_job_info_t* p_job_info);
+rdc_status_t rdc_job_get_stats(rdc_handle_t p_rdc_handle,
+                           const char job_id[64], rdc_job_info_t* p_job_info);
 
 /**
  *  @brief Request RDC to stop watching the stats of the job
@@ -452,7 +452,7 @@ rdc_status_t rdc_job_get_stats(rdc_handle_t p_rdc_handle, char  job_id[64],
  *  @retval ::RDC_ST_OK is returned upon successful call.
  */
 rdc_status_t rdc_job_stop_stats(rdc_handle_t p_rdc_handle,
-            char  job_id[64]);
+                                                       const char job_id[64]);
 
 /**
  *  @brief Request RDC to stop tracking the job given by job_id
@@ -467,8 +467,7 @@ rdc_status_t rdc_job_stop_stats(rdc_handle_t p_rdc_handle,
  *
  *  @retval ::RDC_ST_OK is returned upon successful call.
  */
-rdc_status_t rdc_job_remove(rdc_handle_t p_rdc_handle,
-            char  job_id[64]);
+rdc_status_t rdc_job_remove(rdc_handle_t p_rdc_handle, const char job_id[64]);
 
 /**
  *  @brief Request RDC to stop tracking all the jobs

include/rdc_lib/RdcCacheManager.h

@@ -46,18 +46,18 @@ class RdcCacheManager {
                 uint64_t max_keep_samples, double  max_keep_age) = 0;
     virtual std::string  get_cache_stats() = 0;
 
-    virtual rdc_status_t rdc_job_get_stats(char jobId[64],
+    virtual rdc_status_t rdc_job_get_stats(const char job_id[64],
         const rdc_gpu_gauges_t& gpu_gauges,
         rdc_job_info_t* p_job_info) = 0;
-    virtual rdc_status_t rdc_job_start_stats(char jobId[64],
+    virtual rdc_status_t rdc_job_start_stats(const char job_id[64],
         const rdc_group_info_t& group,
         const rdc_field_group_info_t& finfo,
         const rdc_gpu_gauges_t& gpu_gauges) = 0;
-    virtual rdc_status_t rdc_job_stop_stats(char job_id[64],
+    virtual rdc_status_t rdc_job_stop_stats(const char job_id[64],
                 const rdc_gpu_gauges_t& gpu_gauge) = 0;
     virtual rdc_status_t rdc_update_job_stats(uint32_t gpu_index,
         const std::string& job_id, const rdc_field_value& value) = 0;
-    virtual rdc_status_t rdc_job_remove(char job_id[64]) = 0;
+    virtual rdc_status_t rdc_job_remove(const char job_id[64]) = 0;
     virtual rdc_status_t rdc_job_remove_all() = 0;
 
     virtual ~RdcCacheManager() {}

include/rdc_lib/RdcHandler.h

@@ -33,11 +33,11 @@ class RdcHandler {
  public:
     // Job API
     virtual rdc_status_t rdc_job_start_stats(rdc_gpu_group_t groupId,
-                char job_id[64], uint64_t update_freq) = 0;
-    virtual rdc_status_t rdc_job_get_stats(char jobId[64],
+                             const char job_id[64], uint64_t update_freq) = 0;
+    virtual rdc_status_t rdc_job_get_stats(const char jobId[64],
                 rdc_job_info_t* p_job_info)= 0;
-    virtual rdc_status_t rdc_job_stop_stats(char job_id[64]) = 0;
-    virtual rdc_status_t rdc_job_remove(char job_id[64]) = 0;
+    virtual rdc_status_t rdc_job_stop_stats(const char job_id[64]) = 0;
+    virtual rdc_status_t rdc_job_remove(const char job_id[64]) = 0;
     virtual rdc_status_t rdc_job_remove_all() = 0;
 
     // Discovery API

include/rdc_lib/RdcWatchTable.h

@@ -36,11 +36,11 @@ class RdcWatchTable {
     virtual rdc_status_t rdc_field_update_all() = 0;
 
     virtual rdc_status_t rdc_job_start_stats(rdc_gpu_group_t group_id,
-                char job_id[64], uint64_t update_freq,
+                const char job_id[64], uint64_t update_freq,
                 const rdc_gpu_gauges_t& gpu_gauge) = 0;
-    virtual rdc_status_t rdc_job_stop_stats(char job_id[64],
+    virtual rdc_status_t rdc_job_stop_stats(const char job_id[64],
                 const rdc_gpu_gauges_t& gpu_gauge) = 0;
-    virtual rdc_status_t rdc_job_remove(char job_id[64]) = 0;
+    virtual rdc_status_t rdc_job_remove(const char job_id[64]) = 0;
     virtual rdc_status_t rdc_job_remove_all() = 0;
 
     virtual rdc_status_t rdc_field_watch(rdc_gpu_group_t group_id,

include/rdc_lib/impl/RdcCacheManagerImpl.h

@@ -81,19 +81,19 @@ class RdcCacheManagerImpl: public RdcCacheManager {
                 uint64_t max_keep_samples, double  max_keep_age) override;
     std::string  get_cache_stats()  override;
 
-    rdc_status_t rdc_job_get_stats(char  job_id[64],
+    rdc_status_t rdc_job_get_stats(const char job_id[64],
         const rdc_gpu_gauges_t& gpu_gauges,
         rdc_job_info_t* p_job_info) override;
-    rdc_status_t rdc_job_start_stats(char job_id[64],
+    rdc_status_t rdc_job_start_stats(const char job_id[64],
         const rdc_group_info_t& group,
         const rdc_field_group_info_t& finfo,
         const rdc_gpu_gauges_t& gpu_gauges) override;
-    rdc_status_t rdc_job_stop_stats(char job_id[64],
+    rdc_status_t rdc_job_stop_stats(const char job_id[64],
                     const rdc_gpu_gauges_t& gpu_gauge) override;
     rdc_status_t rdc_update_job_stats(uint32_t gpu_index,
         const std::string& job_id,
         const rdc_field_value& value) override;
-    rdc_status_t rdc_job_remove(char job_id[64]) override;
+    rdc_status_t rdc_job_remove(const char job_id[64]) override;
     rdc_status_t rdc_job_remove_all() override;
 
  private:

include/rdc_lib/impl/RdcEmbeddedHandler.h

@@ -37,11 +37,11 @@ class RdcEmbeddedHandler: public RdcHandler {
  public:
     // Job API
     rdc_status_t rdc_job_start_stats(rdc_gpu_group_t groupId,
-                char job_id[64], uint64_t update_freq) override;
-    rdc_status_t rdc_job_get_stats(char jobId[64],
+                        const char job_id[64], uint64_t update_freq) override;
+    rdc_status_t rdc_job_get_stats(const char jobId[64],
                 rdc_job_info_t* p_job_info) override;
-    rdc_status_t rdc_job_stop_stats(char job_id[64]) override;
-    rdc_status_t rdc_job_remove(char job_id[64]) override;
+    rdc_status_t rdc_job_stop_stats(const char job_id[64]) override;
+    rdc_status_t rdc_job_remove(const char job_id[64]) override;
     rdc_status_t rdc_job_remove_all() override;
 
     // Discovery API

include/rdc_lib/impl/RdcStandaloneHandler.h

@@ -33,11 +33,11 @@ class RdcStandaloneHandler: public RdcHandler {
  public:
     // Job RdcAPI
     rdc_status_t rdc_job_start_stats(rdc_gpu_group_t groupId,
-                char job_id[64], uint64_t update_freq) override;
-    rdc_status_t rdc_job_get_stats(char jobId[64],
+                        const char job_id[64], uint64_t update_freq) override;
+    rdc_status_t rdc_job_get_stats(const char jobId[64],
                 rdc_job_info_t* p_job_info) override;
-    rdc_status_t rdc_job_stop_stats(char job_id[64]) override;
-    rdc_status_t rdc_job_remove(char job_id[64]) override;
+    rdc_status_t rdc_job_stop_stats(const char job_id[64]) override;
+    rdc_status_t rdc_job_remove(const char job_id[64]) override;
     rdc_status_t rdc_job_remove_all() override;
 
     // Discovery RdcAPI

include/rdc_lib/impl/RdcWatchTableImpl.h

@@ -54,11 +54,11 @@ struct JobWatchTableEntry {
 class RdcWatchTableImpl : public RdcWatchTable {
  public:
     rdc_status_t rdc_job_start_stats(rdc_gpu_group_t group_id,
-                    char job_id[64], uint64_t update_freq,
+                    const char job_id[64], uint64_t update_freq,
                     const rdc_gpu_gauges_t& gpu_gauge) override;
-    rdc_status_t rdc_job_stop_stats(char job_id[64],
+    rdc_status_t rdc_job_stop_stats(const char job_id[64],
                     const rdc_gpu_gauges_t& gpu_gauge) override;
-    rdc_status_t rdc_job_remove(char job_id[64]) override;
+    rdc_status_t rdc_job_remove(const char job_id[64]) override;
     rdc_status_t rdc_job_remove_all() override;
 
     rdc_status_t rdc_field_watch(rdc_gpu_group_t group_id,