AI/rocm-systems
2
0
Bifurcation 0
Code Tickets Demandes d'ajout Actions Paquets Projets Publications Wiki Activité

Make job id char array const in rdc api

Parcourir la source 
Also make adjustments to packaging.

Change-Id: I73cc18ce67f833ff563cb1488b000b69b315979a
Cette révision appartient à :
Chris Freehill
2020-06-10 16:35:13 -05:00
Parent 3793e8df27
révision 8e4d1e7f33
15 fichiers modifiés avec 68 ajouts et 61 suppressions
Télécharger le Fichier Patch Télécharger le Fichier des Différences Développer tous les fichiers Réduire tous les fichiers
rdc_libs/bootstrap/src/RdcBootStrap.cc
+6 -5
Voir le fichier
@@ -112,8 +112,8 @@ rdc_status_t rdc_field_update_all(rdc_handle_t p_rdc_handle,
rdc_field_update_all(wait_for_update);
}
rdc_status_t rdc_job_get_stats(rdc_handle_t p_rdc_handle, char job_id[64] ,
rdc_job_info_t* p_job_info) {
rdc_status_t rdc_job_get_stats(rdc_handle_t p_rdc_handle,
const char job_id[64], rdc_job_info_t* p_job_info) {
if (!p_rdc_handle) {
return RDC_ST_INVALID_HANDLER;
}
@@ -123,7 +123,7 @@ rdc_status_t rdc_job_get_stats(rdc_handle_t p_rdc_handle, char job_id[64] ,
}
rdc_status_t rdc_job_start_stats(rdc_handle_t p_rdc_handle,
rdc_gpu_group_t groupId, char job_id[64],
rdc_gpu_group_t groupId, const char job_id[64],
uint64_t update_freq) {
if (!p_rdc_handle) {
return RDC_ST_INVALID_HANDLER;
@@ -133,7 +133,7 @@ rdc_status_t rdc_job_start_stats(rdc_handle_t p_rdc_handle,
rdc_job_start_stats(groupId, job_id, update_freq);
}
rdc_status_t rdc_job_remove(rdc_handle_t p_rdc_handle, char job_id[64]) {
rdc_status_t rdc_job_remove(rdc_handle_t p_rdc_handle, const char job_id[64]) {
if (!p_rdc_handle) {
return RDC_ST_INVALID_HANDLER;
}
@@ -152,7 +152,8 @@ rdc_status_t rdc_job_remove_all(rdc_handle_t p_rdc_handle) {
}
rdc_status_t rdc_job_stop_stats(rdc_handle_t p_rdc_handle, char job_id[64] ) {
rdc_status_t rdc_job_stop_stats(rdc_handle_t p_rdc_handle,
const char job_id[64] ) {
if (!p_rdc_handle) {
return RDC_ST_INVALID_HANDLER;
}
rdc_libs/rdc/src/RdcCacheManagerImpl.cc
+4 -4
Voir le fichier
@@ -175,7 +175,7 @@ rdc_status_t RdcCacheManagerImpl::rdc_update_cache(uint32_t gpu_index,
return RDC_ST_OK;
}
rdc_status_t RdcCacheManagerImpl::rdc_job_remove(char job_id[64]) {
rdc_status_t RdcCacheManagerImpl::rdc_job_remove(const char job_id[64]) {
std::lock_guard<std::mutex> guard(cache_mutex_);
cache_jobs_.erase(job_id);
return RDC_ST_OK;
@@ -250,7 +250,7 @@ void RdcCacheManagerImpl::set_summary(const FieldSummaryStats & stats,
summary.average += gpu.average;
}
rdc_status_t RdcCacheManagerImpl::rdc_job_get_stats(char jobId[64],
rdc_status_t RdcCacheManagerImpl::rdc_job_get_stats(const char jobId[64],
const rdc_gpu_gauges_t& gpu_gauges,
rdc_job_info_t* p_job_info) {
std::lock_guard<std::mutex> guard(cache_mutex_);
@@ -384,7 +384,7 @@ rdc_status_t RdcCacheManagerImpl::rdc_job_get_stats(char jobId[64],
return RDC_ST_OK;
}
rdc_status_t RdcCacheManagerImpl::rdc_job_start_stats(char job_id[64],
rdc_status_t RdcCacheManagerImpl::rdc_job_start_stats(const char job_id[64],
const rdc_group_info_t& ginfo, const rdc_field_group_info_t& finfo,
const rdc_gpu_gauges_t& gpu_gauges) {
RdcJobStatsCacheEntry cacheEntry;
@@ -426,7 +426,7 @@ rdc_status_t RdcCacheManagerImpl::rdc_job_start_stats(char job_id[64],
}
rdc_status_t RdcCacheManagerImpl::rdc_job_stop_stats(char job_id[64],
rdc_status_t RdcCacheManagerImpl::rdc_job_stop_stats(const char job_id[64],
const rdc_gpu_gauges_t& gpu_gauges) {
std::lock_guard<std::mutex> guard(cache_mutex_);
auto job_stats = cache_jobs_.find(job_id);
rdc_libs/rdc/src/RdcEmbeddedHandler.cc
+4 -4
Voir le fichier
@@ -85,7 +85,7 @@ RdcEmbeddedHandler::~RdcEmbeddedHandler() {
// JOB API
rdc_status_t RdcEmbeddedHandler::rdc_job_start_stats(rdc_gpu_group_t groupId,
char job_id[64], uint64_t update_freq) {
const char job_id[64], uint64_t update_freq) {
rdc_gpu_gauges_t gpu_gauges;
rdc_status_t status = get_gpu_gauges(&gpu_gauges);
if (status != RDC_ST_OK) return status;
@@ -136,7 +136,7 @@ rdc_status_t RdcEmbeddedHandler::get_gpu_gauges(rdc_gpu_gauges_t* gpu_gauges) {
return RDC_ST_OK;
}
rdc_status_t RdcEmbeddedHandler::rdc_job_get_stats(char job_id[64],
rdc_status_t RdcEmbeddedHandler::rdc_job_get_stats(const char job_id[64],
rdc_job_info_t* p_job_info) {
if (p_job_info == nullptr) {
return RDC_ST_BAD_PARAMETER;
@@ -149,7 +149,7 @@ rdc_status_t RdcEmbeddedHandler::rdc_job_get_stats(char job_id[64],
return cache_mgr_->rdc_job_get_stats(job_id, gpu_gauges, p_job_info);
}
rdc_status_t RdcEmbeddedHandler::rdc_job_stop_stats(char job_id[64]) {
rdc_status_t RdcEmbeddedHandler::rdc_job_stop_stats(const char job_id[64]) {
rdc_gpu_gauges_t gpu_gauges;
rdc_status_t status = get_gpu_gauges(&gpu_gauges);
if (status != RDC_ST_OK) return status;
@@ -157,7 +157,7 @@ rdc_status_t RdcEmbeddedHandler::rdc_job_stop_stats(char job_id[64]) {
return watch_table_->rdc_job_stop_stats(job_id, gpu_gauges);
}
rdc_status_t RdcEmbeddedHandler::rdc_job_remove(char job_id[64]) {
rdc_status_t RdcEmbeddedHandler::rdc_job_remove(const char job_id[64]) {
return watch_table_->rdc_job_remove(job_id);
}
rdc_libs/rdc/src/RdcWatchTableImpl.cc
+3 -3
Voir le fichier
@@ -41,7 +41,7 @@ RdcWatchTableImpl::RdcWatchTableImpl(const RdcGroupSettingsPtr& group_settings,
}
rdc_status_t RdcWatchTableImpl::rdc_job_start_stats(rdc_gpu_group_t group_id,
char job_id[64], uint64_t update_freq,
const char job_id[64], uint64_t update_freq,
const rdc_gpu_gauges_t& gpu_gauges) {
do { //< lock guard for thread safe
std::lock_guard<std::mutex> guard(watch_mutex_);
@@ -92,7 +92,7 @@ rdc_status_t RdcWatchTableImpl::rdc_job_start_stats(rdc_gpu_group_t group_id,
return result;
}
rdc_status_t RdcWatchTableImpl::rdc_job_stop_stats(char job_id[64],
rdc_status_t RdcWatchTableImpl::rdc_job_stop_stats(const char job_id[64],
const rdc_gpu_gauges_t& gpu_gauge) {
uint32_t job_group_id;
do { //< lock guard for thread safe
@@ -119,7 +119,7 @@ rdc_status_t RdcWatchTableImpl::rdc_job_stop_stats(char job_id[64],
return result;
}
rdc_status_t RdcWatchTableImpl::rdc_job_remove(char job_id[64]) {
rdc_status_t RdcWatchTableImpl::rdc_job_remove(const char job_id[64]) {
rdc_gpu_gauges_t gpu_gauge;
rdc_job_stop_stats(job_id, gpu_gauge);
return cache_mgr_->rdc_job_remove(job_id);
rdc_libs/rdc_client/src/RdcStandaloneHandler.cc
+5 -5
Voir le fichier
@@ -61,8 +61,8 @@ rdc_status_t RdcStandaloneHandler::error_handle(::grpc::Status status,
}
// JOB RdcAPI
rdc_status_t RdcStandaloneHandler::rdc_job_start_stats(rdc_gpu_group_t groupId,
char job_id[64], uint64_t update_freq) {
rdc_status_t RdcStandaloneHandler::rdc_job_start_stats(
rdc_gpu_group_t groupId, const char job_id[64], uint64_t update_freq) {
::rdc::StartJobStatsRequest request;
::rdc::StartJobStatsResponse reply;
::grpc::ClientContext context;
@@ -133,7 +133,7 @@ bool RdcStandaloneHandler::copy_gpu_usage_info(
return true;
}
rdc_status_t RdcStandaloneHandler::rdc_job_get_stats(char job_id[64],
rdc_status_t RdcStandaloneHandler::rdc_job_get_stats(const char job_id[64],
rdc_job_info_t* p_job_info) {
if (!p_job_info) {
return RDC_ST_BAD_PARAMETER;
@@ -157,7 +157,7 @@ rdc_status_t RdcStandaloneHandler::rdc_job_get_stats(char job_id[64],
return RDC_ST_OK;
}
rdc_status_t RdcStandaloneHandler::rdc_job_stop_stats(char job_id[64]) {
rdc_status_t RdcStandaloneHandler::rdc_job_stop_stats(const char job_id[64]) {
::rdc::StopJobStatsRequest request;
::rdc::StopJobStatsResponse reply;
::grpc::ClientContext context;
@@ -169,7 +169,7 @@ rdc_status_t RdcStandaloneHandler::rdc_job_stop_stats(char job_id[64]) {
return err_status;
}
rdc_status_t RdcStandaloneHandler::rdc_job_remove(char job_id[64]) {
rdc_status_t RdcStandaloneHandler::rdc_job_remove(const char job_id[64]) {
::rdc::RemoveJobRequest request;
::rdc::RemoveJobResponse reply;
::grpc::ClientContext context;