AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change default mutex to thread only (#104)

Browse Source 
Most sysfs reads do not require cross-process level mutex, and writes to sysfs
should be protected by the kernel already.
Users can still switch to the old behavior by setting the environment variable AMDSMI_MUTEX_CROSS_PROCESS=1.
This commit is contained in:
Liu, Shuzhou (Bill)
2025-02-11 08:27:03 -05:00
committed by GitHub
parent dc4a16da6f
commit 8e74024b11
2 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
third_party/shared_mutex/shared_mutex.cc
Vendored
+5 -4
View File
@@ -44,7 +44,8 @@ THE SOFTWARE.
#include "rocm_smi/rocm_smi_exception.h"
#include "rocm_smi/rocm_smi_main.h"
#define THREAD_ONLY_ENV_VAR "RSMI_MUTEX_THREAD_ONLY"
// Default to thread only mutex unless export AMDSMI_MUTEX_CROSS_PROCESS=1
#define PROCESS_CROSS_PROCESS_ENV_VAR "AMDSMI_MUTEX_CROSS_PROCESS"
#define MUTEX_TIME_OUT_ENV_VAR "RSMI_MUTEX_TIMEOUT"
#define DEFAULT_MUTEX_TIMEOUT_SECONDS 5
@@ -141,7 +142,7 @@ shared_mutex_t shared_mutex_init(const char *name, mode_t mode, bool retried) {
amd::smi::RocmSMI& smi = amd::smi::RocmSMI::getInstance();
if (GetEnvVarUInteger(THREAD_ONLY_ENV_VAR) == 1 || smi.is_thread_only_mutex()) {
if (GetEnvVarUInteger(PROCESS_CROSS_PROCESS_ENV_VAR) != 1 || smi.is_thread_only_mutex()) {
return init_thread_safe_only(name);
}
@@ -296,7 +297,7 @@ shared_mutex_t shared_mutex_init(const char *name, mode_t mode, bool retried) {
int shared_mutex_close(shared_mutex_t mutex) {
amd::smi::RocmSMI& smi = amd::smi::RocmSMI::getInstance();
const bool is_thread_only = GetEnvVarUInteger(THREAD_ONLY_ENV_VAR) == 1 ||
const bool is_thread_only = GetEnvVarUInteger(PROCESS_CROSS_PROCESS_ENV_VAR) != 1 ||
smi.is_thread_only_mutex();
if (is_thread_only) {
delete mutex.ptr;
@@ -317,7 +318,7 @@ int shared_mutex_close(shared_mutex_t mutex) {
int shared_mutex_destroy(shared_mutex_t mutex) {
amd::smi::RocmSMI& smi = amd::smi::RocmSMI::getInstance();
const bool is_thread_only = GetEnvVarUInteger(THREAD_ONLY_ENV_VAR) == 1 ||
const bool is_thread_only = GetEnvVarUInteger(PROCESS_CROSS_PROCESS_ENV_VAR) != 1 ||
smi.is_thread_only_mutex();
if ((errno = pthread_mutex_destroy(mutex.ptr))) {
perror("pthread_mutex_destroy");