AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[SWDEV-519061] xgmi command output shows zero for all xgmi acc read/write data in the first column (#392)

Browse Source 
The xgmi read and write accumulated data from gpu metric index
is based on sysfs xgmi_port_num file. Mapped these two to display
read and write wrt src_gpu Vs dst_gpu.
---------

Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com>
This commit is contained in:
Kanangot Balakrishnan, Bindhiya
2025-06-02 14:01:06 -05:00
committed by GitHub
parent bf0448ff96
commit 8ed52616ad
7 changed files with 161 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/amd_smi/amd_smi.cc
+42 -4
View File
@@ -1747,9 +1747,6 @@ amdsmi_get_gpu_xgmi_link_status(amdsmi_processor_handle processor_handle,
uint32_t dev_num = 0;
rsmi_num_monitor_devices(&dev_num);
link_status->total_links = AMDSMI_MAX_NUM_XGMI_LINKS;
if (dev_num <= link_status->total_links) {
link_status->total_links = dev_num;
}
// get the status values from the metric info
for (unsigned int i = 0; i < link_status->total_links; i++) {
if (metric_info.xgmi_link_status[i] == std::numeric_limits<uint16_t>::max()) {
@@ -2132,12 +2129,53 @@ amdsmi_status_t amdsmi_get_link_metrics(amdsmi_processor_handle processor_handle
(metric_info.xgmi_link_width != std::numeric_limits<uint16_t>::max()))
link_metrics->max_bandwidth = metric_info.xgmi_link_speed * metric_info.xgmi_link_width;
uint16_t link_to_dst_node[AMDSMI_MAX_NUM_XGMI_LINKS];
std::fill_n(link_to_dst_node, AMDSMI_MAX_NUM_XGMI_LINKS, std::numeric_limits<uint16_t>::max());
status = rsmi_wrapper(rsmi_dev_xgmi_port_num_get, processor_handle, 0,
&link_metrics->num_links, link_to_dst_node);
for (unsigned int i = 0; i < AMDSMI_MAX_NUM_XGMI_LINKS; i++) {
memset(&link_metrics->links[i].bdf, 0xFF, sizeof(amdsmi_bdf_t));
if (link_to_dst_node[i] != std::numeric_limits<uint16_t>::max()) {
uint32_t node_id = link_to_dst_node[i];
std::string node_symlink = "node" + std::to_string(node_id);
std::string sysfs_base = "/sys/bus/pci/devices/";
DIR *dir = opendir(sysfs_base.c_str());
if (dir) {
struct dirent *entry;
while ((entry = readdir(dir)) != nullptr) {
if (entry->d_type != DT_DIR && entry->d_type != DT_LNK)
continue;
std::string bdf = entry->d_name;
if (bdf == "." || bdf == "..") continue;
std::string symlink_path = sysfs_base + bdf + "/xgmi_hive_info/" + node_symlink;
char buf[PATH_MAX] = {0};
ssize_t len = readlink(symlink_path.c_str(), buf, sizeof(buf)-1);
if (len > 0) {
buf[len] = '\0';
std::string target(buf);
size_t last_slash = target.find_last_of('/');
std::string bdf_str = (last_slash != std::string::npos) ? target.substr(last_slash + 1) : target;
// Parse BDF string: "dddd:bb:dd.f"
unsigned domain = 0, bus = 0, device = 0, function = 0;
if (sscanf(bdf_str.c_str(), "%4x:%2x:%2x.%1x", &domain, &bus, &device, &function) == 4) {
amdsmi_bdf_t dst_bdf = {};
dst_bdf.domain_number = static_cast<uint16_t>(domain);
dst_bdf.bus_number = static_cast<uint8_t>(bus);
dst_bdf.device_number = static_cast<uint8_t>(device);
dst_bdf.function_number = static_cast<uint8_t>(function);
link_metrics->links[i].bdf = dst_bdf;
}
break; // Found, stop searching
}
}
closedir(dir);
}
}
link_metrics->links[i].read = metric_info.xgmi_read_data_acc[i];
link_metrics->links[i].write = metric_info.xgmi_write_data_acc[i];
link_metrics->links[i].link_type = AMDSMI_LINK_TYPE_XGMI;
}
return AMDSMI_STATUS_SUCCESS;
}