From 8fc1d27ecd3dff741bb3eb0b2146763579e5a1a2 Mon Sep 17 00:00:00 2001 From: "Galantsev, Dmitrii" Date: Tue, 22 Jul 2025 14:41:37 -0500 Subject: [PATCH] Profiler - Remove UUID metric Signed-off-by: Galantsev, Dmitrii [ROCm/rdc commit: 059451d48f8c80cdc5e94959b76904f5473be8c9] --- projects/rdc/common/rdc_field.data | 1 - projects/rdc/include/rdc/rdc.h | 1 - .../rdc_modules/rdc_rocp/RdcRocpBase.cc | 25 +------------------ 3 files changed, 1 insertion(+), 26 deletions(-) diff --git a/projects/rdc/common/rdc_field.data b/projects/rdc/common/rdc_field.data index 6e447974ea..8c8603d16b 100644 --- a/projects/rdc/common/rdc_field.data +++ b/projects/rdc/common/rdc_field.data @@ -195,7 +195,6 @@ FLD_DESC_ENT(RDC_FI_PROF_CPF_CPF_TCIU_IDLE, "", "CPF_CPF_TCIU_I FLD_DESC_ENT(RDC_FI_PROF_CPF_CPF_TCIU_STALL, "", "CPF_CPF_TCIU_STALL", false) // Misc FLD_DESC_ENT(RDC_FI_PROF_SIMD_UTILIZATION, "Fraction of time the SIMDs are being utilized", "SIMD_UTILIZATION", false) -FLD_DESC_ENT(RDC_FI_PROF_UUID, "UUID from rocprofiler", "PROF_UUID", true) FLD_DESC_ENT(RDC_FI_PROF_KFD_ID, "GPU_ID from rocprofiler, same as KFD_ID", "PROF_KFD_ID", true) // Events diff --git a/projects/rdc/include/rdc/rdc.h b/projects/rdc/include/rdc/rdc.h index 51569189ce..60383f3cc3 100644 --- a/projects/rdc/include/rdc/rdc.h +++ b/projects/rdc/include/rdc/rdc.h @@ -345,7 +345,6 @@ typedef enum { RDC_FI_PROF_CPF_CPF_TCIU_IDLE, RDC_FI_PROF_CPF_CPF_TCIU_STALL, RDC_FI_PROF_SIMD_UTILIZATION, - RDC_FI_PROF_UUID, RDC_FI_PROF_KFD_ID, /** diff --git a/projects/rdc/rdc_libs/rdc_modules/rdc_rocp/RdcRocpBase.cc b/projects/rdc/rdc_libs/rdc_modules/rdc_rocp/RdcRocpBase.cc index 658b26b4d4..1576f0f164 100644 --- a/projects/rdc/rdc_libs/rdc_modules/rdc_rocp/RdcRocpBase.cc +++ b/projects/rdc/rdc_libs/rdc_modules/rdc_rocp/RdcRocpBase.cc @@ -110,7 +110,6 @@ static const std::map temp_field_map_k = { {RDC_FI_PROF_CPF_CPF_TCIU_IDLE, "CPF_CPF_TCIU_IDLE"}, {RDC_FI_PROF_CPF_CPF_TCIU_STALL, "CPF_CPF_TCIU_STALL"}, {RDC_FI_PROF_SIMD_UTILIZATION, "SIMD_UTILIZATION"}, - {RDC_FI_PROF_UUID, "SQ_WAVES"}, // dummy value, {RDC_FI_PROF_KFD_ID, "SQ_WAVES"}, // dummy value, }; @@ -164,21 +163,6 @@ const std::vector RdcRocpBase::get_field_ids() { return field_ids; } -rocprofiler_uuid_t asic_serial_to_uuid(const char* asic_serial) { - rocprofiler_uuid_t uuid = {0}; - // have to cast to stoull as a workaround for amdsmi ignoring leading zeroes - uuid.value = std::stoull(asic_serial, nullptr, 16); - return uuid; -} - -std::string uuid_to_string(const uint64_t uuid) { - std::ostringstream oss; - oss << "0x" << std::hex << std::setw(16) << std::setfill('0') << uuid; - return oss.str(); -} - -std::string uuid_to_string(const rocprofiler_uuid_t& uuid) { return uuid_to_string(uuid.value); } - rdc_status_t RdcRocpBase::map_entity_to_profiler() { // std::map entity_to_index_map; // kfd_id_t is only used inside this function @@ -419,15 +403,8 @@ rdc_status_t RdcRocpBase::rocp_lookup(rdc_gpu_field_t gpu_field, rdc_field_value // FLOPS/clock/CU data->dbl = divided_dbl / (256.0F / static_cast(agents[agent_index].simd_per_cu)); break; - case RDC_FI_PROF_UUID: { - // do not care what RDC_FI_PROF_UUID is mapped to. read value from agents - *type = STRING; - std::string uuid_str = uuid_to_string(agents[agent_index].uuid); - strncpy_with_null(data->str, uuid_str.c_str(), uuid_str.length()); - break; - } case RDC_FI_PROF_KFD_ID: { - // do not care what RDC_FI_PROF_UUID is mapped to. read value from agents + // do not care what it is mapped to. read value from agents *type = INTEGER; data->l_int = agents[agent_index].gpu_id; break;