From 905b943769c08f5367db9b83cd52c0258d462642 Mon Sep 17 00:00:00 2001 From: Jatin Chaudhary Date: Tue, 17 Oct 2023 23:44:16 +0100 Subject: [PATCH] SWDEV-425943 - skip certain tests for gfx90a+ Change-Id: I055182144d5a5e470e5cca81306f7d7c838792d9 --- catch/hipTestMain/config/config_amd_linux | 2 +- catch/unit/memory/CMakeLists.txt | 33 +++++++++++++++++++++-- 2 files changed, 32 insertions(+), 3 deletions(-) diff --git a/catch/hipTestMain/config/config_amd_linux b/catch/hipTestMain/config/config_amd_linux index 1b7051cf5a..9f233a653d 100644 --- a/catch/hipTestMain/config/config_amd_linux +++ b/catch/hipTestMain/config/config_amd_linux @@ -8,7 +8,7 @@ #define MI100 #endif -#if defined gfx90a || defined gfx940 +#if defined gfx90a || defined gfx940 || defined gfx941 || defined gfx942 #define MI2XX #endif diff --git a/catch/unit/memory/CMakeLists.txt b/catch/unit/memory/CMakeLists.txt index fa340863a6..2f32e74b1d 100644 --- a/catch/unit/memory/CMakeLists.txt +++ b/catch/unit/memory/CMakeLists.txt @@ -118,10 +118,8 @@ set(TEST_SRC hipMemsetFunctional.cc hipMalloc.cc hipMallocPitch.cc - hipMallocArray.cc hipMalloc3D.cc hipMalloc3DArray.cc - hipArrayCreate.cc hipArray3DCreate.cc hipDrvMemcpy3D.cc hipDrvMemcpy3D_old.cc @@ -144,6 +142,37 @@ set(TEST_SRC hipMemRangeGetAttributes_old.cc hipMemGetAddressRange.cc) +set(NOT_FOR_MI200_AND_ABOVE_TEST hipMallocArray.cc hipArrayCreate.cc) # tests not for MI200+ +set(MI200_AND_ABOVE_TARGETS gfx90a gfx940 gfx941 gfx942) +function(CheckRejectedArchs OFFLOAD_ARCH_STR_LOCAL) + set(ARCH_CHECK -1 PARENT_SCOPE) + string(REGEX MATCHALL "--offload-arch=gfx[0-9a-z]+" OFFLOAD_ARCH_LIST ${OFFLOAD_ARCH_STR_LOCAL}) + foreach(OFFLOAD_ARCH IN LISTS OFFLOAD_ARCH_LIST) + string(REGEX MATCHALL "--offload-arch=(gfx[0-9a-z]+)" matches ${OFFLOAD_ARCH}) + if (CMAKE_MATCH_COUNT EQUAL 1) + if (CMAKE_MATCH_1 IN_LIST MI200_AND_ABOVE_TARGETS) + set(ARCH_CHECK 1 PARENT_SCOPE) + endif() # CMAKE_MATCH_1 + endif() # CMAKE_MATCH_COUNT + endforeach() # OFFLOAD_ARCH_LIST +endfunction() # CheckAcceptedArchs + +if(HIP_PLATFORM MATCHES "amd") + if (DEFINED OFFLOAD_ARCH_STR) + CheckRejectedArchs(${OFFLOAD_ARCH_STR}) + elseif(DEFINED $ENV{HCC_AMDGPU_TARGET}) + CheckRejectedArchs($ENV{HCC_AMDGPU_TARGET}) + else() + set(ARCH_CHECK -1) + endif() + if(${ARCH_CHECK} EQUAL -1) + message(STATUS "Adding test: ${NOT_FOR_MI200_AND_ABOVE_TEST}") + set(TEST_SRC ${TEST_SRC} ${NOT_FOR_MI200_AND_ABOVE_TEST}) + endif() +else() + set(TEST_SRC ${TEST_SRC} ${NOT_FOR_MI200_AND_ABOVE_TEST}) +endif() + hip_add_exe_to_target(NAME MemoryTest2 TEST_SRC ${TEST_SRC} TEST_TARGET_NAME build_tests COMMON_SHARED_SRC ${COMMON_SHARED_SRC})