From 90de01adb937189158d9ea3e5bce24ce891622d3 Mon Sep 17 00:00:00 2001 From: ROCm CI Service Account <66695075+rocm-ci@users.noreply.github.com> Date: Wed, 28 Jun 2023 21:59:03 +0530 Subject: [PATCH] SWDEV-393746 - Fix HIP sample failures-21, 22, 23 (#331) Change-Id: Id839cf24ba5f16897428b19c0299ea781a5a6d09 --- samples/2_Cookbook/21_cmake_hip_cxx_clang/README.md | 12 ++++++++---- samples/2_Cookbook/22_cmake_hip_lang/README.md | 9 ++++++++- samples/2_Cookbook/23_cmake_hiprtc/README.md | 9 ++++++++- 3 files changed, 24 insertions(+), 6 deletions(-) diff --git a/samples/2_Cookbook/21_cmake_hip_cxx_clang/README.md b/samples/2_Cookbook/21_cmake_hip_cxx_clang/README.md index 3d9765308c..a7d362a990 100644 --- a/samples/2_Cookbook/21_cmake_hip_cxx_clang/README.md +++ b/samples/2_Cookbook/21_cmake_hip_cxx_clang/README.md @@ -1,15 +1,18 @@ ### This sample tests CXX Language support with amdclang++ I. Build + +``` mkdir -p build; cd build rm -rf *; -CXX=`hipconfig -l`/amdclang++ cmake .. (or) -cmake -DCMAKE_CXX_COMPILER=/opt/rocm/bin/amdclang++ .. (or) -cmake -DCMAKE_CXX_COMPILER=/opt/rocm-X.Y.Z/llvm/bin/amdclang++ .. +CXX="$(hipconfig -l)"/amdclang++ cmake -DCMAKE_PREFIX_PATH=/opt/rocm .. make +``` II. Test + +``` $ ./square -info: running on device Vega 20 [Radeon Pro Vega 20] +info: running on device AMD Radeon Graphics info: allocate host mem ( 7.63 MB) info: allocate device mem ( 7.63 MB) info: copy Host2Device @@ -17,3 +20,4 @@ info: launch 'vector_square' kernel info: copy Device2Host info: check result PASSED! +``` diff --git a/samples/2_Cookbook/22_cmake_hip_lang/README.md b/samples/2_Cookbook/22_cmake_hip_lang/README.md index 7f7ac025b1..5ba33f8362 100644 --- a/samples/2_Cookbook/22_cmake_hip_lang/README.md +++ b/samples/2_Cookbook/22_cmake_hip_lang/README.md @@ -1,10 +1,16 @@ ### This will test HIP language support in upstream CMake I. Build + +``` mkdir -p build; cd build -rm -rf *; cmake -DCMAKE_PREFIX_PATH=/opt/rocm/ .. +rm -rf *; +cmake -DCMAKE_PREFIX_PATH=/opt/rocm .. make +``` II. Test + +``` $ ./square info: running on device info: allocate host mem ( 7.63 MB) @@ -14,3 +20,4 @@ info: launch 'vector_square' kernel info: copy Device2Host info: check result PASSED! +``` diff --git a/samples/2_Cookbook/23_cmake_hiprtc/README.md b/samples/2_Cookbook/23_cmake_hiprtc/README.md index 2831619d19..cb270e6466 100644 --- a/samples/2_Cookbook/23_cmake_hiprtc/README.md +++ b/samples/2_Cookbook/23_cmake_hiprtc/README.md @@ -1,9 +1,16 @@ ### This will test linking hiprtc::hiprtc interface in cmake I. Build + +``` mkdir -p build; cd build -rm -rf *; CXX=amdclang++ cmake -DCMAKE_PREFIX_PATH=/opt/rocm/hip .. +rm -rf *; +CXX="$(hipconfig -l)"/amdclang++ cmake -DCMAKE_PREFIX_PATH=/opt/rocm .. make +``` II. Test + +``` $ ./test SAXPY test completed +```