P4 to Git Change 1189687 by emankov@em-hsa-amd on 2015/09/10 13:34:22
ECR #333753 - ORCA RT: fix for continuing work after Program build failure. [Synopsis] If program build (compile or link) is failed RT continues its work and fails further (for example, in symbol.setDeviceKernel). It was hard to find out the real failure (HSAILProgram::linkImpl) due to buildLog, which is printed once in the end, and due to abscence of LogError function call. [Misc] + Error handling improvement in HSAILProgram::linkImpl and some others. ToDo: Do the same for the rest. + LogError() is added to Program::build/compile/link [Testing] pre check-in Reviewer: German Andryeyev Affected files ... ... //depot/stg/opencl/drivers/opencl/runtime/device/device.cpp#184 edit ... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprogram.cpp#206 edit ... //depot/stg/opencl/drivers/opencl/runtime/platform/program.cpp#65 edit
This commit is contained in:
@@ -747,6 +747,7 @@ Program::compile(const std::string& sourceCode,
|
||||
f.write(logs.data(), logs.size());
|
||||
f.close();
|
||||
}
|
||||
LogError(buildLog_.c_str());
|
||||
}
|
||||
|
||||
return buildError();
|
||||
@@ -854,6 +855,7 @@ cl_int Program::link(const std::vector<Program*>& inputPrograms,
|
||||
f.write(logs.data(), logs.size());
|
||||
f.close();
|
||||
}
|
||||
LogError(buildLog_.c_str());
|
||||
}
|
||||
|
||||
return buildError();
|
||||
@@ -948,6 +950,7 @@ Program::build(const std::string& sourceCode,
|
||||
f.write(logs.data(), logs.size());
|
||||
f.close();
|
||||
}
|
||||
LogError(buildLog_.c_str());
|
||||
}
|
||||
|
||||
return buildError();
|
||||
|
||||
Referens i nytt ärende
Block a user