P4 to Git Change 1189687 by emankov@em-hsa-amd on 2015/09/10 13:34:22

ECR #333753 - ORCA RT: fix for continuing work after Program build failure.

	[Synopsis]
	If program build (compile or link) is failed RT continues its work and fails further (for example, in symbol.setDeviceKernel). It was hard to find out the real failure (HSAILProgram::linkImpl) due to buildLog, which is printed once in the end, and due to abscence of LogError function call.

	[Misc]
	+ Error handling improvement in HSAILProgram::linkImpl and some others.  ToDo: Do the same for the rest.
	+ LogError() is added to Program::build/compile/link

	[Testing] pre check-in

	Reviewer: German Andryeyev

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/device.cpp#184 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprogram.cpp#206 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/program.cpp#65 edit

rocclr/runtime/platform/program.cpp

@@ -485,6 +485,10 @@ Program::build(
         }
     }
 
+    if (retval != CL_SUCCESS) {
+        return retval;
+    }
+
     // Rebuild the symbol table
     deviceprograms_t::iterator sit;
     for (sit = devicePrograms_.begin(); sit != devicePrograms_.end(); ++sit) {