AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[rocprof-sys] Use fmt APIs to construct strings instead of JOIN (#2643)

Browse Source 
## Motivation

With the introduction of the new logging system base on `spdlog` library, opportunity shows to replace `timemory` dependent JOIN implementation with `fmt` library `format` and `join` APIs, which are shipped as a part of `spdlog` lib

## Technical Details

Use `fmt` provided APIs to properly format and package strings.
This commit is contained in:
marantic-amd
2026-01-23 06:34:58 +01:00
committed by GitHub
parent 3318c540ea
commit 956a73c4c8
38 changed files with 356 additions and 357 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/rocprofiler-systems/source/lib/core/rocprofiler-sdk.cpp
+7 -6
View File
@@ -27,6 +27,8 @@
#include "logger/debug.hpp"
#include <spdlog/fmt/ranges.h>
#if defined(ROCPROFSYS_USE_ROCM) && ROCPROFSYS_USE_ROCM > 0
# include <timemory/defines.h>
@@ -281,11 +283,11 @@ config_settings(const std::shared_ptr<settings>& _config)
if(_skip_domains.count(_v) > 0) return;
auto _op_option_name = JOIN('_', "ROCPROFSYS_ROCM", _domain_name, "OPERATIONS");
auto _op_option_name = fmt::format("ROCPROFSYS_ROCM_{}_OPERATIONS", _domain_name);
auto _eop_option_name =
JOIN('_', "ROCPROFSYS_ROCM", _domain_name, "OPERATIONS_EXCLUDE");
fmt::format("ROCPROFSYS_ROCM_{}_OPERATIONS_EXCLUDE", _domain_name);
auto _bt_option_name =
JOIN('_', "ROCPROFSYS_ROCM", _domain_name, "OPERATIONS_ANNOTATE_BACKTRACE");
fmt::format("ROCPROFSYS_ROCM_{}_OPERATIONS_ANNOTATE_BACKTRACE", _domain_name);
auto _op_choices = std::vector<std::string>{};
for(auto itr : _domain.operations)
@@ -343,10 +345,9 @@ config_settings(const std::shared_ptr<settings>& _config)
std::sort(_domain_choices.begin(), _domain_choices.end());
namespace join = ::timemory::join;
auto _domain_description =
JOIN("", "Specification of ROCm domains to trace/profile. Choices: ",
join::join(join::array_config{ ", ", "", "" }, _domain_choices));
fmt::format("Specification of ROCm domains to trace/profile. Choices: {}",
fmt::join(_domain_choices, ", "));
auto _domain_defaults = std::string{ "hip_runtime_api,marker_api,kernel_dispatch,"
"memory_copy,scratch_memory" };