From 957b1173d571993ef75cb7dfd27b277cd19b0361 Mon Sep 17 00:00:00 2001 From: Satyanvesh Dittakavi Date: Mon, 14 Mar 2022 13:23:20 +0000 Subject: [PATCH] SWDEV-326382 - Fix Pytorch test failures with hiprtc hiprtcCreateProgram should create program even if the name passed is NULL or empty string Change-Id: Ide5ea70f6c5d96b0f26320cef277508cdbe8dfde [ROCm/clr commit: 2ab2e0d020d5dfb58a079ca2e9f53227fb90d3a0] --- projects/clr/hipamd/src/hiprtc/hiprtc.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/projects/clr/hipamd/src/hiprtc/hiprtc.cpp b/projects/clr/hipamd/src/hiprtc/hiprtc.cpp index c1c17c38bb..71dc59f9d8 100644 --- a/projects/clr/hipamd/src/hiprtc/hiprtc.cpp +++ b/projects/clr/hipamd/src/hiprtc/hiprtc.cpp @@ -75,11 +75,13 @@ hiprtcResult hiprtcCreateProgram(hiprtcProgram* prog, const char* src, const cha if (numHeaders && (headers == nullptr || headerNames == nullptr)) { HIPRTC_RETURN(HIPRTC_ERROR_INVALID_INPUT); } - if(name == nullptr) { - HIPRTC_RETURN(HIPRTC_ERROR_INVALID_INPUT); + std::string progName; + + if (name) { + progName = name; } - auto* rtcProgram = new hiprtc::RTCProgram(std::string(name)); + auto* rtcProgram = new hiprtc::RTCProgram(progName); if (rtcProgram == nullptr) { HIPRTC_RETURN(HIPRTC_ERROR_PROGRAM_CREATION_FAILURE); }