From 6f6228cf36c0461555847966e6b184d5e40d5faf Mon Sep 17 00:00:00 2001 From: emankov Date: Sat, 29 Dec 2018 19:48:28 +0300 Subject: [PATCH] [HIPIFY] Get rid of setting '--cuda-gpu-arch=' [Reasons] + We don't compile kernel code at least for now as HIP kernel syntax is almost equal CUDA's; + clang always includes PTX in its binaries, so e.g. a binary compiled with --cuda-gpu-arch= would be forwards-compatible with e.g. sm_35 GPUs. --- hipamd/hipify-clang/README.md | 3 +-- hipamd/tests/hipify-clang/lit.cfg | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hipamd/hipify-clang/README.md b/hipamd/hipify-clang/README.md index 845d0e0a9e..5b4424b791 100644 --- a/hipamd/hipify-clang/README.md +++ b/hipamd/hipify-clang/README.md @@ -322,7 +322,6 @@ For example: square.cu \ -- \ --cuda-path=/usr/local/cuda-8.0 \ - --cuda-gpu-arch=sm_50 \ -isystem /usr/local/cuda-8.0/samples/common/inc ``` @@ -338,5 +337,5 @@ The information contained herein is for informational purposes only, and is subj AMD, the AMD Arrow logo, and combinations thereof are trademarks of Advanced Micro Devices, Inc. Other product names used in this publication are for identification purposes only and may be trademarks of their respective companies. -Copyright (c) 2014-2018 Advanced Micro Devices, Inc. All rights reserved. +Copyright (c) 2014-2019 Advanced Micro Devices, Inc. All rights reserved. diff --git a/hipamd/tests/hipify-clang/lit.cfg b/hipamd/tests/hipify-clang/lit.cfg index db1508a38f..7b25731ba6 100644 --- a/hipamd/tests/hipify-clang/lit.cfg +++ b/hipamd/tests/hipify-clang/lit.cfg @@ -60,7 +60,7 @@ if obj_root is not None: config.environment['PATH'] = path hipify_path = obj_root -clang_args = "-v --cuda-gpu-arch=sm_30 --cuda-path='%s'" +clang_args = "-v --cuda-path='%s'" if sys.platform in ['win32']: run_test_ext = ".bat"