From 99b2e4190657757b82fd68d9378c874c0153451e Mon Sep 17 00:00:00 2001 From: Ori Messinger Date: Tue, 31 May 2022 06:13:56 -0400 Subject: [PATCH] ROCm SMI CLI: Fix setClockRange Error This patch changes the error handling for setClockRange. When a device does not support modifying a clock type (sclk/mclk), an error message is printed through the python CLI. Signed-off-by: Ori Messinger Change-Id: I37d9ea4189b1ca81e5deaab5efa6cfa4901b89b3 [ROCm/amdsmi commit: 2b8d0ad70ff698853e3974a15a3a99b527a3b732] --- projects/amdsmi/python_smi_tools/rocm_smi.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/projects/amdsmi/python_smi_tools/rocm_smi.py b/projects/amdsmi/python_smi_tools/rocm_smi.py index 04dc643019..309bec4ecc 100755 --- a/projects/amdsmi/python_smi_tools/rocm_smi.py +++ b/projects/amdsmi/python_smi_tools/rocm_smi.py @@ -772,11 +772,13 @@ def setClockRange(deviceList, clkType, minvalue, maxvalue, autoRespond): printLogSpacer(' Set Valid %s Range ' % (clkType)) for device in deviceList: ret = rocmsmi.rsmi_dev_clk_range_set(device, int(minvalue), int(maxvalue), rsmi_clk_names_dict[clkType]) - if rsmi_ret_ok(ret, device): + if rsmi_ret_ok(ret, device, silent=True): printLog(device, 'Successfully set %s from %s(MHz) to %s(MHz)' % (clkType, minvalue, maxvalue), None) else: printErrLog(device, 'Unable to set %s from %s(MHz) to %s(MHz)' % (clkType, minvalue, maxvalue)) RETCODE = 1 + if ret == rsmi_status_t.RSMI_STATUS_NOT_SUPPORTED: + printLog(device, 'Setting %s range is not supported for this device.' % (clkType), None) def setVoltageCurve(deviceList, point, clk, volt, autoRespond):