Split ROCTx API tables and update intercept table API (#421)

* Update include/rocprofiler-sdk

- buffer_tracing.h
  - fix doxygen for rocprofiler_buffer_tracing_hip_api_record_t
  - update doxygen for rocprofiler_buffer_tracing_marker_api_record_t
    - remove unused marker_id field
- fwd.h
  - Split ROCPROFILER_CALLBACK_TRACING_MARKER_API into ROCPROFILER_CALLBACK_TRACING_MARKER_{CORE,CONTROL,NAME}_API
  - Split ROCPROFILER_BUFFER_TRACING_MARKER_API into ROCPROFILER_BUFFER_TRACING_MARKER_{CORE,CONTROL,NAME}_API
  - split rocprofiler_runtime_library_t into rocprofiler_runtime_library_t and rocprofiler_intercept_table_t
    - after split of ROCTx into 3 tables, specifying rocprofiler_at_internal_thread_create became confusing

* Update include/rocprofiler-sdk-roctx/api_trace.h

- Split into three tables: core, control, and name
  - core: what it sounds like
  - control: functions for controling the profiler
  - name: functions for giving resources names

* Update lib/rocprofiler-sdk-roctx/roctx.cpp

- modifications following split into multiple tables

* Update lib/rocprofiler-sdk/marker/*

- modifications following split of ROCTx API into multiple intercept tables

* Update lib/rocprofiler-sdk/tests

- common.hpp
  - add enums to get_callback_tracing_names() and get_buffer_tracing_names()
- intercept_table.cpp
  - update test to use rocprofiler_intercept_table_t (and enums) instead of rocproifler_runtime_library_t
  - update OR combos tested
- roctx.cpp
  - updates following split of ROCTx API table into multiple tables
  - use simplified specification of control API

* Update lib/rocprofiler-sdk

- buffer_tracing.cpp
  - Updates for ROCPROFILER_BUFFER_TRACING_MARKER_{CORE,CONTROL,NAME}_API enum values
- callback_tracing.cpp
  - Updates for ROCPROFILER_CALLBACK_TRACING_MARKER_{CORE,CONTROL,NAME}_API enum values
- intercept_table.hpp
  - notify_runtime_api_registration -> notify_intercept_table_registration
- intercept_table.cpp
  - updates for new rocprofiler_intercept_table_t enum and new ROCTx tables
- registration.cpp
  - updates for new rocprofiler_intercept_table_t enum and new ROCTx tables
  - updates for notify_runtime_api_registration -> notify_intercept_table_registration

* Update lib/rocprofiler-sdk-tool

- helper.cpp
  - Updates for new enums in get_callback_id_names() and get_buffer_id_names()
- tool.cpp
  - migrate to new enums for split ROCTx tables
  - use simplified split for control table vs. core+name tables

* Update samples/{api_callback_tracing,intercept_table}

- intercept_table/client.cpp
  - rocprofiler_runtime_library_t -> rocprofiler_intercept_table_t
- api_callback_tracing/client.cpp
  - Updates for new enums in get_callback_id_names()
  - use simplified split for control table vs. core+name tables
  - migrate to new enums for split ROCTx tables

* Update tests

- rocprofv3/tracing/validate.py
  - handle new marker domain names
- tools/json-tool.cpp
  - Updates for new enums in get_callback_id_names() and get_buffer_id_names()
  - use simplified split for control table vs. core+name tables
  - migrate to new enums for split ROCTx tables

* Update tests/rocprofv3/tracing/CMakeLists.txt

- fix FAIL_REGULAR_EXPRESSION for rocprofv3-test-trace-execute

* Update lib/rocprofiler-sdk-tool/{output_file,tool}.*

- logging in output_file dtor
- support stdout/stderr

* Update lib/common/container/record_header_buffer.hpp

- reduce probability of is_empty() returning true while emplace is happening

* Update lib/rocprofiler-sdk-tool/tool.cpp

- logging for buffered_tracing_callback
- counter collection uses CSV encoder

* Update bin/rocprofv3

- remove -i flag from help menu

samples/api_callback_tracing/client.cpp

@@ -136,7 +136,11 @@ get_callback_id_names()
     static auto supported = std::unordered_set<rocprofiler_callback_tracing_kind_t>{
         ROCPROFILER_CALLBACK_TRACING_HSA_API,
         ROCPROFILER_CALLBACK_TRACING_HIP_API,
-        ROCPROFILER_CALLBACK_TRACING_MARKER_API};
+        ROCPROFILER_CALLBACK_TRACING_HIP_COMPILER_API,
+        ROCPROFILER_CALLBACK_TRACING_MARKER_CORE_API,
+        ROCPROFILER_CALLBACK_TRACING_MARKER_CONTROL_API,
+        ROCPROFILER_CALLBACK_TRACING_MARKER_NAME_API,
+    };
 
     auto cb_name_info = callback_name_info{};
     //
@@ -192,14 +196,14 @@ tool_tracing_ctrl_callback(rocprofiler_callback_tracing_record_t record,
     auto* ctx = static_cast<rocprofiler_context_id_t*>(client_data);
 
     if(record.phase == ROCPROFILER_CALLBACK_PHASE_ENTER &&
-       record.kind == ROCPROFILER_CALLBACK_TRACING_MARKER_API &&
-       record.operation == ROCPROFILER_MARKER_API_ID_roctxProfilerPause)
+       record.kind == ROCPROFILER_CALLBACK_TRACING_MARKER_CONTROL_API &&
+       record.operation == ROCPROFILER_MARKER_CONTROL_API_ID_roctxProfilerPause)
     {
         ROCPROFILER_CALL(rocprofiler_stop_context(*ctx), "pausing client context");
     }
     else if(record.phase == ROCPROFILER_CALLBACK_PHASE_EXIT &&
-            record.kind == ROCPROFILER_CALLBACK_TRACING_MARKER_API &&
-            record.operation == ROCPROFILER_MARKER_API_ID_roctxProfilerResume)
+            record.kind == ROCPROFILER_CALLBACK_TRACING_MARKER_CONTROL_API &&
+            record.operation == ROCPROFILER_MARKER_CONTROL_API_ID_roctxProfilerResume)
     {
         ROCPROFILER_CALL(rocprofiler_start_context(*ctx), "resuming client context");
     }
@@ -254,35 +258,9 @@ tool_tracing_callback(rocprofiler_callback_tracing_record_t record,
     _mutex.unlock();
 }
 
-std::vector<uint32_t>
+void
 tool_control_init(rocprofiler_context_id_t& primary_ctx)
 {
-    struct RoctxOperations
-    {
-        std::vector<uint32_t> core  = {};
-        std::vector<uint32_t> cntrl = {};
-    };
-
-    auto roctx_ops = RoctxOperations();
-
-    // get all the operations for ROCPROFILER_CALLBACK_TRACING_MARKER_API and
-    // separate them into two arrays; one which contains the pause/resume operations
-    // and one with everything else
-    ROCPROFILER_CALL(
-        rocprofiler_iterate_callback_tracing_kind_operations(
-            ROCPROFILER_CALLBACK_TRACING_MARKER_API,
-            [](rocprofiler_callback_tracing_kind_t, uint32_t operation_v, void* data_v) {
-                auto* roctx_ops_v = static_cast<RoctxOperations*>(data_v);
-                if(operation_v == ROCPROFILER_MARKER_API_ID_roctxProfilerPause ||
-                   operation_v == ROCPROFILER_MARKER_API_ID_roctxProfilerResume)
-                    roctx_ops_v->cntrl.emplace_back(operation_v);
-                else
-                    roctx_ops_v->core.emplace_back(operation_v);
-                return 0;
-            },
-            &roctx_ops),
-        "iterating callback tracing kind operations");
-
     // Create a specialized (throw-away) context for handling ROCTx profiler pause and resume.
     // A separate context is used because if the context that is associated with roctxProfilerPause
     // disabled that same context, a call to roctxProfilerResume would be ignored because the
@@ -291,19 +269,17 @@ tool_control_init(rocprofiler_context_id_t& primary_ctx)
     ROCPROFILER_CALL(rocprofiler_create_context(&cntrl_ctx), "control context creation failed");
 
     // enable callback marker tracing with only the pause/resume operations
-    ROCPROFILER_CALL(
-        rocprofiler_configure_callback_tracing_service(cntrl_ctx,
-                                                       ROCPROFILER_CALLBACK_TRACING_MARKER_API,
-                                                       roctx_ops.cntrl.data(),
-                                                       roctx_ops.cntrl.size(),
-                                                       tool_tracing_ctrl_callback,
-                                                       &primary_ctx),
-        "callback tracing service failed to configure");
+    ROCPROFILER_CALL(rocprofiler_configure_callback_tracing_service(
+                         cntrl_ctx,
+                         ROCPROFILER_CALLBACK_TRACING_MARKER_CONTROL_API,
+                         nullptr,
+                         0,
+                         tool_tracing_ctrl_callback,
+                         &primary_ctx),
+                     "callback tracing service failed to configure");
 
     // start the context so that it is always active
     ROCPROFILER_CALL(rocprofiler_start_context(cntrl_ctx), "start of control context");
-
-    return roctx_ops.core;
 }
 
 int
@@ -344,7 +320,7 @@ tool_init(rocprofiler_client_finalize_t fini_func, void* tool_data)
     ROCPROFILER_CALL(rocprofiler_create_context(&client_ctx), "context creation failed");
 
     // enable the control
-    auto roctx_ops = tool_control_init(client_ctx);
+    tool_control_init(client_ctx);
 
     ROCPROFILER_CALL(
         rocprofiler_configure_callback_tracing_service(client_ctx,
@@ -366,9 +342,18 @@ tool_init(rocprofiler_client_finalize_t fini_func, void* tool_data)
 
     ROCPROFILER_CALL(
         rocprofiler_configure_callback_tracing_service(client_ctx,
-                                                       ROCPROFILER_CALLBACK_TRACING_MARKER_API,
-                                                       roctx_ops.data(),
-                                                       roctx_ops.size(),
+                                                       ROCPROFILER_CALLBACK_TRACING_MARKER_CORE_API,
+                                                       nullptr,
+                                                       0,
+                                                       tool_tracing_callback,
+                                                       tool_data),
+        "callback tracing service failed to configure");
+
+    ROCPROFILER_CALL(
+        rocprofiler_configure_callback_tracing_service(client_ctx,
+                                                       ROCPROFILER_CALLBACK_TRACING_MARKER_NAME_API,
+                                                       nullptr,
+                                                       0,
                                                        tool_tracing_callback,
                                                        tool_data),
         "callback tracing service failed to configure");