From a13da7ba0247a1ae4ce7438985b4c9932f8d4e7b Mon Sep 17 00:00:00 2001
From: Marko Arandjelovic <marandje@amd.com>
Date: Tue, 30 Jul 2024 12:05:50 +0200
Subject: [PATCH] SWDEV-476486 - Add unit test for hipMemAllocHost

Change-Id: Ie77686b4e2a269b845b3187f27281a5a855bd731
---
 catch/unit/memory/CMakeLists.txt     |   1 +
 catch/unit/memory/hipMemAllocHost.cc | 131 +++++++++++++++++++++++++++
 2 files changed, 132 insertions(+)
 create mode 100644 catch/unit/memory/hipMemAllocHost.cc

diff --git a/catch/unit/memory/CMakeLists.txt b/catch/unit/memory/CMakeLists.txt
index 21a83de80c..1637403b0d 100644
--- a/catch/unit/memory/CMakeLists.txt
+++ b/catch/unit/memory/CMakeLists.txt
@@ -63,6 +63,7 @@ set(TEST_SRC
     hipHostGetFlags.cc
     hipHostGetDevicePointer.cc
     hipMallocHost.cc
+    hipMemAllocHost.cc
     hipMallocManaged_MultiScenario.cc
     hipMemsetNegative.cc
     hipMemset.cc
diff --git a/catch/unit/memory/hipMemAllocHost.cc b/catch/unit/memory/hipMemAllocHost.cc
new file mode 100644
index 0000000000..6b4aba36e8
--- /dev/null
+++ b/catch/unit/memory/hipMemAllocHost.cc
@@ -0,0 +1,131 @@
+/*
+Copyright (c) 2024 Advanced Micro Devices, Inc. All rights reserved.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
+*/
+
+#include <hip_test_common.hh>
+
+static __global__ void write_integer(int* memory, int value) { *memory = value; }
+
+TEST_CASE("Unit_hipMemAllocHost_Positive") {
+  int* host_memory = nullptr;
+  hipCtx_t ctx;
+  hipDevice_t device;
+
+  HIP_CHECK(hipGetDevice(&device));
+  HIP_CHECK(hipCtxCreate(&ctx, 0, device));
+  HIP_CHECK(hipMemAllocHost(reinterpret_cast<void**>(&host_memory), sizeof(int)));
+  REQUIRE(host_memory != nullptr);
+  HIP_CHECK(hipHostFree(host_memory));
+  HIP_CHECK(hipCtxDestroy(ctx));
+}
+
+TEST_CASE("Unit_hipMemAllocHost_DataValidation") {
+  int validation_number = 10;
+  int* host_memory = nullptr;
+  hipEvent_t event = nullptr;
+  hipCtx_t ctx;
+  hipDevice_t device;
+
+  HIP_CHECK(hipGetDevice(&device));
+  HIP_CHECK(hipCtxCreate(&ctx, 0, 0));
+  HIP_CHECK(hipMemAllocHost(reinterpret_cast<void**>(&host_memory), sizeof(int)));
+
+  write_integer<<<1, 1>>>(host_memory, validation_number);
+
+  SECTION("device sync") { HIP_CHECK(hipDeviceSynchronize()); }
+
+  SECTION("event sync") {
+    HIP_CHECK(hipEventCreateWithFlags(&event, 0));
+    HIP_CHECK(hipEventRecord(event, nullptr));
+    HIP_CHECK(hipEventSynchronize(event));
+  }
+
+  SECTION("stream sync") { HIP_CHECK(hipStreamSynchronize(nullptr)); }
+
+  REQUIRE(*host_memory == validation_number);
+
+  if (event != nullptr) {
+    HIP_CHECK(hipEventDestroy(event));
+  }
+
+  HIP_CHECK(hipHostFree(host_memory));
+  HIP_CHECK(hipCtxDestroy(ctx));
+}
+
+TEST_CASE("Unit_hipMemAllocHost_Negative") {
+  int* host_memory = nullptr;
+  hipCtx_t ctx;
+  hipDevice_t device;
+
+  HIP_CHECK(hipGetDevice(&device));
+  HIP_CHECK(hipCtxCreate(&ctx, 0, 0));
+
+  SECTION("host memory is nullptr") {
+    HIP_CHECK_ERROR(hipMemAllocHost(nullptr, sizeof(int)), hipErrorInvalidValue);
+  }
+
+  SECTION("size is negative") {
+    HIP_CHECK_ERROR(hipMemAllocHost(reinterpret_cast<void**>(&host_memory), -1), hipErrorOutOfMemory);
+  }
+
+  HIP_CHECK(hipCtxDestroy(ctx));
+}
+
+/*
+ * Verify that a device can read/write to the memory of another device
+*/
+TEST_CASE("Unit_hipMemAllocHost_VerifyAccess") {
+  int devices_number = 0;
+  HIP_CHECK(hipGetDeviceCount(&devices_number));
+  std::vector<int*> devices_memories(devices_number);
+  std::vector<hipCtx_t> devices_ctxs(devices_number);
+
+  for (int device_index = 0; device_index < devices_number; device_index++) {
+    int support_unified_adressing = 0;
+
+    HIP_CHECK(hipSetDevice(device_index));
+    HIP_CHECK(hipDeviceGetAttribute(&support_unified_adressing, hipDeviceAttributeUnifiedAddressing,
+                                    device_index));
+
+    if (!support_unified_adressing) {
+      HipTest::HIP_SKIP_TEST("Unified adressing is not supported.");
+    }
+
+    HIP_CHECK(hipCtxCreate(&devices_ctxs[device_index], 0, device_index));
+    HIP_CHECK(
+        hipMemAllocHost(reinterpret_cast<void**>(&devices_memories[device_index]), sizeof(int)));
+  }
+
+  HIP_CHECK(hipSetDevice(devices_number - 1));
+  write_integer<<<1, 1>>>(devices_memories[0], 0);
+  HIP_CHECK(hipDeviceSynchronize());
+
+  for (int device_index = 1; device_index < devices_number; device_index++) {
+    HIP_CHECK(hipSetDevice(device_index - 1));
+    write_integer<<<1, 1>>>(devices_memories[device_index], device_index);
+    HIP_CHECK(hipDeviceSynchronize());
+  }
+
+  for (int device_index = 1; device_index < devices_number; device_index++) {
+    REQUIRE(*devices_memories[device_index] == device_index);
+    HIP_CHECK(hipCtxDestroy(devices_ctxs[device_index]));
+  }
+}