[rocprofiler-sdk] Install unit tests and helper functions for integration tests (#921)

* [rocprofiler-sdk] Install unit tests and helper functions for integration tests

* Fix rocprofiler-sdk-tests-target export

* Fix handling of cmake policy CMP0174

* Remove -vv from new pytest.ini files

* add unit tests and integration tests.

* add path to ci workflow.

* misc. fixes.

* pc sampling tests.

* bug fixes.

* pc sampling tests fix.

* misc.

* Update CMakeLists.txt

* Update rocprofiler_config_install_tests.cmake, correct license name

* fix units tests install issues.

* fix counters_def file path.

* fix bug, arg shifting.

* vendor pytest-cmake.

* cmake config fix. missing endfunction()

* disable tests, 1.rocprofv3-trace-hip-libs. 2.kernel-tracing. 3.external_correlation 4.rocpd.

* disable buffered-tracing test and remove pytest-cmake from requirements.txt.

* disable hip-graph-tracing test.

* fix building standalone tests to load rocprofiler-sdk cmake package first and then find rocprofiler_sdk_pytest module.

* addressed comments: 1.add local bin path to code cov workflow. 2.add to cmake prefix path local bin. 3.use ROCPROFILER_MEMCHECK_PRELOAD_ENV_VALUE 4.misc. fix

* enabled back tests api_buffered, external_correlation_id, hip-graph, kernel-tracing, rocpd, tracing-hip-in-libraries. and misc fixes(formating, extra fixtures for agent-index tests.)

* cpack to use llvm bin for .hsaco debug symbols.

* psdb tests fixes.

* EOL.

* misc. fixes and Disable api_buffered_tracing, external_correlation_id, hip-graph-tracing, kernel-tracing, rocpd, summary, tracing-hip-libraries, tracing-plus-counter-collection.

* fix incorrect cmakelists file.

* strip smallkernel.bin

* format.

* revert disabled tests commit.

* misc. fix in counter tests.

* misc.

* search codeobj unit test assets in curr bin and install bin.

* refactor newly added rocpd tests.

* modify tests for newly added hip-host-tracing.

* add LD LIB path to units, psdb is failing due to libs not being found.

---------

Co-authored-by: Venkateshwar Reddy Kandula <venkateshwar.kandula1306@gmail.com>
Co-authored-by: Venkateshwar Reddy Kandula <Venkateshwarreddy.Kandula@amd.com>
Co-authored-by: JeniferC99 <150404595+JeniferC99@users.noreply.github.com>

projects/rocprofiler-sdk/tests/rocprofv3/conversion-script/CMakeLists.txt

@@ -34,23 +34,21 @@ find_package(rocprofiler-sdk REQUIRED)
 rocprofiler_configure_pytest_files(COPY validate.py input.txt conftest.py
                                    CONFIG pytest.ini)
 
-add_test(
-    NAME rocprofv3-test-conversion-script-execute
-    COMMAND
-        $<TARGET_FILE:rocprofiler-sdk::rocprofv3> -i
-        ${CMAKE_CURRENT_BINARY_DIR}/input.txt -T -d
-        ${CMAKE_CURRENT_BINARY_DIR}/out_conversion_script -o pmc1 --output-format csv --
-        $<TARGET_FILE:vector-ops>)
-
 string(REPLACE "LD_PRELOAD=" "ROCPROF_PRELOAD=" PRELOAD_ENV
                "${ROCPROFILER_MEMCHECK_PRELOAD_ENV}")
 
-set(cc-env-pmc "${PRELOAD_ENV}")
-
-set_tests_properties(
-    rocprofv3-test-conversion-script-execute
-    PROPERTIES TIMEOUT 45 LABELS "integration-tests" ENVIRONMENT "${cc-env-pmc}"
-               FAIL_REGULAR_EXPRESSION "${ROCPROFILER_DEFAULT_FAIL_REGEX}")
+rocprofiler_add_integration_execute_test(
+    rocprofv3-test-conversion-script
+    COMMAND
+        $<TARGET_FILE:rocprofiler-sdk::rocprofv3> -i ${CMAKE_CURRENT_BINARY_DIR}/input.txt
+        -T -d ${CMAKE_CURRENT_BINARY_DIR}/out_conversion_script -o pmc1 --output-format
+        csv -- $<TARGET_FILE:vector-ops>
+    DEPENDS vector-ops
+    LABELS "integration-tests"
+    TIMEOUT 45
+    PRELOAD "${PRELOAD_ENV}"
+    FAIL_REGULAR_EXPRESSION "${ROCPROFILER_DEFAULT_FAIL_REGEX}"
+    FIXTURES_SETUP rocprofv3-test-conversion-script)
 
 set(convert_tests rocprofv3-test-conversion-script-convert-no-agent-prefix
                   rocprofv3-test-conversion-script-convert-agent-prefix)
@@ -74,45 +72,41 @@ foreach(i RANGE 0 ${convert_test_length})
     list(GET agent_index_flag ${i} flag)
     list(GET validate_tests ${i} validate_test_name)
     if(${flag})
-        add_test(
-            NAME ${test_name}
-            COMMAND
-                ${Python3_EXECUTABLE}
-                $<TARGET_FILE:rocprofiler-sdk::convert-counters-collection-format>
-                --input ${CMAKE_CURRENT_BINARY_DIR}/out_conversion_script --output
-                ${output} --retain-agent-prefix)
-
-        add_test(NAME ${validate_test_name}
-                 COMMAND ${Python3_EXECUTABLE} ${CMAKE_CURRENT_BINARY_DIR}/validate.py
-                         ${PYTEST_ARGS} --input ${output} --retain-agent-prefix true)
+        set(conversion_cmd
+            ${Python3_EXECUTABLE}
+            $<TARGET_FILE:rocprofiler-sdk::convert-counters-collection-format>
+            --input
+            ${CMAKE_CURRENT_BINARY_DIR}/out_conversion_script
+            --output
+            ${output}
+            --retain-agent-prefix)
+        set(validate_args --retain-agent-prefix true)
     else()
-        add_test(
-            NAME ${test_name}
-            COMMAND
-                ${Python3_EXECUTABLE}
-                $<TARGET_FILE:rocprofiler-sdk::convert-counters-collection-format>
-                --input ${CMAKE_CURRENT_BINARY_DIR}/out_conversion_script --output
-                ${output})
-
-        add_test(NAME ${validate_test_name}
-                 COMMAND ${Python3_EXECUTABLE} ${CMAKE_CURRENT_BINARY_DIR}/validate.py
-                         ${PYTEST_ARGS} --input ${output} --retain-agent-prefix false)
+        set(conversion_cmd
+            ${Python3_EXECUTABLE}
+            $<TARGET_FILE:rocprofiler-sdk::convert-counters-collection-format> --input
+            ${CMAKE_CURRENT_BINARY_DIR}/out_conversion_script --output ${output})
+        set(validate_args --retain-agent-prefix false)
     endif()
-    set_tests_properties(
+
+    rocprofiler_add_integration_execute_test(
         ${test_name}
-        PROPERTIES TIMEOUT 45 LABELS "integration-tests" DEPENDS
-                   rocprofv3-test-conversion-script-execute FAIL_REGULAR_EXPRESSION
-                   "${ROCPROFILER_DEFAULT_FAIL_REGEX}")
-    set_tests_properties(
+        COMMAND ${conversion_cmd}
+        DEPENDS rocprofiler-sdk::convert-counters-collection-format
+        TIMEOUT 45
+        LABELS "integration-tests"
+        PRELOAD "${PRELOAD_ENV}"
+        FIXTURES_REQUIRED rocprofv3-test-conversion-script
+        FIXTURES_SETUP ${test_name})
+
+    rocprofiler_add_integration_validate_test(
         ${validate_test_name}
-        PROPERTIES TIMEOUT
-                   45
-                   LABELS
-                   "integration-tests"
-                   DEPENDS
-                   ${test_name}
-                   FAIL_REGULAR_EXPRESSION
-                   "${ROCPROFILER_DEFAULT_FAIL_REGEX}"
-                   DISABLED
-                   "${ROCPROFILER_DISABLE_UNSTABLE_CTESTS}")
+        TEST_PATHS validate.py
+        COPY conftest.py input.txt
+        CONFIG pytest.ini
+        ARGS --input ${output} ${validate_args}
+        TIMEOUT 45
+        LABELS "integration-tests"
+        FIXTURES_REQUIRED ${test_name}
+        UNSTABLE)
 endforeach()

projects/rocprofiler-sdk/tests/rocprofv3/conversion-script/pytest.ini

@@ -22,6 +22,6 @@
 
 
 [pytest]
-addopts = --durations=20 -rA -s -vv
+addopts = --durations=20 -rA -s
 testpaths = validate.py
 pythonpath = @ROCPROFILER_SDK_TESTS_BINARY_DIR@/pytest-packages