From a320f27ea105a5c2c6b6e9d45b71c50e474a6df3 Mon Sep 17 00:00:00 2001 From: sdashmiz Date: Tue, 21 Jun 2022 09:48:09 -0400 Subject: [PATCH] SWDEV-341993 - correct parameters checks flags, ptr and stream Signed-off-by: sdashmiz Change-Id: I306be503e8c15db1641eaeeae73e349a99f871ae [ROCm/clr commit: 683b28d5732a13539cde6712502253cfcfac0539] --- projects/clr/hipamd/src/hip_stream_ops.cpp | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/projects/clr/hipamd/src/hip_stream_ops.cpp b/projects/clr/hipamd/src/hip_stream_ops.cpp index 6e5be889af..e7f45b1c24 100644 --- a/projects/clr/hipamd/src/hip_stream_ops.cpp +++ b/projects/clr/hipamd/src/hip_stream_ops.cpp @@ -27,6 +27,14 @@ hipError_t ihipStreamOperation(hipStream_t stream, cl_command_type cmdType, void size_t offset = 0; unsigned int outFlags = 0; + if (ptr == nullptr) { + return hipErrorInvalidValue; + } + + if (!hip::isValid(stream)) { + return hipErrorInvalidValue; + } + amd::Memory* memory = getMemoryObject(ptr, offset); if (!memory) { return hipErrorInvalidValue; @@ -54,7 +62,7 @@ hipError_t ihipStreamOperation(hipStream_t stream, cl_command_type cmdType, void outFlags = ROCCLR_STREAM_WAIT_VALUE_NOR; break; default: - ShouldNotReachHere(); + return hipErrorInvalidValue; break; } } else if (cmdType != ROCCLR_COMMAND_STREAM_WRITE_VALUE) {