From b233db729bd09961277a5a56bc4f3197549c85f3 Mon Sep 17 00:00:00 2001 From: Maisam Arif Date: Mon, 30 Sep 2024 13:23:45 -0500 Subject: [PATCH 1/3] Corrected throttle status value check Signed-off-by: Maisam Arif Change-Id: I2d75108c64c3ca3e290be1dd5b8c1435c5576f91 --- amdsmi_cli/amdsmi_commands.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/amdsmi_cli/amdsmi_commands.py b/amdsmi_cli/amdsmi_commands.py index b232c29c21..058a31c088 100644 --- a/amdsmi_cli/amdsmi_commands.py +++ b/amdsmi_cli/amdsmi_commands.py @@ -2146,9 +2146,10 @@ class AMDSMICommands(): for key, value in throttle_status.items(): if "active" in key: - throttle_status[key] = "NOT ACTIVE" - if value: + if value is True: throttle_status[key] = "ACTIVE" + elif value is False: + throttle_status[key] = "NOT ACTIVE" continue if "percent" not in key: From 30f6a114e10fd563089d1c3efa364a287bb18d6e Mon Sep 17 00:00:00 2001 From: Maisam Arif Date: Tue, 1 Oct 2024 14:57:16 -0500 Subject: [PATCH 2/3] [SWDEV-488819] - Backward Compatibility Disclaimer Signed-off-by: Maisam Arif Change-Id: I8b00d2009e3d01da134ac21ddcb0994357d76a54 --- README.md | 2 ++ amdsmi_cli/README.md | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 90eee01bd8..df5d18518b 100644 --- a/README.md +++ b/README.md @@ -19,6 +19,8 @@ installed to query firmware information and hardware IPs. ## Install CLI Tool and Libraries +**Disclaimer: CLI Tool is provided as an example code to aid the development of telemetry tools and is not guaranteed to be backwards compatible. The Python or C++ Library is recommended as a reliable data source.** + ### Requirements * python 3.6.8+ 64-bit diff --git a/amdsmi_cli/README.md b/amdsmi_cli/README.md index 2c782ae66c..f7aa99f01c 100644 --- a/amdsmi_cli/README.md +++ b/amdsmi_cli/README.md @@ -1,6 +1,6 @@ # AMD SMI CLI Tool -**Disclaimer: CLI Tool is provided as an example code to aid the development of telemetry tools. Python or C++ Library is recommended as a reliable data source.** +**Disclaimer: CLI Tool is provided as an example code to aid the development of telemetry tools and is not guaranteed to be backwards compatible. The Python or C++ Library is recommended as a reliable data source.** This tool acts as a command line interface for manipulating and monitoring the amdgpu kernel, and is intended to replace From e402fe7f36e31ef8d7be334cb68802bddaeede78 Mon Sep 17 00:00:00 2001 From: Maisam Arif Date: Wed, 2 Oct 2024 14:24:03 -0500 Subject: [PATCH 3/3] Udpated market name Signed-off-by: Maisam Arif Change-Id: I71948b185b6ac60610fedf2d48dd9c95c26e5777 --- src/amd_smi/amd_smi_utils.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd_smi/amd_smi_utils.cc b/src/amd_smi/amd_smi_utils.cc index 1e490d3829..80af991bda 100644 --- a/src/amd_smi/amd_smi_utils.cc +++ b/src/amd_smi/amd_smi_utils.cc @@ -584,7 +584,7 @@ amdsmi_status_t smi_amdgpu_get_market_name_from_dev_id(uint32_t device_id, char break; case 0x74a9: case 0x74bd: - strcpy(market_name, "MI300XHF"); + strcpy(market_name, "AMD Instinct MI300X HF"); break; default: return AMDSMI_STATUS_API_FAILED;