From a4fd8f4667e9ce50e6d25a1578000583deed4c04 Mon Sep 17 00:00:00 2001 From: Rahul Vaidya Date: Mon, 28 Apr 2025 10:22:38 -0500 Subject: [PATCH] Fix build issues caused by 2.24.3 sync (#118) --- .github/CODEOWNERS | 2 +- src/common.h | 6 ++++++ verifiable/verifiable.cu | 5 +++++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 072f7d1a07..cd1b82fa42 100755 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,4 +1,4 @@ -* @wenkaidu @gilbertlee-amd @akolliasAMD @edgargabriel @PedramAlizadeh @nusislam @nileshnegi @KawtharShafie @AtlantaPepsi @mberenjk @corey-derochie-amd @mustafabar @thananon @JhaShweta1 @haripriya-amd +* @wenkaidu @gilbertlee-amd @akolliasAMD @edgargabriel @PedramAlizadeh @nusislam @nileshnegi @KawtharShafie @AtlantaPepsi @mberenjk @corey-derochie-amd @mustafabar @thananon @JhaShweta1 @rahulvaidya20 @haripriya-amd # Documentation files doc/ @ROCm/rocm-documentation diff --git a/src/common.h b/src/common.h index 7982c09ccc..961059c578 100644 --- a/src/common.h +++ b/src/common.h @@ -22,6 +22,12 @@ #include #include +// Ensures backward compatibility for FP8 types in RCCL 2.24.3 and later +#if NCCL_VERSION_CODE >= NCCL_VERSION(2,24,3) + #define ncclFp8E4M3 ncclFloat8e4m3 + #define ncclFp8E5M2 ncclFloat8e5m2 +#endif + // For nccl.h < 2.13 since we define a weak fallback extern "C" char const* ncclGetLastError(ncclComm_t comm); diff --git a/verifiable/verifiable.cu b/verifiable/verifiable.cu index 32c13b048e..d157f8aa68 100644 --- a/verifiable/verifiable.cu +++ b/verifiable/verifiable.cu @@ -23,6 +23,11 @@ #if NCCL_VERSION_CODE >= NCCL_VERSION(2,10,0) && RCCL_FLOAT8 == 1 #define HAVE_ncclfp8 1 + // Ensures backward compatibility for FP8 types in RCCL 2.24.3 and later + #if NCCL_VERSION_CODE >= NCCL_VERSION(2,24,3) + #define ncclFp8E4M3 ncclFloat8e4m3 + #define ncclFp8E5M2 ncclFloat8e5m2 + #endif #else #define HAVE_ncclfp8 0 #endif