AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SWDEV-505971 - change setArgument arg from uint32_t to uint64_t

Browse Source 
We are passing this arg as an address, and memcpy complains about
overreading (8 bytes instead of 4).

Change-Id: Ica9207f6c5f6056a4bfc968280c76e779ded13ae
This commit is contained in:
Jatin Chaudhary
2024-12-20 11:46:42 +00:00
committed by Jatin Jaikishan Chaudhary
parent 8155943c5f
commit a6f2a2c2af
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
rocclr/device/blit.hpp
+1 -1
View File
@@ -236,7 +236,7 @@ class BlitManager : public amd::HeapObject {
//! Stream batch memory operation //! Stream batch memory operation
virtual bool batchMemOps(const void* paramArray, virtual bool batchMemOps(const void* paramArray,
size_t paramSize, size_t paramSize,
uint32_t count uint64_t count
) const = 0; ) const = 0;
//! Enables synchronization on blit operations //! Enables synchronization on blit operations
rocclr/device/pal/palblit.hpp
+1 -1
View File
@@ -478,7 +478,7 @@ class KernelBlitManager : public DmaBlitManager {
//! Batch memory ops- Submits batch of streamWaits and streamWrite operations. //! Batch memory ops- Submits batch of streamWaits and streamWrite operations.
virtual bool batchMemOps(const void* paramArray, virtual bool batchMemOps(const void* paramArray,
size_t paramSize, size_t paramSize,
uint32_t count) const { uint64_t count) const {
assert(!"Unimplemented"); assert(!"Unimplemented");
return false; return false;
} }
rocclr/device/rocm/rocblit.cpp
+1 -1
View File
@@ -2513,7 +2513,7 @@ bool KernelBlitManager::streamOpsWait(device::Memory& memory, uint64_t value, si
// ================================================================================================ // ================================================================================================
bool KernelBlitManager::batchMemOps(const void* paramArray, size_t paramSize, bool KernelBlitManager::batchMemOps(const void* paramArray, size_t paramSize,
uint32_t count) const { uint64_t count) const {
amd::ScopedLock k(lockXferOps_); amd::ScopedLock k(lockXferOps_);
bool result = false; bool result = false;
uint blitType = BatchMemOp; uint blitType = BatchMemOp;
rocclr/device/rocm/rocblit.hpp
+1 -1
View File
@@ -505,7 +505,7 @@ class KernelBlitManager : public DmaBlitManager {
) const; ) const;
//! Batch memory ops- Submits batch of streamWaits and streamWrite operations. //! Batch memory ops- Submits batch of streamWaits and streamWrite operations.
virtual bool batchMemOps(const void* paramArray, size_t paramSize, uint32_t count) const; virtual bool batchMemOps(const void* paramArray, size_t paramSize, uint64_t count) const;
virtual amd::Monitor* lockXfer() const { return &lockXferOps_; } virtual amd::Monitor* lockXfer() const { return &lockXferOps_; }