AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libhsakmt: Fix improper usage of hsaKmtRegisterMemoryToNodes

Browse Source 
It's unnecessary to register non-userptr.

Change-Id: Iefd329578365e036e2fe7e4d5c9c0c3d0976f67c
Signed-off-by: Lang Yu <Lang.Yu@amd.com>
Signed-off-by: Chris Freehill <cfreehil@amd.com>
This commit is contained in:
Lang Yu
2024-04-22 16:02:34 +08:00
committed by Chris Freehill
parent 5eb2a2660c
commit a7a712fb36
3 changed files with 8 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libhsakmt/tests/kfdtest/src/KFDTestUtil.cpp
+2 -8
View File
@@ -468,14 +468,11 @@ unsigned int HsaMemoryBuffer::Node() const {
}
int HsaMemoryBuffer::MapMemToNodes(unsigned int *nodes, unsigned int nodes_num) {
HsaMemMapFlags mapFlags = {0};
int ret, bit;
ret = hsaKmtRegisterMemoryToNodes(m_pBuf, m_Size, nodes_num, nodes);
if (ret != 0)
return ret;
ret = hsaKmtMapMemoryToGPU(m_pBuf, m_Size, NULL);
ret = hsaKmtMapMemoryToGPUNodes(m_pBuf, m_Size, NULL, mapFlags, nodes_num, nodes);
if (ret != 0) {
hsaKmtDeregisterMemory(m_pBuf);
return ret;
}
@@ -494,7 +491,6 @@ int HsaMemoryBuffer::UnmapMemToNodes(unsigned int *nodes, unsigned int nodes_num
if (ret)
return ret;
hsaKmtDeregisterMemory(m_pBuf);
for (unsigned int i = 0; i < nodes_num; i++) {
bit = 1 << nodes[i];
m_MappedNodes &= ~bit;
@@ -528,7 +524,6 @@ void HsaMemoryBuffer::UnmapAllNodes() {
* TODO: When thunk is updated, use hsaKmtRegisterToNodes. Then nodes will be used
*/
hsaKmtUnmapMemoryToGPU(m_pBuf);
hsaKmtDeregisterMemory(m_pBuf);
m_MappedNodes = 0;
@@ -543,7 +538,6 @@ HsaMemoryBuffer::~HsaMemoryBuffer() {
if (is_dgpu()) {
if (m_MappedNodes) {
hsaKmtUnmapMemoryToGPU(m_pBuf);
hsaKmtDeregisterMemory(m_pBuf);
}
}
hsaKmtFreeMemory(m_pBuf, m_Size);