From a7ea5365242e43a71ce5a1fbbace04ef96068c28 Mon Sep 17 00:00:00 2001 From: Maisam Arif Date: Fri, 12 Jul 2024 09:11:56 -0500 Subject: [PATCH] [SWDEV-439701] Add missing parameter CLI error cases Signed-off-by: Maisam Arif Change-Id: I8a6623ccdd7b16be320ea0f6f48b7b6cb3511983 [ROCm/amdsmi commit: 0fc779b14f7990a868e6c08b01c0c995e125e8fc] --- projects/amdsmi/amdsmi_cli/amdsmi_parser.py | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/projects/amdsmi/amdsmi_cli/amdsmi_parser.py b/projects/amdsmi/amdsmi_cli/amdsmi_parser.py index 4d2984d620..4b9c55124b 100644 --- a/projects/amdsmi/amdsmi_cli/amdsmi_parser.py +++ b/projects/amdsmi/amdsmi_cli/amdsmi_parser.py @@ -140,7 +140,10 @@ class AMDSMIParser(argparse.ArgumentParser): return int(int_value) outputformat = self.helpers.get_output_format() - raise amdsmi_cli_exceptions.AmdSmiInvalidParameterValueException(int_value, outputformat) + if int_value == "": + raise amdsmi_cli_exceptions.AmdSmiMissingParameterValueException(int_value, outputformat) + else: + raise amdsmi_cli_exceptions.AmdSmiInvalidParameterValueException(int_value, outputformat) def _positive_int(self, int_value): @@ -150,7 +153,10 @@ class AMDSMIParser(argparse.ArgumentParser): return int(int_value) outputformat = self.helpers.get_output_format() - raise amdsmi_cli_exceptions.AmdSmiInvalidParameterValueException(int_value, outputformat) + if int_value == "": + raise amdsmi_cli_exceptions.AmdSmiMissingParameterValueException(int_value, outputformat) + else: + raise amdsmi_cli_exceptions.AmdSmiInvalidParameterValueException(int_value, outputformat) def _is_valid_string(self, string_value): @@ -160,8 +166,10 @@ class AMDSMIParser(argparse.ArgumentParser): return string_value outputformat = self.helpers.get_output_format() - raise amdsmi_cli_exceptions.AmdSmiInvalidParameterValueException(string_value, outputformat) - + if string_value == "": + raise amdsmi_cli_exceptions.AmdSmiMissingParameterValueException(string_value, outputformat) + else: + raise amdsmi_cli_exceptions.AmdSmiInvalidParameterValueException(string_value, outputformat) def _check_output_file_path(self): """ Argument action validator: