From a83594277d541dd59bf8382b64b0374419ad2456 Mon Sep 17 00:00:00 2001 From: Julia Jiang Date: Tue, 25 Oct 2022 17:14:52 -0400 Subject: [PATCH] SWDEV-360748 - Update return value for hipExtGetLinkTypeAndHopCount_Positive_Basic test on Windows Change-Id: I0eb984da6e96c2409e1b1bbda61ae694c8bebe94 [ROCm/clr commit: 9d616ad0f43eb43a7053553865d038c1df556474] --- projects/clr/rocclr/device/device.hpp | 1 - projects/clr/rocclr/device/pal/paldevice.hpp | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/projects/clr/rocclr/device/device.hpp b/projects/clr/rocclr/device/device.hpp index c93fe5016b..87fd7af76a 100644 --- a/projects/clr/rocclr/device/device.hpp +++ b/projects/clr/rocclr/device/device.hpp @@ -1928,7 +1928,6 @@ class Device : public RuntimeObject { //! Returns value for LinkAttribute for lost of vectors virtual bool findLinkInfo(const amd::Device& other_device, std::vector* link_attr) { - ShouldNotReachHere(); return false; } diff --git a/projects/clr/rocclr/device/pal/paldevice.hpp b/projects/clr/rocclr/device/pal/paldevice.hpp index 04ec9ef602..aaae295fea 100644 --- a/projects/clr/rocclr/device/pal/paldevice.hpp +++ b/projects/clr/rocclr/device/pal/paldevice.hpp @@ -617,8 +617,8 @@ class Device : public NullDevice { virtual bool findLinkInfo(const amd::Device& other_device, std::vector* link_attr) { - // Not implemented in PAL yet - ShouldNotReachHere(); + // Unsupported in PAL + LogPrintfError("The function is unsupported on Windows"); return false; }