AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SWDEV-404889 - Don't report trap handler

Browse Source 
Trap handler shouldn't be reported for debugger and RGP

Change-Id: I149dacfed49584503c1874120d5f552fdec323a7


[ROCm/clr commit: 8f9a20738e]
This commit is contained in:
German Andryeyev
2024-02-21 18:24:38 -05:00
parent bb17583545
commit a8b35c3a18
2 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/clr/rocclr/device/pal/palprogram.cpp
+9 -3
View File
@@ -782,7 +782,13 @@ bool LightningProgram::createKernels(void* binary, size_t binSize, bool useUnifo
return false;
}
status = loader_->FreezeExecutable(executable_, nullptr);
if (isInternal() && (owner()->language() == amd::Program::Assembly)) {
// Don't register trap handler with the debugger, since user shouldn't see this kernel
status = executable_->Freeze(nullptr);
trapHandler_ = true;
} else {
status = loader_->FreezeExecutable(executable_, nullptr);
}
if (status != HSA_STATUS_SUCCESS) {
LogError("Error: Freezing the executable failed.");
return false;
@@ -795,8 +801,8 @@ bool LightningProgram::createKernels(void* binary, size_t binSize, bool useUnifo
bool LightningProgram::setKernels(void* binary, size_t binSize, amd::Os::FileDesc fdesc,
size_t foffset, std::string uri) {
#if defined(USE_COMGR_LIBRARY)
// Collect the information about compiled binary
if (!isNull() && (palDevice().rgpCaptureMgr() != nullptr)) {
// Collect the information about compiled binary, except the trap handler
if (!isNull() && (palDevice().rgpCaptureMgr() != nullptr) && !isTrapHandler()) {
apiHash_ = palDevice().rgpCaptureMgr()->AddElfBinary(
binary, binSize, binary, binSize, codeSegGpu_->iMem(), codeSegGpu_->offset());
}