From 8ddc1a3fe1d1ffb940f538d5adad484230354514 Mon Sep 17 00:00:00 2001 From: Cole Ramos Date: Wed, 19 Jul 2023 10:47:12 -0500 Subject: [PATCH 1/3] Update issue templates --- .github/ISSUE_TEMPLATE/bug_report.md | 33 ++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/bug_report.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 0000000000..4dec4e1b16 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,33 @@ +--- +name: Bug report +about: Report a bug you've encountered for further investigation +title: '' +labels: bug +assignees: '' + +--- + +**Describe the bug** +A clear and concise description of what the bug is. + +**Development Environment:** + - Linux Distribution: [e.g. Ubuntu20.04, RHEL8] + - Omniperf Version: [e.g. try `omniperf --version`] + - GPU: [e.g. Mi100, Mi200] + - Custer (if applicable): [e.g. Crusher, ] + +**To Reproduce** +Steps to reproduce the behavior: +1. Run '...' +2. Go to '...' +2. Click on '....' +4. See error + +**Expected behavior** +A clear and concise description of what you expected to happen. + +**Screenshots** +If applicable, add screenshots to help explain your problem. + +**Additional context** +Add any other context about the problem here. From d4c4c733678ad8c1e29602f26d2b750b66743311 Mon Sep 17 00:00:00 2001 From: Cole Ramos Date: Wed, 19 Jul 2023 10:49:01 -0500 Subject: [PATCH 2/3] Update issue templates --- .github/ISSUE_TEMPLATE/feature_request.md | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/feature_request.md diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md new file mode 100644 index 0000000000..11fc491ef1 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -0,0 +1,20 @@ +--- +name: Feature request +about: Suggest an idea for this project +title: '' +labels: enhancement +assignees: '' + +--- + +**Is your feature request related to a problem? Please describe.** +A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] + +**Describe the solution you'd like** +A clear and concise description of what you want to happen. + +**Describe alternatives you've considered** +A clear and concise description of any alternative solutions or features you've considered. + +**Additional context** +Add any other context or screenshots about the feature request here. From 132cb37d692efc108411b18f56ac8a6132c8d7c6 Mon Sep 17 00:00:00 2001 From: JoseSantosAMD Date: Tue, 15 Aug 2023 15:04:23 -0500 Subject: [PATCH 3/3] add pct of peak to tables Signed-off-by: JoseSantosAMD --- src/omniperf_analyze/configs/gfx906/1200_lds.yaml | 5 +++++ .../configs/gfx906/1300_instruction-cache.yaml | 3 +++ .../configs/gfx906/1400_constant-cache.yaml | 3 +++ src/omniperf_analyze/configs/gfx906/1600_L1_cache.yaml | 5 +++++ src/omniperf_analyze/configs/gfx908/1200_lds.yaml | 5 +++++ .../configs/gfx908/1300_instruction-cache.yaml | 3 +++ .../configs/gfx908/1400_constant-cache.yaml | 3 +++ src/omniperf_analyze/configs/gfx908/1600_L1_cache.yaml | 5 +++++ .../configs/gfx90a/1100_compute-unit-compute-pipeline.yaml | 7 +++++++ src/omniperf_analyze/configs/gfx90a/1200_lds.yaml | 5 +++++ .../configs/gfx90a/1300_instruction-cache.yaml | 3 +++ .../configs/gfx90a/1400_constant-cache.yaml | 3 +++ src/omniperf_analyze/configs/gfx90a/1600_L1_cache.yaml | 5 +++++ 13 files changed, 55 insertions(+) diff --git a/src/omniperf_analyze/configs/gfx906/1200_lds.yaml b/src/omniperf_analyze/configs/gfx906/1200_lds.yaml index 218ad2cdad..3fd52c3b1b 100644 --- a/src/omniperf_analyze/configs/gfx906/1200_lds.yaml +++ b/src/omniperf_analyze/configs/gfx906/1200_lds.yaml @@ -14,6 +14,7 @@ Panel Config: header: metric: Metric value: Value + unit: Unit tips: Tips style: type: simple_bar @@ -23,17 +24,21 @@ Panel Config: metric: Utilization: value: AVG(((100 * SQ_LDS_IDX_ACTIVE) / (GRBM_GUI_ACTIVE * $numCU))) + unit: Pct of Peak tips: Access Rate: value: AVG(((200 * SQ_ACTIVE_INST_LDS) / (GRBM_GUI_ACTIVE * $numCU))) + unit: Pct of Peak tips: Bandwidth (Pct-of-Peak): value: AVG((((((SQ_LDS_IDX_ACTIVE - SQ_LDS_BANK_CONFLICT) * 4) * TO_INT($LDSBanks)) / (EndNs - BeginNs)) / (($sclk * $numCU) * 0.00128))) + unit: Pct of Peak tips: Bank Conflict Rate: value: AVG((((SQ_LDS_BANK_CONFLICT * 3.125) / (SQ_LDS_IDX_ACTIVE - SQ_LDS_BANK_CONFLICT)) if ((SQ_LDS_IDX_ACTIVE - SQ_LDS_BANK_CONFLICT) != 0) else None)) + unit: Pct of Peak tips: - metric_table: diff --git a/src/omniperf_analyze/configs/gfx906/1300_instruction-cache.yaml b/src/omniperf_analyze/configs/gfx906/1300_instruction-cache.yaml index fb9f384e11..361cb9ae21 100644 --- a/src/omniperf_analyze/configs/gfx906/1300_instruction-cache.yaml +++ b/src/omniperf_analyze/configs/gfx906/1300_instruction-cache.yaml @@ -14,6 +14,7 @@ Panel Config: header: metric: Metric value: Value + unit: Unit tips: Tips style: type: simple_bar @@ -24,10 +25,12 @@ Panel Config: Bandwidth: value: AVG(((SQC_ICACHE_REQ * 100000) / (($sclk * $numSQC) * (EndNs - BeginNs)))) + unit: Pct of Peak tips: Cache Hit: value: AVG(((SQC_ICACHE_HITS * 100) / ((SQC_ICACHE_HITS + SQC_ICACHE_MISSES) + SQC_ICACHE_MISSES_DUPLICATE))) + unit: Pct of Peak tips: - metric_table: diff --git a/src/omniperf_analyze/configs/gfx906/1400_constant-cache.yaml b/src/omniperf_analyze/configs/gfx906/1400_constant-cache.yaml index 91a2d6c9f4..eec636b385 100644 --- a/src/omniperf_analyze/configs/gfx906/1400_constant-cache.yaml +++ b/src/omniperf_analyze/configs/gfx906/1400_constant-cache.yaml @@ -14,6 +14,7 @@ Panel Config: header: mertic: Metric value: Value + unit: Unit tips: Tips style: type: simple_bar @@ -24,11 +25,13 @@ Panel Config: Bandwidth: value: AVG(((SQC_DCACHE_REQ * 100000) / (($sclk * $numSQC) * (EndNs - BeginNs)))) + unit: Pct of Peak tips: Cache Hit: value: AVG((((SQC_DCACHE_HITS * 100) / (SQC_DCACHE_HITS + SQC_DCACHE_MISSES + SQC_DCACHE_MISSES_DUPLICATE)) if ((SQC_DCACHE_HITS + SQC_DCACHE_MISSES + SQC_DCACHE_MISSES_DUPLICATE) != 0) else None)) + unit: Pct of Peak tips: - metric_table: diff --git a/src/omniperf_analyze/configs/gfx906/1600_L1_cache.yaml b/src/omniperf_analyze/configs/gfx906/1600_L1_cache.yaml index c734e21c8b..e1a7e29ccc 100644 --- a/src/omniperf_analyze/configs/gfx906/1600_L1_cache.yaml +++ b/src/omniperf_analyze/configs/gfx906/1600_L1_cache.yaml @@ -14,6 +14,7 @@ Panel Config: header: metric: Metric value: Value + unit: Unit tips: Tips style: type: simple_bar @@ -24,20 +25,24 @@ Panel Config: Buffer Coalescing: value: AVG(((((TA_TOTAL_WAVEFRONTS_sum * 64) * 100) / (TCP_TOTAL_ACCESSES_sum * 4)) if (TCP_TOTAL_ACCESSES_sum != 0) else None)) + unit: Pct of Peak tips: Cache Util: value: AVG((((TCP_GATE_EN2_sum * 100) / TCP_GATE_EN1_sum) if (TCP_GATE_EN1_sum != 0) else None)) + unit: Pct of Peak tips: Cache BW: value: ((100 * AVG(((TCP_TOTAL_CACHE_ACCESSES_sum * 64) / (EndNs - BeginNs)))) / ((($sclk / 1000) * 64) * $numCU)) + unit: Pct of Peak tips: Cache Hit: value: AVG(((100 - ((100 * (((TCP_TCC_READ_REQ_sum + TCP_TCC_WRITE_REQ_sum) + TCP_TCC_ATOMIC_WITH_RET_REQ_sum) + TCP_TCC_ATOMIC_WITHOUT_RET_REQ_sum)) / TCP_TOTAL_CACHE_ACCESSES_sum)) if (TCP_TOTAL_CACHE_ACCESSES_sum != 0) else None)) + unit: Pct of Peak tips: - metric_table: diff --git a/src/omniperf_analyze/configs/gfx908/1200_lds.yaml b/src/omniperf_analyze/configs/gfx908/1200_lds.yaml index 218ad2cdad..3fd52c3b1b 100644 --- a/src/omniperf_analyze/configs/gfx908/1200_lds.yaml +++ b/src/omniperf_analyze/configs/gfx908/1200_lds.yaml @@ -14,6 +14,7 @@ Panel Config: header: metric: Metric value: Value + unit: Unit tips: Tips style: type: simple_bar @@ -23,17 +24,21 @@ Panel Config: metric: Utilization: value: AVG(((100 * SQ_LDS_IDX_ACTIVE) / (GRBM_GUI_ACTIVE * $numCU))) + unit: Pct of Peak tips: Access Rate: value: AVG(((200 * SQ_ACTIVE_INST_LDS) / (GRBM_GUI_ACTIVE * $numCU))) + unit: Pct of Peak tips: Bandwidth (Pct-of-Peak): value: AVG((((((SQ_LDS_IDX_ACTIVE - SQ_LDS_BANK_CONFLICT) * 4) * TO_INT($LDSBanks)) / (EndNs - BeginNs)) / (($sclk * $numCU) * 0.00128))) + unit: Pct of Peak tips: Bank Conflict Rate: value: AVG((((SQ_LDS_BANK_CONFLICT * 3.125) / (SQ_LDS_IDX_ACTIVE - SQ_LDS_BANK_CONFLICT)) if ((SQ_LDS_IDX_ACTIVE - SQ_LDS_BANK_CONFLICT) != 0) else None)) + unit: Pct of Peak tips: - metric_table: diff --git a/src/omniperf_analyze/configs/gfx908/1300_instruction-cache.yaml b/src/omniperf_analyze/configs/gfx908/1300_instruction-cache.yaml index fb9f384e11..361cb9ae21 100644 --- a/src/omniperf_analyze/configs/gfx908/1300_instruction-cache.yaml +++ b/src/omniperf_analyze/configs/gfx908/1300_instruction-cache.yaml @@ -14,6 +14,7 @@ Panel Config: header: metric: Metric value: Value + unit: Unit tips: Tips style: type: simple_bar @@ -24,10 +25,12 @@ Panel Config: Bandwidth: value: AVG(((SQC_ICACHE_REQ * 100000) / (($sclk * $numSQC) * (EndNs - BeginNs)))) + unit: Pct of Peak tips: Cache Hit: value: AVG(((SQC_ICACHE_HITS * 100) / ((SQC_ICACHE_HITS + SQC_ICACHE_MISSES) + SQC_ICACHE_MISSES_DUPLICATE))) + unit: Pct of Peak tips: - metric_table: diff --git a/src/omniperf_analyze/configs/gfx908/1400_constant-cache.yaml b/src/omniperf_analyze/configs/gfx908/1400_constant-cache.yaml index 91a2d6c9f4..eec636b385 100644 --- a/src/omniperf_analyze/configs/gfx908/1400_constant-cache.yaml +++ b/src/omniperf_analyze/configs/gfx908/1400_constant-cache.yaml @@ -14,6 +14,7 @@ Panel Config: header: mertic: Metric value: Value + unit: Unit tips: Tips style: type: simple_bar @@ -24,11 +25,13 @@ Panel Config: Bandwidth: value: AVG(((SQC_DCACHE_REQ * 100000) / (($sclk * $numSQC) * (EndNs - BeginNs)))) + unit: Pct of Peak tips: Cache Hit: value: AVG((((SQC_DCACHE_HITS * 100) / (SQC_DCACHE_HITS + SQC_DCACHE_MISSES + SQC_DCACHE_MISSES_DUPLICATE)) if ((SQC_DCACHE_HITS + SQC_DCACHE_MISSES + SQC_DCACHE_MISSES_DUPLICATE) != 0) else None)) + unit: Pct of Peak tips: - metric_table: diff --git a/src/omniperf_analyze/configs/gfx908/1600_L1_cache.yaml b/src/omniperf_analyze/configs/gfx908/1600_L1_cache.yaml index 7eeed04774..22efba955c 100644 --- a/src/omniperf_analyze/configs/gfx908/1600_L1_cache.yaml +++ b/src/omniperf_analyze/configs/gfx908/1600_L1_cache.yaml @@ -14,6 +14,7 @@ Panel Config: header: metric: Metric value: Value + unit: Unit tips: Tips style: type: simple_bar @@ -24,20 +25,24 @@ Panel Config: Buffer Coalescing: value: AVG(((((TA_TOTAL_WAVEFRONTS_sum * 64) * 100) / (TCP_TOTAL_ACCESSES_sum * 4)) if (TCP_TOTAL_ACCESSES_sum != 0) else None)) + unit: Pct of Peak tips: Cache Util: value: AVG((((TCP_GATE_EN2_sum * 100) / TCP_GATE_EN1_sum) if (TCP_GATE_EN1_sum != 0) else None)) + unit: Pct of Peak tips: Cache BW: value: ((100 * AVG(((TCP_TOTAL_CACHE_ACCESSES_sum * 64) / (EndNs - BeginNs)))) / ((($sclk / 1000) * 64) * $numCU)) + unit: Pct of Peak tips: Cache Hit: value: AVG(((100 - ((100 * (((TCP_TCC_READ_REQ_sum + TCP_TCC_WRITE_REQ_sum) + TCP_TCC_ATOMIC_WITH_RET_REQ_sum) + TCP_TCC_ATOMIC_WITHOUT_RET_REQ_sum)) / TCP_TOTAL_CACHE_ACCESSES_sum)) if (TCP_TOTAL_CACHE_ACCESSES_sum != 0) else None)) + unit: Pct of Peak tips: - metric_table: diff --git a/src/omniperf_analyze/configs/gfx90a/1100_compute-unit-compute-pipeline.yaml b/src/omniperf_analyze/configs/gfx90a/1100_compute-unit-compute-pipeline.yaml index 3e29bc4a24..769212ed5c 100644 --- a/src/omniperf_analyze/configs/gfx90a/1100_compute-unit-compute-pipeline.yaml +++ b/src/omniperf_analyze/configs/gfx90a/1100_compute-unit-compute-pipeline.yaml @@ -14,6 +14,7 @@ Panel Config: header: metric: Metric value: Value + unit: Unit tips: Tips style: type: simple_bar @@ -28,26 +29,32 @@ Panel Config: + (64 * (((SQ_INSTS_VALU_ADD_F64 + SQ_INSTS_VALU_MUL_F64) + SQ_INSTS_VALU_TRANS_F64) + (2 * SQ_INSTS_VALU_FMA_F64)))) / (EndNs - BeginNs)))) / (((($sclk * $numCU) * 64) * 2) / 1000)) + unit: Pct of Peak tips: mfma_flops_bf16_pop: value: ((100 * AVG(((SQ_INSTS_VALU_MFMA_MOPS_BF16 * 512) / (EndNs - BeginNs)))) / ((($sclk * $numCU) * 512) / 1000)) + unit: Pct of Peak tips: mfma_flops_f16_pop: value: ((100 * AVG(((SQ_INSTS_VALU_MFMA_MOPS_F16 * 512) / (EndNs - BeginNs)))) / ((($sclk * $numCU) * 1024) / 1000)) + unit: Pct of Peak tips: mfma_flops_f32_pop: value: ((100 * AVG(((SQ_INSTS_VALU_MFMA_MOPS_F32 * 512) / (EndNs - BeginNs)))) / ((($sclk * $numCU) * 256) / 1000)) + unit: Pct of Peak tips: mfma_flops_f64_pop: value: ((100 * AVG(((SQ_INSTS_VALU_MFMA_MOPS_F64 * 512) / (EndNs - BeginNs)))) / ((($sclk * $numCU) * 256) / 1000)) + unit: Pct of Peak tips: mfma_flops_i8_pop: value: ((100 * AVG(((SQ_INSTS_VALU_MFMA_MOPS_I8 * 512) / (EndNs - BeginNs)))) / ((($sclk * $numCU) * 1024) / 1000)) + unit: Pct of Peak tips: - metric_table: diff --git a/src/omniperf_analyze/configs/gfx90a/1200_lds.yaml b/src/omniperf_analyze/configs/gfx90a/1200_lds.yaml index 218ad2cdad..3fd52c3b1b 100644 --- a/src/omniperf_analyze/configs/gfx90a/1200_lds.yaml +++ b/src/omniperf_analyze/configs/gfx90a/1200_lds.yaml @@ -14,6 +14,7 @@ Panel Config: header: metric: Metric value: Value + unit: Unit tips: Tips style: type: simple_bar @@ -23,17 +24,21 @@ Panel Config: metric: Utilization: value: AVG(((100 * SQ_LDS_IDX_ACTIVE) / (GRBM_GUI_ACTIVE * $numCU))) + unit: Pct of Peak tips: Access Rate: value: AVG(((200 * SQ_ACTIVE_INST_LDS) / (GRBM_GUI_ACTIVE * $numCU))) + unit: Pct of Peak tips: Bandwidth (Pct-of-Peak): value: AVG((((((SQ_LDS_IDX_ACTIVE - SQ_LDS_BANK_CONFLICT) * 4) * TO_INT($LDSBanks)) / (EndNs - BeginNs)) / (($sclk * $numCU) * 0.00128))) + unit: Pct of Peak tips: Bank Conflict Rate: value: AVG((((SQ_LDS_BANK_CONFLICT * 3.125) / (SQ_LDS_IDX_ACTIVE - SQ_LDS_BANK_CONFLICT)) if ((SQ_LDS_IDX_ACTIVE - SQ_LDS_BANK_CONFLICT) != 0) else None)) + unit: Pct of Peak tips: - metric_table: diff --git a/src/omniperf_analyze/configs/gfx90a/1300_instruction-cache.yaml b/src/omniperf_analyze/configs/gfx90a/1300_instruction-cache.yaml index 1a7000e930..c287c13bd7 100644 --- a/src/omniperf_analyze/configs/gfx90a/1300_instruction-cache.yaml +++ b/src/omniperf_analyze/configs/gfx90a/1300_instruction-cache.yaml @@ -14,6 +14,7 @@ Panel Config: header: metric: Metric value: Value + unit: Unit tips: Tips style: type: simple_bar @@ -24,10 +25,12 @@ Panel Config: Bandwidth: value: AVG(((SQC_ICACHE_REQ * 100000) / (($sclk * $numSQC) * (EndNs - BeginNs)))) + unit: Pct of Peak tips: Cache Hit: value: AVG(((SQC_ICACHE_HITS * 100) / ((SQC_ICACHE_HITS + SQC_ICACHE_MISSES) + SQC_ICACHE_MISSES_DUPLICATE))) + unit: Pct of Peak tips: - metric_table: diff --git a/src/omniperf_analyze/configs/gfx90a/1400_constant-cache.yaml b/src/omniperf_analyze/configs/gfx90a/1400_constant-cache.yaml index 91a2d6c9f4..eec636b385 100644 --- a/src/omniperf_analyze/configs/gfx90a/1400_constant-cache.yaml +++ b/src/omniperf_analyze/configs/gfx90a/1400_constant-cache.yaml @@ -14,6 +14,7 @@ Panel Config: header: mertic: Metric value: Value + unit: Unit tips: Tips style: type: simple_bar @@ -24,11 +25,13 @@ Panel Config: Bandwidth: value: AVG(((SQC_DCACHE_REQ * 100000) / (($sclk * $numSQC) * (EndNs - BeginNs)))) + unit: Pct of Peak tips: Cache Hit: value: AVG((((SQC_DCACHE_HITS * 100) / (SQC_DCACHE_HITS + SQC_DCACHE_MISSES + SQC_DCACHE_MISSES_DUPLICATE)) if ((SQC_DCACHE_HITS + SQC_DCACHE_MISSES + SQC_DCACHE_MISSES_DUPLICATE) != 0) else None)) + unit: Pct of Peak tips: - metric_table: diff --git a/src/omniperf_analyze/configs/gfx90a/1600_L1_cache.yaml b/src/omniperf_analyze/configs/gfx90a/1600_L1_cache.yaml index 7ea26db051..28450f2ae3 100644 --- a/src/omniperf_analyze/configs/gfx90a/1600_L1_cache.yaml +++ b/src/omniperf_analyze/configs/gfx90a/1600_L1_cache.yaml @@ -14,6 +14,7 @@ Panel Config: header: metric: Metric value: Value + unit: Unit tips: Tips style: type: simple_bar @@ -24,20 +25,24 @@ Panel Config: Buffer Coalescing: value: AVG(((((TA_TOTAL_WAVEFRONTS_sum * 64) * 100) / (TCP_TOTAL_ACCESSES_sum * 4)) if (TCP_TOTAL_ACCESSES_sum != 0) else None)) + unit: Pct of Peak tips: Cache Util: value: AVG((((TCP_GATE_EN2_sum * 100) / TCP_GATE_EN1_sum) if (TCP_GATE_EN1_sum != 0) else None)) + unit: Pct of Peak tips: Cache BW: value: ((100 * AVG(((TCP_TOTAL_CACHE_ACCESSES_sum * 64) / (EndNs - BeginNs)))) / ((($sclk / 1000) * 64) * $numCU)) + unit: Pct of Peak tips: Cache Hit: value: AVG(((100 - ((100 * (((TCP_TCC_READ_REQ_sum + TCP_TCC_WRITE_REQ_sum) + TCP_TCC_ATOMIC_WITH_RET_REQ_sum) + TCP_TCC_ATOMIC_WITHOUT_RET_REQ_sum)) / TCP_TOTAL_CACHE_ACCESSES_sum)) if (TCP_TOTAL_CACHE_ACCESSES_sum != 0) else None)) + unit: Pct of Peak tips: - metric_table: